From: Krzysztof Kozlowski <krzk@kernel.org>
To: jiebing chen <jiebing.chen@amlogic.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com
Subject: Re: [PATCH v5 1/6] dt-bindings: clock: meson: Add audio power domain for s4 soc
Date: Mon, 14 Jul 2025 08:10:18 +0200 [thread overview]
Message-ID: <88ff3aa4-dfb0-4b65-a061-52544caf46f6@kernel.org> (raw)
In-Reply-To: <20250710-polite-cuddly-platypus-5fe9dc@krzk-bin>
On 10/07/2025 11:56, Krzysztof Kozlowski wrote:
> On Thu, Jul 10, 2025 at 11:35:37AM +0800, jiebing chen wrote:
>> The audio power domain has been detected on S4 device.
>> It must be enabled prior to audio operations.
>>
>> Signed-off-by: jiebing chen <jiebing.chen@amlogic.com>
>> ---
>> .../bindings/clock/amlogic,axg-audio-clkc.yaml | 55 +++++++++++++++++++++-
>> 1 file changed, 54 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> index fd7982dd4ceab82389167079c2258a9acff51a76..c3f0bb9b2ff050394828ba339a7be0c9c48e9a76 100644
>> --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> @@ -21,6 +21,8 @@ properties:
>> - amlogic,axg-audio-clkc
>> - amlogic,g12a-audio-clkc
>> - amlogic,sm1-audio-clkc
>> + - amlogic,s4-audio-clkc
>> + - amlogic,clock-pads-clkc
>
> Keep the list sorted.
>
And now I noticed that I already asked for this at previous versions!
Respond to and implement feedback, not just ignore it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-14 6:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 3:35 [PATCH v5 0/6] Add support for S4 audio jiebing chen via B4 Relay
2025-07-10 3:35 ` [PATCH v5 1/6] dt-bindings: clock: meson: Add audio power domain for s4 soc jiebing chen via B4 Relay
2025-07-10 8:57 ` Jerome Brunet
2025-07-10 9:56 ` Krzysztof Kozlowski
2025-07-14 6:10 ` Krzysztof Kozlowski [this message]
2025-07-10 3:35 ` [PATCH v5 2/6] dt-bindings: clock: axg-audio: Add mclk and sclk pad clock ids jiebing chen via B4 Relay
2025-07-10 3:35 ` [PATCH v5 3/6] dt-bindings: Asoc: axg-audio: Add s4 audio tocodec jiebing chen via B4 Relay
2025-07-10 9:57 ` Krzysztof Kozlowski
2025-07-14 6:10 ` Krzysztof Kozlowski
2025-07-14 7:22 ` Krzysztof Kozlowski
2025-07-14 7:31 ` Jiebing Chen
2025-07-10 3:35 ` [PATCH v5 4/6] ASoC: meson: g12a-toacodec: Add s4 tocodec driver jiebing chen via B4 Relay
2025-07-10 9:29 ` Jerome Brunet
2025-07-10 3:35 ` [PATCH v5 5/6] clk: meson: axg-audio: Add the mclk pad div for s4 chip jiebing chen via B4 Relay
2025-07-10 9:11 ` Jerome Brunet
2025-07-10 3:35 ` [PATCH v5 6/6] arm64: dts: amlogic: Add Amlogic S4 Audio jiebing chen via B4 Relay
2025-07-10 9:20 ` Jerome Brunet
2025-07-10 9:48 ` Jiebing Chen
2025-07-10 9:32 ` [PATCH v5 0/6] Add support for S4 audio Jerome Brunet
2025-07-10 19:05 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88ff3aa4-dfb0-4b65-a061-52544caf46f6@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.xu@amlogic.com \
--cc=jiebing.chen@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shuai.li@amlogic.com \
--cc=tiwai@suse.com \
--cc=zhe.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).