From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19A4BC433FE for ; Fri, 14 Oct 2022 19:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BVnq19yJyHTfR5Ssp5Pq8R65HTTCPEOtEulV88b+zug=; b=Tk9qClHvBtx0gd 3hZSOkDJMj3wv/NTlGwNJbyuztMO2pf9XMkd4XwKGZjq930QNQR7FX7Tc/gXuVGH9BhY2RoZV2zZO rQXu2nrOq6RDitVp8+TJpVaMF8wcjW53w4Q+7qvfqAHKtGc+ureR7bnvTG1jtx4saahie+mx0pwy+ PWWzqIsyvC1tnJYSVwU5303MIBSjbi3V4hA7Mooxkqh7mZ/iBVL9xWKK8lcxa5OeiAf91qJDLB6Ed SB5Zcp6/6g2mSJOpFs7srjdNemQ4pVMtk4KZ4TqGABQJZb1qLQfX8qWinzLe4hqz7gy85B8UzPY66 eQU+VcS015z/QJORTcHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojQb2-00Fjp2-IW; Fri, 14 Oct 2022 19:43:52 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojQaz-00Fjo4-He; Fri, 14 Oct 2022 19:43:51 +0000 Received: by mail-qk1-x735.google.com with SMTP id f8so3172368qkg.3; Fri, 14 Oct 2022 12:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ntqa7zGUvdkoaNKtpLHO8d7zkjCXynPr2O1UReD4IS4=; b=hWM2nuldlpT1GwMRadltQROOJ1UcxNz93fNBUQqz1H1K167JFumRhZEeiTQWkjVXfg Q6dfF69dv0Ub4IbGPuT/aEC6safmfQ7+wewR1eHedHFcdBGVWJJZdsIIXYTH+n9f9MaM tkdNcAIkEUIs9mp+WRtSgbKZWXBPOEdFQpSGiYb4gYMsnZ+KkskKQYTX/qAEyVcnSefc LnxeNe+0odSobij0QTyJJaLHMxCHp8glAyf8tEmQ3761srW6hBm4AICPWoguNKQCp6qq bhv/68xmcuRtu2GDxIOARd+hOTv94EvWT9mMlzfKEYujG6HrqAgFc6riJN+4tptJZH+B xj9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ntqa7zGUvdkoaNKtpLHO8d7zkjCXynPr2O1UReD4IS4=; b=XTxbVr1I4dqipeuYhBHVHgeqJnaIwOWZ6J/3t+V5G1M9DGZikZ0oPmQHVc/DGV9O1B w1CJ5eFDK9T7TPrMrxcI+Mp7gFBfck5gi0AG3NRwgB27n242me+4mg5hPkzkRV8DXfaP h4zeIGLhWa4+4D/khzQtTE9luG5T5bo4AX9mK1vDLhf+/wzHoPU9cNwuecpclnkkxX4V mzBcUFO0zgAWuIN42EC3qeTHcMBE51PD/1MFDQYlJ8gyCtjWEZAYUwlzQnVTfOyPockQ CONt564fCkG6PREATHZOycoOFjAGJ5B/T22bCLmFhvzJwKAzK81JoO6eYSD0ds5omNFW zDlg== X-Gm-Message-State: ACrzQf0DN/kMcj2dHKoBGqyg+352zRrrziCB3a6021/clkAygOjweVMh Z6/qEbStXJ9mSN+zqW2/nDmGZWcvOFg= X-Google-Smtp-Source: AMsMyM7RS0AmiKiMA7R11UCVLvA+bZi0iN1SPGMBs4/6FU7fKMs+/k0fGUYgFvupdcxmXvvGXN6hAw== X-Received: by 2002:ae9:f707:0:b0:6e7:2317:8318 with SMTP id s7-20020ae9f707000000b006e723178318mr4897896qkg.571.1665776625680; Fri, 14 Oct 2022 12:43:45 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id d9-20020ac85349000000b00343057845f7sm2540309qto.20.2022.10.14.12.43.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Oct 2022 12:43:45 -0700 (PDT) Message-ID: <890f6ab1-f6aa-76c8-01e8-f7233143d7ec@gmail.com> Date: Fri, 14 Oct 2022 12:43:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node() Content-Language: en-US To: Maxime Ripard , Michael Turquette , Emma Anholt , Stephen Boyd , Ray Jui , Scott Branden , Broadcom internal kernel review list , Daniel Vetter , David Airlie , Maxime Ripard Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Dom Cobley , dri-devel@lists.freedesktop.org References: <20220815-rpi-fix-4k-60-v3-0-fc56729d11fe@cerno.tech> <20220815-rpi-fix-4k-60-v3-1-fc56729d11fe@cerno.tech> From: Florian Fainelli In-Reply-To: <20220815-rpi-fix-4k-60-v3-1-fc56729d11fe@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221014_124349_633452_45BF4639 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/13/22 02:13, Maxime Ripard wrote: > A significant number of RaspberryPi drivers using the firmware don't > have a phandle to it, so end up scanning the device tree to find a node > with the firmware compatible. > > That code is duplicated everywhere, so let's introduce a helper instead. > > Signed-off-by: Maxime Ripard > --- > drivers/firmware/raspberrypi.c | 7 +++++++ > include/soc/bcm2835/raspberrypi-firmware.h | 7 +++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c > index 4b8978b254f9..b916e1e171f8 100644 > --- a/drivers/firmware/raspberrypi.c > +++ b/drivers/firmware/raspberrypi.c > @@ -311,6 +311,13 @@ static int rpi_firmware_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id rpi_firmware_of_match[]; This shadows the same variable that is used later for matching the firmware driver and probe it as a platform_driver, what am I missing here? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel