From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AA5BC7618E for ; Fri, 21 Apr 2023 11:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N/8YPfEveIp3/bFMH48n6pJrLZjrdNA6KqQIYdFDSdk=; b=WHl3a+nN64eZZn OmDK1F5JK1Z2jpeHC1yztnuG9V3u5fB1W+DCb1xSD2ztG1fnEuNa2LCgI8nOgpBgJuJnUnvE57yaO QiDJDuqdtgxynOLsYU5/UkA7yn+T/2L+Y9hfjtTCakZnu03B/EEs0BxcgsMFSyTukZBcRPzM/OPOz T/CnpFFcf7rhcsV/azqVHDQbC2rk3K6bE6PTlXgjDU8cEWrus1yTnMdI+RewMMjAWPgNpGeIyNkAj j4A8A6r4Qn3Q69WvVV92Vi8FAfkqiP5KnHC237+aEkXj1o1U8RSGIQyueGU558OUhUG006Ivtv6JY eQ4x8h8zu642DpDi9Adg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pppPu-00AoGM-0G; Fri, 21 Apr 2023 11:59:06 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pppPq-00AoFU-0y; Fri, 21 Apr 2023 11:59:03 +0000 Received: from [194.95.143.137] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pppPn-0002Lk-Js; Fri, 21 Apr 2023 13:58:59 +0200 From: Heiko Stuebner To: Rob Herring , Krzysztof Kozlowski , Peter Geis , Nicolas Frattaroli Cc: Nicolas Frattaroli , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: fix nEXTRST on SOQuartz Date: Fri, 21 Apr 2023 13:58:58 +0200 Message-ID: <8914603.GXAFRqVoOG@phil> In-Reply-To: <20230419171731.28641-1-frattaroli.nicolas@gmail.com> References: <20230419171731.28641-1-frattaroli.nicolas@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_045902_336658_327C3BF6 X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 19. April 2023, 19:17:31 CEST schrieb Nicolas Frattaroli: > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm= 64/boot/dts/rockchip/rk3566-soquartz.dtsi > index ce7165d7f1a1..f589a4fdaccb 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > @@ -65,6 +65,17 @@ led_work: led-work { > }; > }; > = > + nextrst_pin: nextrst-pin-regulator { > + compatible =3D "regulator-fixed"; > + enable-active-high; > + gpio =3D <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&nextrst_h>; > + regulator-always-on; > + regulator-boot-on; > + regulator-name =3D "nextrst"; > + }; > + I agree with the sentiment and of course the rationale of the change, but not necessarily with the implementation ;-) . Why is this done as a regulator? If you want the nextrst line to be high, you could just use a gpio-hog for the line instead of doing a (fake?-)regulator. For example the px30-ringneck.dtsi does something similar: &gpio2 { = /* = * The Qseven BIOS_DISABLE signal on the PX30-=B5Q7 keeps the on-mo= dule * eMMC powered-down initially (in fact it keeps the reset signal * asserted). BIOS_DISABLE_OVERRIDE pin allows to re-enable eMMC af= ter * the SPL has been booted from SD Card. */ = bios-disable-override-hog { gpios =3D ; output-high; line-name =3D "bios_disable_override"; gpio-hog; }; = ... }; Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel