From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6A3CC38147 for ; Wed, 18 Jan 2023 17:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Osg8xlpvqAW4q8jjXAghG/SlJM/Gl9BgAe5pwjLXCFM=; b=kb0OCkqsbNjxTf zD0B/ghOr/gXfvL0su9LaYpdB0EEQTx/BBGlLQ1AyeQ2PMldU/3o3w26GXTFeDnim+W0DKXIyTEwX 4iRTfWQiqWx3L6GIVBTBOfNVlMLsYaHSGthfe4uJYbvnMICX4oGk/bCB2vGyndU4l3eVfiTCZBmsY Cz8nSE23zo6gk660hLGyer3iA08zF2hnq4OPF3cfz44cSi5L5NVfsYdbkYu3CuUp4nR4jYwHbpCaK 4PdZVtzbhimmCUWRzP+vExQnSfDjZEJGrEnjMZCGxMYJlm4RMOABUlhSjJqTKlVWbh4ctXY1eY/eV IKvQO+zVSBQ7iotYyLTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pICFk-0021mw-Gq; Wed, 18 Jan 2023 17:29:36 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pICFg-0021m0-OL; Wed, 18 Jan 2023 17:29:34 +0000 Received: from [192.168.1.139] ([37.4.248.41]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MzTCy-1oW1VW1Hhg-00vQLu; Wed, 18 Jan 2023 18:29:26 +0100 Message-ID: <89377474-bcd4-452a-973f-dd5092dea4d6@i2se.com> Date: Wed, 18 Jan 2023 18:29:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 1/4] staging: vc04_services: vchiq_core: Drop custom logging To: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart References: <20230118115810.21979-1-umang.jain@ideasonboard.com> <20230118115810.21979-2-umang.jain@ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20230118115810.21979-2-umang.jain@ideasonboard.com> X-Provags-ID: V03:K1:c9i/D17w64yXKdNX4GYL2ssWp34kom0i30U5afG6wwqxgpXdqhi 1rIOQKRsuPAZltULVkvkcj+vsAfhnmYBXEXOZH1R8xJnLDv1X1Pk1U33zSBx8cqfgu7dth1 Pijywyamf+gBZJDuCT0uYu10sfEr20Us0TzrMZwU4xSvw6PDOzjxg1q0eqisTejQAL2yYA5 vijcLbazpZcrg6NzG8jMg== UI-OutboundReport: notjunk:1;M01:P0:2/yHPKPMUzY=;AX4aNqWm+UcOr38RvvoFo4+LBaH 5i03g5b1GY2b81uiDhYPcXzdSilZwjHjPwz/me18F3l0rzllt9vPIM5p/RoZlzcGGUQ6lRlHJ olfjLnxM0quAeM0w/cVZpQiDSSjQAm91cNhCWXMMIWmtGgwgzAp0VE6tB41Q4wi7nZnY6r3nj cPuGqeb3Voq6FI1kfocQ7D6NajcY5qYIeapk84MItCEKJ9npkPc8WcdTEEt7c1s7z5ULWxBS7 i7M6ViDenl3bzSyvOUz8yASQ0Wux4H384miofvAmzuvNNcFD+74haLUNet4D4ee4JllHrEcb+ SJ9nZuC8e9jss7N1L5+y7gJTY1nIdgtPgm7cPnfUY3mpebBWUMjtfsMJ6Joio/U+8txyPEFub uAi1OmWb9XoCb+ywifWTfxbtEvTliSK5d4FAima5iy2INq+i/3dPju0KCiUvg9Qc2LpBIIuXe Cjejg1XyZw/IuF39Y4GZwB2GRzlAcvEN1gwm/eUgtBZi9DNavwV74KA3z14OMLJwfClWNmLpZ HAQj8VlnonAiyuJE94UEkxCzSYpp/OGVfN8uQ6WE4hQ9jgXbom8XVOk5cwlykbX3qrI6UUWB5 dLoitT5DV1EdGkFS5dCymtzgi75DYHJHBF1mBeAANqDwCovagkyGIe91JqUvNKiDsQX3+nCXC 45WB38MByLX6amyJ8+gMsNc/2MuR+Mp7UefeSgoLSg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_092933_105851_7E9E72FF X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, Am 18.01.23 um 12:58 schrieb Umang Jain: > Drop custom logging from the vchiq_core.c and use standard kernel > logging infrastructure (dev_dbg() and friends for struct Device > stuff) and pr_info (and similar) for vchiq_services/instances things. i'm sorry but your "staging: vc04_services: vchiq: Register devices with a custom bus_type" is still in my backlog. I was busy with some regressions on bcm2835/bcm2711. > > Signed-off-by: Umang Jain > --- > .../interface/vchiq_arm/vchiq_core.c | 450 ++++++++---------- > 1 file changed, 204 insertions(+), 246 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 4e705a447a62..7b3c57326d28 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -227,10 +227,11 @@ static const char *msg_type_str(unsigned int msg_type) > static inline void > set_service_state(struct vchiq_service *service, int newstate) > { > - vchiq_log_info(vchiq_core_log_level, "%d: srv:%d %s->%s", > - service->state->id, service->localport, > - srvstate_names[service->srvstate], > - srvstate_names[newstate]); > + struct vchiq_state *state = service->state; > + > + dev_info(state->dev, "%d: srv:%d %s->%s", state->id, > + service->localport, srvstate_names[service->srvstate], > + srvstate_names[newstate]); > service->srvstate = newstate; > } > > @@ -255,8 +256,7 @@ find_service_by_handle(struct vchiq_instance *instance, unsigned int handle) > return service; > } > rcu_read_unlock(); > - vchiq_log_info(vchiq_core_log_level, > - "Invalid service handle 0x%x", handle); > + pr_info("vchiq: Invalid service handle 0x%x", handle); Some log levels like this here doesn't make sense. I would expect here a warning or an error. Could you please have look at it in a separate patch? Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel