From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 489D7EE0214 for ; Wed, 11 Sep 2024 07:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5mGLOCnwkaWK/oS511bNCFB/e44jaVJMXFEk0X2Af6A=; b=oUhvcl7o8x09lsLRoNiFr28e2h UNg6VVrybf2wsWurbUfdjQ3T8Opm1szgz1kCn524q4VHxxM2EbXhGsibWY8KPffe9BepWvyhItTEi xI6TgsLOf+A3uv/1jTXPxpB3cxqSLRRF4IWkqTCqOg1WN9cAOJam0X1lUxQ5EZSWsr23IpXLDGBni IpFVhbfzBOjd9S3Ap21IKQ3uRPpSlrPjga3n+JySfmJ4ZcDOqAoG4w0xEFOyrQNd8cSqcbIYPM1Jz FpjFU7/iGdksUA99UgZ618opK3DBKSlKtNfRf0poZ8TPdCTASDOICcUgV94CPgF6slpdLwYkCmUe+ OJVDVinA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soIB0-00000008X9X-3MQa; Wed, 11 Sep 2024 07:54:10 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soI8z-00000008WXl-2uyD for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 07:52:06 +0000 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-53659867cbdso8439802e87.3 for ; Wed, 11 Sep 2024 00:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726041123; x=1726645923; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5mGLOCnwkaWK/oS511bNCFB/e44jaVJMXFEk0X2Af6A=; b=h8rJg2GoDwrfbdCMm2eMFTJF56i3iKc/otajoQ7HaS1nOqrtg4asv8BqlQuQq01zNz KiA8hQgk2exTSSA3qKmU/FThiHjvaMnO82WQZwTv+np7HYJR8x5GLqZc5k3dbI9Aqp+c cHsF08INGgR7XUqeHdWLPOkTKkJZrFkU3qUiPJ5d1NY/cmpzf9ul15rCags1GYKLJFM3 4QzvNq0EjWJYAVtZgXQ7seZ4+2VDaeLC/4cyXMbtDWVdMjnIZKuWbxjcefKGz0Aihju2 cgnUL6o3yN8tPj7fXjkgVSq7BRrhTFvZNY2frn0cTGs0gQZfmR1XAz/uv5xuup8FDV8O 1w7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726041123; x=1726645923; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5mGLOCnwkaWK/oS511bNCFB/e44jaVJMXFEk0X2Af6A=; b=A4lKpdN9OEMUbnltrOApaDor1LjoCWbXsWUNsgtxU6UrxrMC5jhNG8ghkgF6O6aAD7 +rgdn7xK+WDJSO1ucI9r81I6i+LrzWWAMBav+HfO1+zKjelkBDiqUo5LLWLb5Z3hCkrO NRTIxuLHdwLXEAOoGqrInnfDrX1YHFHVmhCNkj7r+wLnnN5dm8Uyv6XwlYGeTC3E9vhT B1aWH0Wtmkk2pU2UB46fIRCAvdgSPDmziSZHTsl289ffncQ8BuZN/CUsXBZ2OhR+m3gN 7sC+7Ik7HnyXn783wfxFjdR5E8o8oHVOi57KQdnt5PdO3Lj7GAJWyvIbnVi9pcR/Y6Rt A2rQ== X-Forwarded-Encrypted: i=1; AJvYcCUL7HGa+kvIAAqSac3FPrM7b0sNU9NBhpr2JeYAHzS5blj5daKOAvnmtFDww9tiJzEVHjGdCqFI+TtmMcJ+POnq@lists.infradead.org X-Gm-Message-State: AOJu0Yw3Sp0RcNFpuPqnJQLlcD0oGP0Pje3OF7g/5By1f7b8/9wHPP0x bK1GHxLZV4GKtbYJ+pZwNAj91Wi6Qj1MvPaeza7J2QYm9gA5f1iBFT7nDg== X-Google-Smtp-Source: AGHT+IHlK1x/288tPyCeksFi0y4Qjn1N90VOfZFThJn6fo3CV2Yp83nkq4I+hoJMCqadnX13pQosoA== X-Received: by 2002:a05:6512:114f:b0:536:55cc:963e with SMTP id 2adb3069b0e04-536587f873bmr17003036e87.44.1726041122274; Wed, 11 Sep 2024 00:52:02 -0700 (PDT) Received: from giga-mm-1.home ([2a02:1210:861b:6f00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25ceaf4fsm579313866b.152.2024.09.11.00.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 00:52:01 -0700 (PDT) Message-ID: <895c9d2f81023b8fa88209b244209202ce202af5.camel@gmail.com> Subject: Re: [PATCH] ep93xx: clock: Fix off by one in ep93xx_div_recalc_rate() From: Alexander Sverdlin To: Dan Carpenter , Nikita Shubin Cc: Hartley Sweeten , Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Wed, 11 Sep 2024 09:52:28 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_005205_766342_9CF1B0BF X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan! On Wed, 2024-09-11 at 10:39 +0300, Dan Carpenter wrote: > The psc->div[] array has psc->num_div elements.=C2=A0 These values come f= rom > when we call clk_hw_register_div().=C2=A0 It's adc_divisors and > ARRAY_SIZE(adc_divisors)) and so on.=C2=A0 So this condition needs to be = >=3D > instead of > to prevent an out of bounds read. >=20 > Fixes: 9645ccc7bd7a ("ep93xx: clock: convert in-place to COMMON_CLK") > Signed-off-by: Dan Carpenter Acked-by: Alexander Sverdlin > --- > =C2=A0arch/arm/mach-ep93xx/clock.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm/mach-ep93xx/clock.c b/arch/arm/mach-ep93xx/clock.c > index 85a496ddc619..e9f72a529b50 100644 > --- a/arch/arm/mach-ep93xx/clock.c > +++ b/arch/arm/mach-ep93xx/clock.c > @@ -359,7 +359,7 @@ static unsigned long ep93xx_div_recalc_rate(struct cl= k_hw *hw, > =C2=A0 u32 val =3D __raw_readl(psc->reg); > =C2=A0 u8 index =3D (val & psc->mask) >> psc->shift; > =C2=A0 > - if (index > psc->num_div) > + if (index >=3D psc->num_div) > =C2=A0 return 0; > =C2=A0 > =C2=A0 return DIV_ROUND_UP_ULL(parent_rate, psc->div[index]); --=20 Alexander Sverdlin.