From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20ECC4363D for ; Wed, 7 Oct 2020 21:38:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63FA22083B for ; Wed, 7 Oct 2020 21:38:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RBW63TTp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="A3zmsxRk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63FA22083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZkAW1ghZ4DcqxqzQsyYH7+/oRRiPPe1CfalbTmnPAL4=; b=RBW63TTpGShbOzOfxiBo22Cti 1l6Bkt49Sfv4OWPqRoSS2N/dGH0oJaHIv1hj0I43U+o7OutJ2oDQDRwkM8Vj/owKfvIZcHIaI8xhw +57U8dKt4aQp2H5+f752UktAFcn3WOUCVjsU2KKK1XQs1+XhLvVlrx7ro449B2t7fJbLSEPDFqRfU DSfdM/7VC/hn8QLXVfxmwlM16IIza7f8IrE5b/Dmbnoqnf6e1CLQs7tTjE951pkwZI9cwjP9GR+/b 9h7gdJMy+PHs1mlIXQQ58L8K76A2e3N6HxNUDlIrYvXaVIJtYNTScHxVo+tOajPnZsYJGf5Tzwv1e xVdemDOwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH7S-0000Ho-O1; Wed, 07 Oct 2020 21:37:06 +0000 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH7P-0000Gu-U4 for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 21:37:04 +0000 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 07 Oct 2020 14:36:49 -0700 Received: from [10.2.85.86] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 7 Oct 2020 21:36:52 +0000 Subject: Re: [PATCH 01/13] drm/exynos: Stop using frame_vector helpers To: Daniel Vetter References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-2-daniel.vetter@ffwll.ch> <80718789-b3de-c30a-03c5-7c8cbf41f7d9@nvidia.com> From: John Hubbard Message-ID: <895eb064-1c8f-ecfc-0a98-1fbe40cb3161@nvidia.com> Date: Wed, 7 Oct 2020 14:36:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602106609; bh=OI3+pLVYL5cWSE4B2a2jiHWrJeRBVcUjCT4H6VDdVUk=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=A3zmsxRkTiEuP5NMToHsIjBexJZ1BRIWpMrbXsaDVyF7pGmKjuyPBJQTjoYnCT+Id Rh7uCABfImT6HrUYHb0dneU7xMwQcxjKSVOEB6uLjaVXfpYC3GRycDey9vhNW5mmoL jEbZuoQHH31CQTquNUREPNteX38ixLxxzHu2SsT2FwNmpb8XAJQj2e6AubzOwwCf8P V6JNWODSmsgKGWHO++1cASV1aBplJBXlrENJ9aSSd2jA/V2blcSUK8OOBGXEaMYN/S S6PO0PnBjGCbslJ42wDbWrRxEjHDBuLX0dG111P3JgKEC7Adhql3cu0O80p7PRSGSg 0YNay76WexGkg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_173704_038807_D907A6C3 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-s390@vger.kernel.org, linux-samsung-soc , Jan Kara , Joonyoung Shim , kvm@vger.kernel.org, Jason Gunthorpe , Seung-Woo Kim , LKML , DRI Development , Inki Dae , Linux MM , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Daniel Vetter , Andrew Morton , Dan Williams , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/7/20 2:32 PM, Daniel Vetter wrote: > On Wed, Oct 7, 2020 at 10:33 PM John Hubbard wrote: >> >> On 10/7/20 9:44 AM, Daniel Vetter wrote: ... >>> @@ -398,15 +399,11 @@ static void g2d_userptr_put_dma_addr(struct g2d_data *g2d, >>> dma_unmap_sgtable(to_dma_dev(g2d->drm_dev), g2d_userptr->sgt, >>> DMA_BIDIRECTIONAL, 0); >>> >>> - pages = frame_vector_pages(g2d_userptr->vec); >>> - if (!IS_ERR(pages)) { >>> - int i; >>> + for (i = 0; i < g2d_userptr->npages; i++) >>> + set_page_dirty_lock(g2d_userptr->pages[i]); >>> >>> - for (i = 0; i < frame_vector_count(g2d_userptr->vec); i++) >>> - set_page_dirty_lock(pages[i]); >>> - } >>> - put_vaddr_frames(g2d_userptr->vec); >>> - frame_vector_destroy(g2d_userptr->vec); >>> + unpin_user_pages(g2d_userptr->pages, g2d_userptr->npages); >>> + kvfree(g2d_userptr->pages); >> >> You can avoid writing your own loop, and just simplify the whole thing down to >> two lines: >> >> unpin_user_pages_dirty_lock(g2d_userptr->pages, g2d_userptr->npages, >> true); >> kvfree(g2d_userptr->pages); > > Oh nice, this is neat. I'll also roll it out in the habanalabs patch, > that has the same thing. Well almost, it only uses set_page_dirty, not > the _lock variant. But I have no idea whether that matters or not? It matters. And invariably, call sites that use set_page_dirty() instead of set_page_dirty_lock() were already wrong. Which is why I never had to provide anything like "unpin_user_pages_dirty (not locked)". Although in habanalabs case, I just reviewed patch 3 and I think they *were* correctly using set_page_dirty_lock()... thanks, -- John Hubbard NVIDIA _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel