public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: sunxi: Split the various SoCs support in Kconfig
Date: Mon, 28 Apr 2014 20:07:38 +0200	[thread overview]
Message-ID: <8970285.5xeG1588Q7@wuerfel> (raw)
In-Reply-To: <1398529014-1152-2-git-send-email-maxime.ripard@free-electrons.com>

On Saturday 26 April 2014 18:16:53 Maxime Ripard wrote:
> This will allow to better isolate various options, and reduce the overall
> kernel size if we're interested in only one of the SoCs.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Looks good, just one small request:


> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index b57d7d53b9d3..23575010ff49 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -1,14 +1,37 @@
>  config ARCH_SUNXI
> -       bool "Allwinner A1X SOCs" if ARCH_MULTI_V7
> -       select ARCH_HAS_RESET_CONTROLLER
> +       bool "Allwinner SoCs" if ARCH_MULTI_V7
>         select ARCH_REQUIRE_GPIOLIB
> -       select ARM_GIC
> -       select ARM_PSCI
>         select CLKSRC_MMIO
>         select GENERIC_IRQ_CHIP
> -       select HAVE_ARM_ARCH_TIMER
>         select PINCTRL
>         select PINCTRL_SUNXI
> -       select RESET_CONTROLLER
>         select SUN4I_TIMER

Please make this 'menuconfig' instead of 'config', so it shows up as
only one line in the main menu. I would like to do this for all platforms
that have sub-options eventually.

	Arnd

  parent reply	other threads:[~2014-04-28 18:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26 16:16 [PATCH 0/2] ARM: sunxi: Split Kconfig entries Maxime Ripard
2014-04-26 16:16 ` [PATCH 1/2] ARM: sunxi: Split the various SoCs support in Kconfig Maxime Ripard
2014-04-28 17:02   ` [linux-sunxi] " Olof Johansson
2014-04-28 22:43     ` Maxime Ripard
2014-04-28 18:07   ` Arnd Bergmann [this message]
2014-04-28 22:45     ` Maxime Ripard
2014-04-26 16:16 ` [PATCH 2/2] ARM: Enable the new Allwinner SoCs support options Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8970285.5xeG1588Q7@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox