From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CE6DC88E50 for ; Fri, 11 Sep 2026 14:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XEMmnTm32/NTqr2ju1OSUOpzh4M2ZWPfBI5yIkyjF/M=; b=X62SCkolqJwDE/bRETARA54Y3U jAxWwqC18GU5R9HmhZj+By1YZ9G2hw23LPK+qsC3Qnr5AEybKgpzYc8eAOhCERWI4PsAjFgi/sriR x4nXUasZSWGWo+B1zZsnCKwckQnzuF8TC9RcUF7fjKxltJXwKj78mOzlD3FEp7QttXKHRhny1cfRR CXgKCCk6HHhuPvYeoiBdtVqB9do7JHGuSU5LstoaWjEzEjkOeqxsWzWDHedMbH7moR+aGrSkcPVaT F1jB0Lb4McZRtfZkVOvlLjz4pR07TkiZpg/IFvgFUdIyKA3XKT1+cTQAsujL6kQuKgo97moYKOcjP QMK85lWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x52Cq-0000000GuI7-2fY3; Fri, 11 Sep 2026 14:26:20 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x52Cm-0000000GuHD-23tc for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2026 14:26:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E817316A3; Fri, 11 Sep 2026 07:26:11 -0700 (PDT) Received: from [10.2.212.8] (e134344.arm.com [10.2.212.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6E6C3F7B4; Fri, 11 Sep 2026 07:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1789136775; bh=+dl+/CW2c5vdQ2DAyzIA0HbT6aXfdDkk/ZXevqf3xhY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VJS9jdVjdxrfhddtboM8//bjGARsasQc92yC8Z54x1d+/OrvhGyfbkqZaUzUr9DjW S2ERUo7sK1bp3dMpOWEtST2Im/BFbpoRDGPWoe7Qd2gSH41anUBYV5Hja3TSoKj1Xk DpMjfmQU9PjtvdHf/31WGNkVuM+weOxegDS2VvYs= Message-ID: <89a13b60-a1fe-442f-ab0d-b0d37a118ad1@arm.com> Date: Fri, 11 Sep 2026 15:26:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 08/14] arm_mpam: propagate MSC access errors for interrupt control To: Andre Przywara , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , Gavin Shan , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260911112835.714162-1-andre.przywara@arm.com> <20260911112835.714162-9-andre.przywara@arm.com> Content-Language: en-US From: Ben Horgan In-Reply-To: <20260911112835.714162-9-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260911_072616_623628_10201B9A X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre, On 11/09/2026 12:28, Andre Przywara wrote: > Allow the functions dealing with interrupt registration and enablement > to check for and return errors, and propagate MSC read and write errors > from the lower level up. > This does not cover the IRQ handler yet, as this needs some more > attention. > > Signed-off-by: Andre Przywara > Reviewed-by: Srivathsa L Rao Commenting here as this is the last error propagation patch. I think we need a clean boundary for the error propagation. As you said a while back I think we can propagate error for all non-static functions from mpam_devices.c and the callers can discard the errors if appropriate. For instance, mpam_reset_class_locked() should propagate any error. Thanks, Ben > --- > drivers/resctrl/mpam_devices.c | 31 +++++++++++++++---------------- > 1 file changed, 15 insertions(+), 16 deletions(-) > > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index 558efab75f911..eb26c25b9f970 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -1105,7 +1105,9 @@ static int mpam_msc_hw_probe(struct mpam_msc *msc) > } > > /* Clear any stale errors */ > - mpam_msc_clear_esr(msc); > + ret = mpam_msc_clear_esr(msc); > + if (ret) > + return ret; > > spin_lock(&partid_max_lock); > mpam_partid_max = min(mpam_partid_max, msc->partid_max); > @@ -2668,9 +2670,7 @@ static int mpam_enable_msc_ecr(void *_msc) > { > struct mpam_msc *msc = _msc; > > - __mpam_write_reg(msc, MPAMF_ECR, MPAMF_ECR_INTEN); > - > - return 0; > + return __mpam_write_reg(msc, MPAMF_ECR, MPAMF_ECR_INTEN); > } > > /* This can run in mpam_disable(), and the interrupt handler on the same CPU */ > @@ -2678,9 +2678,7 @@ static int mpam_disable_msc_ecr(void *_msc) > { > struct mpam_msc *msc = _msc; > > - __mpam_write_reg(msc, MPAMF_ECR, 0); > - > - return 0; > + return __mpam_write_reg(msc, MPAMF_ECR, 0); > } > > static irqreturn_t __mpam_irq_handler(int irq, struct mpam_msc *msc) > @@ -2777,11 +2775,13 @@ static int mpam_register_irqs(void) > return err; > } > > - mutex_lock(&msc->error_irq_lock); > - msc->error_irq_req = true; > - mpam_touch_msc(msc, mpam_enable_msc_ecr, msc); > - msc->error_irq_hw_enabled = true; > - mutex_unlock(&msc->error_irq_lock); > + scoped_guard(mutex, &msc->error_irq_lock) { > + msc->error_irq_req = true; > + err = mpam_touch_msc(msc, mpam_enable_msc_ecr, msc); > + if (err) > + return err; > + msc->error_irq_hw_enabled = true; > + } > } > > return 0; > @@ -2800,10 +2800,10 @@ static void mpam_unregister_irqs(void) > if (irq <= 0) > continue; > > - mutex_lock(&msc->error_irq_lock); > + guard(mutex)(&msc->error_irq_lock); > if (msc->error_irq_hw_enabled) { > - mpam_touch_msc(msc, mpam_disable_msc_ecr, msc); > - msc->error_irq_hw_enabled = false; > + if (!mpam_touch_msc(msc, mpam_disable_msc_ecr, msc)) > + msc->error_irq_hw_enabled = false; > } > > if (msc->error_irq_req) { > @@ -2815,7 +2815,6 @@ static void mpam_unregister_irqs(void) > } > msc->error_irq_req = false; > } > - mutex_unlock(&msc->error_irq_lock); > } > } >