From mboxrd@z Thu Jan 1 00:00:00 1970 From: michal.simek@xilinx.com (Michal Simek) Date: Mon, 10 Sep 2018 14:34:35 +0200 Subject: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control In-Reply-To: References: <1533318808-10781-1-git-send-email-jollys@xilinx.com> <1533318808-10781-4-git-send-email-jollys@xilinx.com> Message-ID: <89a81241-e2c3-9fdf-7436-3d50025cec4d@xilinx.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 9.9.2018 03:18, Olof Johansson wrote: > Hi, > > On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah wrote: >> From: Rajan Vaja >> >> Add ZynqMP firmware IOCTL API to control and configure >> devices like PLLs, SD, Gem, etc. >> >> Signed-off-by: Rajan Vaja >> Signed-off-by: Jolly Shah > > This patch worries me somewhat. It's a transparent pass-through ioctl > driver. Is there a spec available for what the implemented IOCTLs are? https://www.xilinx.com/support/documentation/user_guides/ug1200-eemi-api.pdf > > Should some of them be proper drivers instead of an opaque > pass-through like this? Could some of them have stability impact on > the platform such that there are security concerns and the list of > arguments should somehow be sanitized? You can look at for example reset driver which is using this eemi interface. https://lkml.org/lkml/2018/9/5/144 > What's the intended usecase anyway? Just a debug tool during > development, or something that you expect heavy use of by some > userspace middleware? I am not an author of this interface but there is no intention to enable this interface for userspace as far as I see. All functions should be used by kernel drivers only. Jolly: Please answer all others concern in connection to this patchset. Thanks, Michal