From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
herbert@gondor.apana.org.au, davem@davemloft.net,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
horia.geanta@nxp.com, pankaj.gupta@nxp.com, gaurav.jain@nxp.com,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, stefan@agner.ch,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 3/9] dt-bindings: crypto: fsl-sec4: support sec5.4/0 and i.MX6UL
Date: Fri, 3 Mar 2023 10:55:23 +0100 [thread overview]
Message-ID: <89cb8fb1-4e0f-4b5e-26ab-702c0fda8760@linaro.org> (raw)
In-Reply-To: <20230301015702.3388458-4-peng.fan@oss.nxp.com>
On 01/03/2023 02:56, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX6UL, SEC 5.0 and SEC 5.4 support.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/crypto/fsl-sec4.yaml | 58 ++++++++++++++++---
> 1 file changed, 50 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml b/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml
> index 678c8389ef49..1b801ae5ab51 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml
> @@ -45,8 +45,18 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - fsl,sec-v4.0
> + oneOf:
> + - enum:
> + - fsl,sec-v4.0
> + - items:
> + - enum:
> + - fsl,imx6ul-caam
> + - fsl,sec-v5.0
> + - const: fsl,sec-v4.0
> + - items:
> + - const: fsl,sec-v5.4
> + - const: fsl,sec-v5.0
What's the point of having all these versions? Better to use
SoC-compatibles.
> + - const: fsl,sec-v4.0
>
> "#address-cells":
> const: 1
> @@ -77,6 +87,8 @@ properties:
>
> clock-names:
> oneOf:
> + - items:
> + - const: ipg
> - items:
> - const: mem
> - const: aclk
> @@ -85,11 +97,17 @@ properties:
> - items:
> - const: aclk
> - const: ipg
> + - items:
> + - const: ipg
> + - const: aclk
> - items:
> - const: ipg
> - const: aclk
> - const: mem
>
> + dma-coherent:
> + type: boolean
> +
> fsl,sec-era:
> description:
> Optional. A standard property. Define the 'ERA' of the SEC device.
> @@ -108,8 +126,16 @@ patternProperties:
>
> properties:
> compatible:
> - enum:
> - - fsl,sec-v4.0-job-ring
> + oneOf:
> + - enum:
> + - fsl,sec-v4.0-job-ring
> + - items:
> + - const: fsl,sec-v5.0-job-ring
> + - const: fsl,sec-v4.0-job-ring
> + - items:
> + - const: fsl,sec-v5.4-job-ring
> + - const: fsl,sec-v5.0-job-ring
> + - const: fsl,sec-v4.0-job-ring
>
> reg:
> maxItems: 1
> @@ -148,8 +174,16 @@ patternProperties:
>
> properties:
> compatible:
> - enum:
> - - fsl,sec-v4.0-rtic
> + oneOf:
> + - enum:
> + - fsl,sec-v4.0-rtic
> + - items:
> + - const: fsl,sec-v5.0-rtic
> + - const: fsl,sec-v4.0-rtic
> + - items:
> + - const: fsl,sec-v5.4-rtic
> + - const: fsl,sec-v5.0-rtic
> + - const: fsl,sec-v4.0-rtic
This is also a bit odd... why do you version children?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-03 9:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 1:56 [PATCH 0/9] dt-bindings: crypto: convert fsl-sec4 to DT schema Peng Fan (OSS)
2023-03-01 1:56 ` [PATCH 1/9] ARM: dts: vfxxx: drop the number after jr Peng Fan (OSS)
2023-03-01 1:56 ` [PATCH 2/9] dt-bindings: crypto: fsl-sec4: convert to DT schema Peng Fan (OSS)
2023-03-03 9:53 ` Krzysztof Kozlowski
2023-03-01 1:56 ` [PATCH 3/9] dt-bindings: crypto: fsl-sec4: support sec5.4/0 and i.MX6UL Peng Fan (OSS)
2023-03-03 9:55 ` Krzysztof Kozlowski [this message]
2023-03-07 6:56 ` Gaurav Jain
2023-03-01 1:56 ` [PATCH 4/9] dt-bindings: crypto: add fsl-sec4-snvs DT schema Peng Fan (OSS)
2023-03-01 3:07 ` Rob Herring
2023-03-03 9:58 ` Krzysztof Kozlowski
2023-03-01 1:56 ` [PATCH 5/9] dt-bindings: crypto: fsl-sec4-snvs: add simple-mfd compatible Peng Fan (OSS)
2023-03-03 10:00 ` Krzysztof Kozlowski
2023-03-01 1:56 ` [PATCH 6/9] dt-bindings: crypto: fsl-sec4-snvs: add fsl sec 5.x compatible Peng Fan (OSS)
2023-03-03 10:01 ` Krzysztof Kozlowski
2023-03-07 6:47 ` Gaurav Jain
2023-03-07 6:58 ` Peng Fan
2023-03-01 1:57 ` [PATCH 7/9] dt-bindings: crypto: drop fsl-sec4 txt binding Peng Fan (OSS)
2023-03-02 13:26 ` kernel test robot
2023-03-03 10:02 ` Krzysztof Kozlowski
2023-03-01 1:57 ` [PATCH 8/9] dt-bindings: crypto: fsl-sec4-snvs: add snvs-lpgpr support Peng Fan (OSS)
2023-03-03 10:03 ` Krzysztof Kozlowski
2023-03-01 1:57 ` [PATCH 9/9] dt-bindings: crypto: fsl-sec4-snvs: add poweroff support Peng Fan (OSS)
2023-03-03 10:03 ` Krzysztof Kozlowski
2023-03-01 3:06 ` [PATCH 0/9] dt-bindings: crypto: convert fsl-sec4 to DT schema Rob Herring
2023-03-01 3:10 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89cb8fb1-4e0f-4b5e-26ab-702c0fda8760@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.gupta@nxp.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox