From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 583A2C64EC4 for ; Fri, 3 Mar 2023 09:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FIZGvPG/iEkhbJlwY7EsRgXIkapYVftAUz8YqGUVlOE=; b=q6RIOAuSSUerx1 Rl9wzO61tt0Ngm/H4iTLDaHquvPTq6Az3eEpn32B3KZ4ye6+5YssKhbagfYfZofXmymBbQoROd7yv IZEcXzbslf2zp2eiTCu9XNWEOwE1kxJcueKOyshU5KBqLfGAjfrX5UX0HEJTQcKnqtb9FecayOiz9 KU+FzpxsoU2KLUTE4LAI35hrZkVoBuc+ScgbyAg9SGX/IYxVsDWxOGxb+eBbYqyrij5ylVpY6s1pV FSDQZEaRTAHVQKT6iHkdFKSrIRS83qLLkk6PqyFTCVUkMT3TZ60nMIt97fHTFSiIBBfj9IinbDl+d 3SjXfHWFcdToFTdZflMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY28U-005tqb-4L; Fri, 03 Mar 2023 09:55:34 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY28R-005toY-DW for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 09:55:32 +0000 Received: by mail-ed1-x533.google.com with SMTP id f13so8007639edz.6 for ; Fri, 03 Mar 2023 01:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677837325; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vcI9TwKeql7BEK1sJIRMqGKUdiKBhH06Xafoh6GvtOY=; b=nV3ygc6++KEALlPvrCi/LzP/zqVtODcKrm2ci3aPLG7xZhFB701k2yIDEhfjZcEhE4 AAhPxw1QOuIa8o3cVU4jU1ajdZd7+9PPVYYH0fTK6WzPz8lWJfDfDgRrcMuAaIaJEoQI 94+us00zm4xpazZjUaX/Y0Khzztzh2y/fduLKZPC6UW7GX19w451IqC451Ehw2lB/Wtd YKG9A+iY5IVJbrvt9r8pUsBd2eGVimX9PgEap/eYWqcoshRD7MlkLmQjg52ERd9lad9U A5tk/bN1PJ8TrSB2oZpiUCqN0h/UPbx64HQvV3myN+kSefGrJ2P+cMwB8NUagZ5YlmUe OFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677837325; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vcI9TwKeql7BEK1sJIRMqGKUdiKBhH06Xafoh6GvtOY=; b=zdGP8a2sSXIPELJd2CBtQic1RTgI+q6e0B0fHJrq2E8bBfrwBBUNbW5TgEbcp8lvPu uZ2d9G1QftQpCOKG+qNiP+L8ZTBUSEoj2bSyr6xmMqlHeXpOwkaYJkvklk8lZIKzV43K 0KEU8OeSBWkrJDtGSehme2BI2AA07+hLuZVA1fTIrDuynB6HiBw4ts8pzRY8+0JUWdLn I+DHwqLa950TctfMJ48Qyslodzt2nBvBDNS4kc/1aQMRt/DuFcGe/9DNFy4TrUJLI2Sg WwqywDTLLq4Oc0zHiLCPFLXZ9YFyNDiZ4ICICVeomxjeG9rNVDPTYuZZ4As9Pwgc7SEr M0QA== X-Gm-Message-State: AO0yUKXxRbEJFSOIDiyqGmJMLXo7C1x1HbBUFrABGPBTEimI3wegSaPF G4/IuHhJHb0hQ/fg7iqr9rH2yQ== X-Google-Smtp-Source: AK7set/ny4L1u0FncdnBsIrArL6/bdtnybsH8zYJlQ/du/6yDCErh0hTkh1Nsd2BHS3zVK4BhOKRpA== X-Received: by 2002:aa7:d347:0:b0:4ae:e51e:9e3e with SMTP id m7-20020aa7d347000000b004aee51e9e3emr1147431edr.24.1677837325252; Fri, 03 Mar 2023 01:55:25 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l3-20020aa7cac3000000b004af6f37d25bsm932016edt.76.2023.03.03.01.55.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 01:55:24 -0800 (PST) Message-ID: <89cb8fb1-4e0f-4b5e-26ab-702c0fda8760@linaro.org> Date: Fri, 3 Mar 2023 10:55:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/9] dt-bindings: crypto: fsl-sec4: support sec5.4/0 and i.MX6UL Content-Language: en-US To: "Peng Fan (OSS)" , herbert@gondor.apana.org.au, davem@davemloft.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, horia.geanta@nxp.com, pankaj.gupta@nxp.com, gaurav.jain@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, stefan@agner.ch, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan References: <20230301015702.3388458-1-peng.fan@oss.nxp.com> <20230301015702.3388458-4-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230301015702.3388458-4-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_015531_516243_415095CE X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/03/2023 02:56, Peng Fan (OSS) wrote: > From: Peng Fan > > Add i.MX6UL, SEC 5.0 and SEC 5.4 support. > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/crypto/fsl-sec4.yaml | 58 ++++++++++++++++--- > 1 file changed, 50 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml b/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml > index 678c8389ef49..1b801ae5ab51 100644 > --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml > +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.yaml > @@ -45,8 +45,18 @@ maintainers: > > properties: > compatible: > - enum: > - - fsl,sec-v4.0 > + oneOf: > + - enum: > + - fsl,sec-v4.0 > + - items: > + - enum: > + - fsl,imx6ul-caam > + - fsl,sec-v5.0 > + - const: fsl,sec-v4.0 > + - items: > + - const: fsl,sec-v5.4 > + - const: fsl,sec-v5.0 What's the point of having all these versions? Better to use SoC-compatibles. > + - const: fsl,sec-v4.0 > > "#address-cells": > const: 1 > @@ -77,6 +87,8 @@ properties: > > clock-names: > oneOf: > + - items: > + - const: ipg > - items: > - const: mem > - const: aclk > @@ -85,11 +97,17 @@ properties: > - items: > - const: aclk > - const: ipg > + - items: > + - const: ipg > + - const: aclk > - items: > - const: ipg > - const: aclk > - const: mem > > + dma-coherent: > + type: boolean > + > fsl,sec-era: > description: > Optional. A standard property. Define the 'ERA' of the SEC device. > @@ -108,8 +126,16 @@ patternProperties: > > properties: > compatible: > - enum: > - - fsl,sec-v4.0-job-ring > + oneOf: > + - enum: > + - fsl,sec-v4.0-job-ring > + - items: > + - const: fsl,sec-v5.0-job-ring > + - const: fsl,sec-v4.0-job-ring > + - items: > + - const: fsl,sec-v5.4-job-ring > + - const: fsl,sec-v5.0-job-ring > + - const: fsl,sec-v4.0-job-ring > > reg: > maxItems: 1 > @@ -148,8 +174,16 @@ patternProperties: > > properties: > compatible: > - enum: > - - fsl,sec-v4.0-rtic > + oneOf: > + - enum: > + - fsl,sec-v4.0-rtic > + - items: > + - const: fsl,sec-v5.0-rtic > + - const: fsl,sec-v4.0-rtic > + - items: > + - const: fsl,sec-v5.4-rtic > + - const: fsl,sec-v5.0-rtic > + - const: fsl,sec-v4.0-rtic This is also a bit odd... why do you version children? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel