From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D4BEC41513 for ; Wed, 16 Aug 2023 12:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9hN6NqRUnbz2yDmwComaQ9HggdoFA7YC1zdeYBEpIpg=; b=oEIb3IqlBcK1jM Pb81rqmjh4aI87czh2BmaYDvgKKOw4HAEiDGyLL1ayNWnSP7AoWzEbYfBNoarCWND1g1DoPTVbEVQ ++Ews4kOehFwcokq9UnaWYCE3T+2Eqju1GysQRtJkB+2WOJobqsam3yuDstnH9Unjm9aHl/ygRUW/ mwmNGhv01dnLodxkzyB6/PQZ+hyK5vBcgC3bNt4TILWgRrIp3mTjg0pOHrLDmHMNGGFLPK/4FQ7AK QMICtYkYM7m1sFaMrW4yO5yZv0PYARqcUJ35RvHXDkqedZ1lmUpiZxEhmFzL5u2OCbS4jrxVRYhP3 YVHm/tVtG/midoPfz4SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWFlw-0049te-1k; Wed, 16 Aug 2023 12:37:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWFls-0049sh-1L; Wed, 16 Aug 2023 12:37:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 291316105A; Wed, 16 Aug 2023 12:37:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67732C433C8; Wed, 16 Aug 2023 12:37:04 +0000 (UTC) Message-ID: <89e72ad4-573d-2fa2-9883-9cbedc8c00ff@xs4all.nl> Date: Wed, 16 Aug 2023 14:37:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] media: vcodec: Fix potential array out-of-bounds in encoder queue_setup Content-Language: en-US, nl To: Nicolas Dufresne , Wei Chen , tiffany.lin@mediatek.com Cc: andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230810082333.972165-1-harperchen1110@gmail.com> <5a70c141736e91f635f71d9922a3bbe993a76c69.camel@ndufresne.ca> From: Hans Verkuil In-Reply-To: <5a70c141736e91f635f71d9922a3bbe993a76c69.camel@ndufresne.ca> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230816_053708_557536_408F9994 X-CRM114-Status: GOOD ( 32.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTAvMDgvMjAyMyAxNTo1OCwgTmljb2xhcyBEdWZyZXNuZSB3cm90ZToKPiBIaSwKPiAKPiBM ZSBqZXVkaSAxMCBhb8O7dCAyMDIzIMOgIDA4OjIzICswMDAwLCBXZWkgQ2hlbiBhIMOpY3JpdMKg Ogo+PiB2YXJpYWJsZSAqbnBsYW5lcyBpcyBwcm92aWRlZCBieSB1c2VyIHZpYSBzeXN0ZW0gY2Fs bCBhcmd1bWVudC4gVGhlCj4+IHBvc3NpYmxlIHZhbHVlIG9mIHFfZGF0YS0+Zm10LT5udW1fcGxh bmVzIGlzIDEtMywgd2hpbGUgdGhlIHZhbHVlCj4+IG9mICpucGxhbmVzIGNhbiBiZSAxLTguIFRo ZSBhcnJheSBhY2Nlc3MgYnkgaW5kZXggaSBjYW4gY2F1c2UgYXJyYXkKPj4gb3V0LW9mLWJvdW5k cy4KPj4KPj4gRml4IHRoaXMgYnVnIGJ5IGNoZWNraW5nICpucGxhbmVzIGFnYWluc3QgdGhlIGFy cmF5IHNpemUuCj4+Cj4+IEZpeGVzOiA0ZTg1NWE2ZWZhNTQgKCJbbWVkaWFdIHZjb2RlYzogbWVk aWF0ZWs6IEFkZCBNZWRpYXRlayBWNEwyIFZpZGVvIEVuY29kZXIgRHJpdmVyIikKPj4gU2lnbmVk LW9mZi1ieTogV2VpIENoZW4gPGhhcnBlcmNoZW4xMTEwQGdtYWlsLmNvbT4KPj4gQ2M6IHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmcKPj4gLS0tCj4+IENoYW5nZXMgaW4gdjI6Cj4+IC0gQWRkIEZpeGVz IHRhZyBhbmQgQ0Mgc3RhYmxlIGVtYWlsIGFkZHJlc3MKPj4gLSBDaGFuZ2UgdGhlIHRpdGxlIHRv IGJlIG1vcmUgZXhwcmVzc2l2ZQo+Pgo+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tZWRpYXRl ay92Y29kZWMvbXRrX3Zjb2RlY19lbmMuYyB8IDIgKysKPj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbWVk aWF0ZWsvdmNvZGVjL210a192Y29kZWNfZW5jLmMgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL21l ZGlhdGVrL3Zjb2RlYy9tdGtfdmNvZGVjX2VuYy5jCj4+IGluZGV4IDlmZjQzOWE1MGY1My4uOWU4 ODE3ODYzY2I4IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL21lZGlhdGVr L3Zjb2RlYy9tdGtfdmNvZGVjX2VuYy5jCj4+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v bWVkaWF0ZWsvdmNvZGVjL210a192Y29kZWNfZW5jLmMKPj4gQEAgLTgyMSw2ICs4MjEsOCBAQCBz dGF0aWMgaW50IHZiMm9wc192ZW5jX3F1ZXVlX3NldHVwKHN0cnVjdCB2YjJfcXVldWUgKnZxLAo+ PiAgCQlyZXR1cm4gLUVJTlZBTDsKPj4gIAo+PiAgCWlmICgqbnBsYW5lcykgewo+PiArCQlpZiAo Km5wbGFuZXMgIT0gcV9kYXRhLT5mbXQtPm51bV9wbGFuZXMpCj4+ICsJCQlyZXR1cm4gLUVJTlZB TDsKPiAKPiBJIGRvbid0IHRoaW5rIHRoZSBjbGFpbSByZWFsbHkgZXhpc3RzLiAJRm9yIHRoaXMg ZHJpdmVyLCB3aGVuICpucGxhbmUgaXMgc2V0LAo+IGl0IHdpbGwgYmU6Cj4gCj4gCj4gICAgICAg ICBjYXNlIFY0TDJfQlVGX1RZUEVfVklERU9fT1VUUFVUX01QTEFORToKPiAgICAgICAgICAgICAg ICAgcmVxdWVzdGVkX3BsYW5lcyA9IGYtPmZtdC5waXhfbXAubnVtX3BsYW5lczsKPiAgICAgICAg ICAgICAgICAgaWYgKHJlcXVlc3RlZF9wbGFuZXMgPT0gMCB8fAo+ICAgICAgICAgICAgICAgICAg ICAgcmVxdWVzdGVkX3BsYW5lcyA+IFZJREVPX01BWF9QTEFORVMpCj4gICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gICAgICAgICAgICAgICAgIGZvciAoaSA9IDA7IGkg PCByZXF1ZXN0ZWRfcGxhbmVzOyBpKyspCj4gICAgICAgICAgICAgICAgICAgICAgICAgcmVxdWVz dGVkX3NpemVzW2ldID0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGYtPmZtdC5w aXhfbXAucGxhbmVfZm10W2ldLnNpemVpbWFnZTsKPiAgICAgICAgICAgICAgICAgYnJlYWs7Cj4g Cj4gT3IgdGhlIHZhbHVlIHRoZSBkcml2ZXIgaGF2ZSBzZXQgaXQgaW4gdGhlIHByZXZpb3VzIGNh bGwgd2l0aCAqbnBsYW5lID09IDAuIFNvCj4gdW5sZXNzIHRoZXJlIGlzIGEgYnVnLCB0aGlzIHNo b3VsZCBub3QgaGFwcGVuLCBhbmQgbW9yZSBpbXBvcnRhbnRseSwgdGhlIGNvcmUKPiBzaG91bGQg bm90IGxldCB0aGF0IGhhcHBlbiwgbWVhbmluZyBpdCBzaG91bGQgbm90IGJlIGRyaXZlciBqb2Jz IHRvIHZhbGlkYXRlCj4gdGhpcy4KPiAKPiBteSAyIGNlbnRzLAo+IE5pY29sYXMKPiAKPiAKPj4g IAkJZm9yIChpID0gMDsgaSA8ICpucGxhbmVzOyBpKyspCj4+ICAJCQlpZiAoc2l6ZXNbaV0gPCBx X2RhdGEtPnNpemVpbWFnZVtpXSkKCkl0J3MgcV9kYXRhLT5zaXplaW1hZ2UgdGhhdCBoYXMgb25s eSAzIGVsZW1lbnRzLCBzbyBpZiAqbnBsYW5lcyBpcyA0LCB0aGVuCnRoaXMgd2lsbCBmYWlsIHdp dGggYW4gT09CLgoKSG93ZXZlciwgSSB0aGluayB0aGUgY2hlY2sgc2hvdWxkIHJlYWxseSBoYXBw ZW4gaW4gdGhlIHZiMiBjb3JlLiBJZiBubwpidWZmZXJzIGhhdmUgYmVlbiBhbGxvY2F0ZWQgeWV0 LCB0aGVuIHRoZSBxdWV1ZV9zZXR1cCBjYWxsYmFjayB3aWxsIHNldAp0aGUgbnVtYmVyIG9mIHBs YW5lcyBiYXNlZCBvbiB0aGUgY3VycmVudCBmb3JtYXQuCgpJZiBDUkVBVEVfQlVGUyBpcyBjYWxs ZWQgYWZ0ZXJ3YXJkcywgdGhlbiAqbnBsYW5lcyBpcyBzZXQgdG8gdGhlIG51bWJlcgpvZiBwbGFu ZXMgdGhhdCBpcyBzcGVjaWZpZWQgaW4gdGhlIGZvcm1hdCBmaWVsZCBvZiBzdHJ1Y3QgdjRsMl9j cmVhdGVfYnVmZmVycy4KClRoZSBjb3JlIGNsaXBzIHRoYXQgdmFsdWUgdG8gdGhlIHJhbmdlIFsx Li5WSURFT19NQVhfUExBTkVTXSwgYnV0IG90aGVyd2lzZSBpdApwbGFjZXMgbm8gcmVzdHJpY3Rp b25zLgoKSSB3YXMgYWZyYWlkIHRoYXQgdGhpcyB3b3VsZCBjYXVzZSBzZXJpb3VzIHByb2JsZW1z IGlmIGZld2VyIHBsYW5lcyBhcmUKcmVxdWVzdGVkIHRoYW4gdGhlIGN1cnJlbnQgZm9ybWF0IG5l ZWRzLCBidXQgaW4gdGhhdCBjYXNlIHRoZSBzaXplIGNoZWNrcwppbiB0aGUgYnVmX3ByZXBhcmUg Y2FsbGJhY2sgb2YgdGhlIGRyaXZlciB3aWxsIGZhaWwgKHNpbmNlIG9uZSBvciBtb3JlIHBsYW5l cwp3aWxsIGhhdmUgc2l6ZSAwKS4KClRoZSBpZGVhIGJlaGluZCBhbGxvd2luZyB1c2Vyc3BhY2Ug dG8gYWxsb2NhdGUgZGlmZmVyZW50IG51bWJlciBvZiBwbGFuZXMKaW4gQ1JFQVRFX0JVRlMgcmVh bGx5IG1ha2VzIGxpdHRsZSBzZW5zZSBhbmQgdGhlcmUgYXJlIG5vIGRyaXZlcnMgdGhhdCByZWx5 Cm9uIHRoaXMuIEl0IHdvdWxkIGJlIG11Y2ggYmV0dGVyIGlmIHRoZSB2YjIgY29yZSB3b3VsZCBy ZXR1cm4gLUVJTlZBTCBpZgp0aGUgcmVxdWVzdGVkIG51bWJlciBvZiBwbGFuZXMgZG9lcyBub3Qg bWF0Y2ggdGhhdCBvZiB3aGF0IGlzIHVzZWQgZm9yIGFscmVhZHkKYWxsb2NhdGVkIGJ1ZmZlcnMu CgpJZiB3ZSBldmVyIGdldCBkcml2ZXJzIHRoYXQgZm9yIHNvbWUgcmVhc29uIHdhbnQgbW9yZSBm bGV4aWJpbGl0eSwgdGhlbiB0aG9zZQpkcml2ZXJzIGNhbiBzZXQgYSBzcGVjaWFsIGZsYWcgaW5k aWNhdGluZyB0aGF0IHRoZXkgd2FudCB0byBjaGVjayB0aGlzIHRoZW1zZWx2ZXMuCgpJJ2xsIHBv c3QgYSBwYXRjaCBhZGRpbmcgdGhlIGNoZWNrIHRvIHRoZSB2YjIgY29yZS4KClJlZ2FyZHMsCgoJ SGFucwoKPj4gIAkJCQlyZXR1cm4gLUVJTlZBTDsKPiAKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==