From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A78EC67861 for ; Tue, 9 Apr 2024 10:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0nB59EZ7C/ZueA+VJoanZPApJyV4x9sX+z7M7KXyDIA=; b=B9vlOZ5s1K8QOO Nch/xbBtPNNuhqLPpFsupOUx4jTCm0detbxL5s1loHsk29x3zUghd/DDUJrpOFfKnhy9DBlqBoEEX RvkQjh6OYRI7RFO+v+vqd3HL9KxY0Nak9YbnK40PQUJsaEDfWyGCIiDqJVVF28Gk2ft1BLtlqQhmF H3NKWNT9ql4skNRgG3vztq4LkPnH6gIYkSFkgI98ISwy0tIEkNwAIvaBn3iadLu/FhU2KSXuo1LSq Oqv3LwECcXMal4+qOA3LLqk8LuJYmUHf08nwS7se09+lH3QkpkVcizesIDOErfFPov6aSdo8GmiBY 8Tp4GXbJVLuHpkyhJhmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8le-00000001THd-1rcd; Tue, 09 Apr 2024 10:31:54 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru7g8-00000001Aqj-3a8I for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 09:22:20 +0000 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2d82713f473so91978961fa.3 for ; Tue, 09 Apr 2024 02:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712654525; x=1713259325; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r1YI1LD16aBiZ7GIogy/yUsyhydLDw6SsonapHKI3FE=; b=KuAzAS2yqxQziWTs9coA2dYRsmN9Far5PzAW2b1tCMC24L2s2Ev+QUF0jDCcx3CinE Whe/7uSiIQNauW3X6hbHrJjAfXNeAUC5Xc3WV1TqbsLQYaXUbm9EWmJYr6JNxomzzpZn 71WL3dVRY0AkBCXXSKKlHacb+fvXb5bskpOVgOSJJ4WRjvVJs+c0a3K6oFvn2MwX293D m/BQzBPgww1mv1vNwlAhtq0as5SjnFZ52NpdJIK5XV6hfKtF6IodR69SP1bNMrEs4sh6 M0oJGPxRIHUwIr292niSUvUj+kH8cAQySdG0AuEALlGbkD3Oft8RuOibhg5VvKGZWGgj Dqew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712654525; x=1713259325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r1YI1LD16aBiZ7GIogy/yUsyhydLDw6SsonapHKI3FE=; b=p0eIg1hp4tDQZoueE92J928fcIFfmnQFF/gcaBscv+AubOf3KgIqZLYBQNPnX7CMOZ r9eCEP31w0Gr8sv/f2omBTlmZfwkL0xHJNcU7rZNFA0EUhezdhifN9VzK2Hf9Gqk403d FzY63ECcqHKL+BLGbbtiKylG7jJxgc7GnTCX8EtVyPyuLUoHl9o82uVXusdz183Br9VW sVk5E8XKSJ0RIvWwSlC200lOOb/XMUNH10NiLCwmpTrwWCgjsdqEVUEDoy/RdIDUuMX7 zEdzS6+rL2PWD16Czs6YGoGCIw6lxma6lXjRt6y6APGi5d9mbuholad9Frq8MpwDLmyL KvOg== X-Forwarded-Encrypted: i=1; AJvYcCUjijHIsO9BytQ/mw1ypzZv/yIiUHez/PuXDF17hmZv9PJkpN1+LuTvSpaMwZp/agWhCsq08cEkeTxtvkgPnry0A2eq/6H+FFFLE4RSfjaEtMyIEx0= X-Gm-Message-State: AOJu0YxuIbA87yx5sOej7MMhNX3qRS57dq1w711bsMyfEsyf9EmtUE+E dmcCQP7oWMVJWfjgp9Y9QrE4zPlGDsf/O9zZv16zt2hByad8+RY1 X-Google-Smtp-Source: AGHT+IEd5fPYAVXM4XxUF+C21LNjRVh8lxcxzN8JGvpeWnZKVlON9QdWZ6IU7KdQRBRKVpgj6S6efw== X-Received: by 2002:a2e:854c:0:b0:2d6:f5c6:e5a1 with SMTP id u12-20020a2e854c000000b002d6f5c6e5a1mr8870002ljj.12.1712654524793; Tue, 09 Apr 2024 02:22:04 -0700 (PDT) Received: from [192.168.0.31] (84-115-213-64.cable.dynamic.surfer.at. [84.115.213.64]) by smtp.gmail.com with ESMTPSA id qs1-20020a170906458100b00a4e6626ae21sm5454291ejc.0.2024.04.09.02.22.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 02:22:04 -0700 (PDT) Message-ID: <89e7db2d-1de0-4e2e-a2d2-f00d45399b11@gmail.com> Date: Tue, 9 Apr 2024 11:22:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/9] dt-bindings: rtc: stmp3xxx-rtc: convert to dtschema To: Krzysztof Kozlowski , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiaxun Yang , Vladimir Zapolskiy , Joel Stanley , Andrew Jeffery , Maxime Coquelin , Alexandre Torgue Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240408-rtc_dtschema-v1-0-c447542fc362@gmail.com> <20240408-rtc_dtschema-v1-8-c447542fc362@gmail.com> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_022209_130408_BEEE2A36 X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/9/24 09:40, Krzysztof Kozlowski wrote: > On 08/04/2024 17:53, Javier Carrasco wrote: >> Convert existing binding to dtschema to support validation. >> >> The 'fsl,imx28-rtc' compatible is currently not supported, and it is >> only referenced in this binding and in nxp/mxs/imx28.dtsi. Therefore, >> that compatible has been dropped, which triggers a warning when testing >> the DT against the new binding. > > Instead document missing compatibles and mention this in commit msg. > There is no driver that will match 'fsl,imx28-rtc', only 'fsl,stmp3xxx-rtc', so I am not sure how to document the missing compatible in a sensible way. My first suggestion to account for undocumented strings would be: compatible: oneOf: - items: - enum: - fsl,imx23-rtc - fsl,imx28-rtc - const: fsl,stmp3xxx-rtc - const: fsl,stmp3xxx-rtc Any suggestions or improvements? >> >> There is another reference to fsl,stmp3xxx-rtc in nxp/mxs/imx23.dtsi, >> where another unsupported compatible 'fsl,imx23-rtc' is used, and the >> same problem would arise when testing the file against the new binding. > > Please write concise messages... you have to paragraphs about the same? > What is the difference here? > The difference is that 'fsl,imx23-rtc' was not even mentioned in any binding, and it can only be found in imx23.dtsi. 'fsl,imx28-rtc' was indeed mentioned in the txt binding. My understanding after your comment is that we should gather undocumented compatibles and add them to the bindings they would belong to,no matter if they are used anywhere or not. I added this one to the suggestion above as well. >> >> Signed-off-by: Javier Carrasco >> --- >> .../devicetree/bindings/rtc/fsl,stmp3xxx-rtc.yaml | 45 ++++++++++++++++++++++ >> .../devicetree/bindings/rtc/stmp3xxx-rtc.txt | 21 ---------- >> 2 files changed, 45 insertions(+), 21 deletions(-) >> > > > Best regards, > Krzysztof > Best regards, Javier Carrasco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel