From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46550C433EF for ; Tue, 12 Apr 2022 11:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lbGaKlD+JJ3kNKo4d336iTuQsDxE6ZcE0PohvKDeJoQ=; b=EcxAPzvB+DBH3Z pKnOMtZyV92xllZfnS9FV8iHePxOhcZVDhdJXWWhgIDz95ZrgTqVbjClyCrZqtzrEedBzI+Xm3EKo RcPxkOewS7PtEhle/ppzhQvX/vHSXs/xmOEHAFoRrLT91gSf6EJGPnwuqSlPO8F0SMlWT2KuQoch2 4718qFqSvWSAZnzXpZAOshqhPJSkoEc1w9KB+iA9/Z2ecjtUmRf/61OrlzKxCeZwh0G/23N/tMKOd yE7T1Ha59RE9pxOUdkGM6ek0JAF6a79fkzaEO5wZPqjJmdElNYqaFK1D/qrB3HSZ80A8ucFtf/kTp ICkq9iAN/bVkQzhPZueg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neExr-00DoKt-9w; Tue, 12 Apr 2022 11:45:44 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neEpk-00Dkj3-LV for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 11:37:22 +0000 Received: by mail-ej1-x62b.google.com with SMTP id bh17so36712194ejb.8 for ; Tue, 12 Apr 2022 04:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Ireb+u2fz+HNDp7W/0u9tq1dE6EEB8pXAEENxA5hKe0=; b=N3/DiKCNwWEXj6baA/2A7S/u+N9x0cmIYnpFq5u882hKTkppGapWKjCAzu6HvUzdTb sYHXpr6qZJwnrsqJWLdgMv0sg/7fxY1FO0iUCbgAS/aWCtA+qdSsgSjdtQ3Vl3kikFaH Ity+WWj1mcX+25gbyeHsj2h2Yom8e5qNmDrIgfpEJ0jbVf13S1FtMLyYY+CamfhXm4Hh kByIIuYOH90KylSxKVeYQ7BkbiYp8IvlnQyKLDAbYLYocFfUF8J226MVMo374edYU8Wi iUcGMPq5CQsOFI0pyC/0IOSBJpjRAvS2afx8ubJTpSig8FABBB3LfG2S4Ep5WP5xXqft F3Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Ireb+u2fz+HNDp7W/0u9tq1dE6EEB8pXAEENxA5hKe0=; b=vy0ApYX9H/zHZJZEaFUEYvI0StawFnnG9z4BAvXN0x2VAc8Ok2i1JQyAluPMjAhdOb KXOJklJW5zZOWf+xgKH2EAL64eKkMC1p1ny/FqZfRjBvp9iyBHoz/TvEzPXhWy2UHSL9 pc6eMqMRCSBj3Lqj/whxKEENoloDm6C5EpBraBZzpgGWjm1Wkv+tex+CmkLwsGGNFBH3 OcM0Mwk3re196GXut/xF/bbNXo74co4Bz+D7qWbv8tnu0JHghhAmDlC4xtdkIZlMAZ5E B3Wx/dd1bD9Ssb0muShqso4OtZSnKEDWao1AvScsYGyO1rLQfduxOwNsfLlWEMMHksYh Ccng== X-Gm-Message-State: AOAM531BydJ4OVjW7jTSXksOeeZReO6+AVlADmLewSu2H7kq3jDqCbBi E/ajlj2OXJcsBQsC3tRL/SY= X-Google-Smtp-Source: ABdhPJyVdngo1HvueM2ZUMpF2ABzA9tTU6Hq/Z1IehvEZwx5+grwH5M0xobTdptT/tEuHm5m8cBuXw== X-Received: by 2002:a17:907:160b:b0:6e8:58c1:8850 with SMTP id hb11-20020a170907160b00b006e858c18850mr14414194ejc.284.1649763438997; Tue, 12 Apr 2022 04:37:18 -0700 (PDT) Received: from smtpclient.apple (i130160.upc-i.chello.nl. [62.195.130.160]) by smtp.gmail.com with ESMTPSA id fu13-20020a170907b00d00b006e8ae97f91asm947697ejc.64.2022.04.12.04.37.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Apr 2022 04:37:18 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH net-next v2 05/18] net: dsa: mv88e6xxx: remove redundant check in mv88e6xxx_port_vlan() From: Jakob Koschel In-Reply-To: Date: Tue, 12 Apr 2022 13:37:17 +0200 Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Edward Cree , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Casper Andersson , Colin Ian King , Arnd Bergmann , Michael Walle , Christophe JAILLET , Eric Dumazet , Xu Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, bpf@vger.kernel.org, Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." , Vladimir Oltean Message-Id: <8BAFAAD1-D9AB-4339-BE81-18BE564F78F6@gmail.com> References: <20220412105830.3495846-1-jakobkoschel@gmail.com> <20220412105830.3495846-6-jakobkoschel@gmail.com> To: "Russell King (Oracle)" X-Mailer: Apple Mail (2.3696.80.82.1.1) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_043720_776187_29813B38 X-CRM114-Status: GOOD ( 22.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 12. Apr 2022, at 13:27, Russell King (Oracle) wrote: > > On Tue, Apr 12, 2022 at 12:58:17PM +0200, Jakob Koschel wrote: >> We know that "dev > dst->last_switch" in the "else" block. >> In other words, that "dev - dst->last_switch" is > 0. >> >> dsa_port_bridge_num_get(dp) can be 0, but the check >> "if (bridge_num + dst->last_switch != dev) continue", rewritten as >> "if (bridge_num != dev - dst->last_switch) continue", aka >> "if (bridge_num != something which cannot be 0) continue", >> makes it redundant to have the extra "if (!bridge_num) continue" logic, >> since a bridge_num of zero would have been skipped anyway. >> >> Signed-off-by: Jakob Koschel >> Signed-off-by: Vladimir Oltean > > Isn't this Vladimir's patch? > > If so, it should be commited as Vladimir as the author, and Vladimir's > sign-off should appear before yours. When sending out such patches, > there should be a From: line for Vladimir as the first line in the body > of the patch email. yes, you are right. I wasn't sure on how to send those commits, but I guess if I just set the commit author correctly it should be fine. regarding the order: I thought I did it correctly doing bottom up but I confused the order, wasn't on purpose. Sorry about that. I'll resend after verifying all the authors and sign-offs are correct. > > The same goes for the next mv88e6xxx patch in this series - I think > both of these are the patches Vladimir sent in his email: > > https://lore.kernel.org/r/20220408123101.p33jpynhqo67hebe@skbuf > > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! Thanks for pointing it out! Jakob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel