From mboxrd@z Thu Jan 1 00:00:00 1970 From: yalin.wang2010@gmail.com (yalin wang) Date: Fri, 31 Jul 2015 17:25:02 +0800 Subject: [RFC] arm64:change jump_label to use branch instruction, not use NOP instr In-Reply-To: <20150731075259.GR25159@twins.programming.kicks-ass.net> References: <94E2034B-9DE4-4ADF-8B2F-197D38A363CF@gmail.com> <20150731075259.GR25159@twins.programming.kicks-ass.net> Message-ID: <8F6A71B0-C7DB-4505-BEE2-79967FC91A8F@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > On Jul 31, 2015, at 15:52, Peter Zijlstra wrote: > > On Fri, Jul 31, 2015 at 03:41:37PM +0800, yalin wang wrote: >> This change a little arch_static_branch(), use b . + 4 for false >> return, why? According to aarch64 TRM, if both source and dest >> instr are branch instr, can patch the instr directly, don't need >> all cpu to do ISB for sync, this means we can call >> aarch64_insn_patch_text_nosync() during patch_text(), >> will improve the performance when change a static_key. > > This doesn't parse.. What? > > Also, this conflicts with the jump label patches I've got. this is arch depend , you can see aarch64_insn_patch_text( ) for more info, if aarch64_insn_hotpatch_safe() is true, will patch the text directly. what is your git branch base? i make the patch based on linux-next branch, maybe a little delay than yours , could you share your branch git address? i can make a new based on yours . Thanks