From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B121E606A320 for ; Wed, 18 Nov 2026 12:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=10T/PvRx; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=TdJ23J5H DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=GjX5dn8YpgvZsZ/ABHgbZazrxQHsHlF3Djrqer5Cp/g=; b=10T/PvRxhP09gy 2sJkZFGS+ZDlcmZv26v4drccVYLVPKMUhv3pKMLTUw+UDnOt4eFD1fKp7uGU8iNiZcDwe7cMQRCNV MDaw1aFtcBI/HdQAm//6jsuLPgGLqwczRebOr3OSYTAw1Mf9jU0Pv8dIP2Ki3yQpOCXFV0eyQCJ73 5fQc3S4UQRzRorLswPg7ukylWmQKU4lWG3dWo8QdchbR1MAaRJiiwMQMlHXPrdzmnuv958r/6/JME r/LYHfBjsxzj610hWz7uB7iTwfxjhbhif6SmbxEQsOI7J8opb3SYSyMtIONg+BVFhTEYiruVFMp3H /VdJur6sOSY0SmWiSwHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTePO-00000008nEx-18Xr; Wed, 18 Nov 2026 12:05:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTePL-00000008nEG-2saO for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2026 12:05:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48EC61596; Wed, 18 Nov 2026 04:04:55 -0800 (PST) Received: from [10.57.70.68] (unknown [10.57.70.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7F22A3F632; Wed, 18 Nov 2026 04:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1795003498; bh=SIPpZoSZA3ybF9zdso+NVRICnQ4r/7VsBMwmu7R20j0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TdJ23J5HAp0e6F1wKGMcZcPfGZh5dJ+bBvB6GZi6bwhQwGbVR4N9r8ODtXvfnvSe8 d6+rO1GpcHjaT7sQA9mPB+X0/5maRbPRWiK8bAXFymFKFU/1WCvulutHG7fP6pGB1q 9XcoU5WUtTax9beMwbIgTHdiauENtEKPcKg4/18I= Message-ID: <8a095a42-662a-416d-a5d7-79e10161201c@arm.com> Date: Wed, 18 Nov 2026 12:04:52 +0000 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/11] KVM: arm64: guest_memfd: Check mmap support when preparing memslot Content-Language: en-GB To: Steven Price , Fuad Tabba Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo Pieralisi , Kohei Enju References: <20261116164358.142785-1-steven.price@arm.com> <20261116164358.142785-2-steven.price@arm.com> <6bb490cd-ebbe-41d7-adf3-d6eaf0e53478@arm.com> From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_040459_812953_D0DBBDA4 X-CRM114-Status: GOOD ( 13.38 ) X-Spam-Score: -4.4 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 18/11/2026 11:14, Steven Price wrote: > On 18/11/2026 10:34, Suzuki K Poulose wrote: >> Hi Steven >> >> On 17/11/2026 14:05, Fuad Tabba wrote: >>> Hi Steven, >>> >>> On Mon, 16 Nov 2026 16:43:47 +0000, Steven Price >>> wrote: >>>> Check the guest_memfd backing file when deciding whether an arm64 >>>> memslot has mappable memory rather than checking whether the slot is >>>> gmem only. A public helper function is added to be able to reuse the >>>> static kvm_gmem_supports_mmap() function. >>> >>> nit: could the message say why this is needed? It's a no-op until >>> patch 8 defines kvm_arch_has_private_mem(), which makes every >>> guest_memfd slot gmem-only. >> >> I still don't understand why this is needed. For arm64 we have always >> prevented guest_memfd without MMAP, in kvm_arch_prepare_memory_region(). > > Fuad is correct, this isn't really needed until patch 8. Patch 8 defines > kvm_arch_has_private_mem() - that means that gmem_in_place_conversion > becomes true (see include/linux/kvm_host.h). That in turn means that > every guest_memfd slot is KVM_MEMSLOT_GMEM_ONLY including slots backed > by a file without mmap support. But we dont support slots without MMAP anyways even without this series. So, does it really matter for arm64 ? Suzuki > > But regardless the check for kvm_memslot_is_gmem_only() isn't really > what the code is trying to do. The fact that the memslot is "gmem only" > isn't really relevant. The thing we care about is the mappability. > > But I agree the commit message could do with improving. I'll expand that. > > Thanks, > Steve