From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D53E3C6FA82 for ; Fri, 23 Sep 2022 09:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i/TZcelRe3KLjjOqCiBNeM8mBvngrjpI+L7gNUC2SHA=; b=BpbBIrN2zs7WEt HdGU976I66clDU6aIdWIGBnPtAIucfGLot4UVJEERfFCJ3zgCIRRGvJA1wI15w27VF9k3hO3o0Ehj BpO6cIenfAoapxl+GKykanty3JrFfeXLbKMt9CwhVOMK519H7N013ki24mlSarv1GQbec63YSU+r9 i4eJr2ic36GKKjGYEd6Pg/Ixb/ww/5jH+9CNA1cEdvZzsfN0hmCGN56cqU4TPApoHJE8B1aKIYfph FXZbfyVinsUBNF3l3R9/afplbayuMnWpkQiN9Ifl+XNRN1K9A56+Geg5Igln0McwjR25jJHFxnmuB 3FH9dtPoBmatYUTh9kDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obeqI-003G0x-Eq; Fri, 23 Sep 2022 09:19:30 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obeqE-003FyL-II for linux-arm-kernel@lists.infradead.org; Fri, 23 Sep 2022 09:19:28 +0000 Received: by mail-lf1-x12f.google.com with SMTP id k10so18844212lfm.4 for ; Fri, 23 Sep 2022 02:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Kn1SujOTRSyA2lpFvTg92J/mHIxi4T22q5/4Og5DL18=; b=Eravv2cszM2onFllxNWqYfBkD2740qBYFMRrXIf/p9/edgz7MSfXRZdUAyJ2AaU3vC Mdz+alj2diNP/8pOAzvz3iRVzsPgFAMP8pZuwVy4EMwG+p3JIHRHdwS8KvHzmWjm0WFD YwHr1fiqKz1ijvu+1ezC7ufTqVnYqE8x6MoVAP3RX38AfAzYvVMxAd23G5CXD/L0Dk/Q qy/UsJUcbonOM68PnejWezrVckk9dqriUPgTWZQCtA3LETESFBcDxT46EqDVm83rEcn9 VjMwMczMe9F7mc2DZZxDOIVxmpyG0qcWW6faK1eJ74cuApyVV2LsFfktYCX6kgQBTqS9 aW2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Kn1SujOTRSyA2lpFvTg92J/mHIxi4T22q5/4Og5DL18=; b=c/A6tT/lBxEsuMS0ORd1PdbIBvi6T1o/NKxuUkTa52r7bwNZj94ymO09hm9eZR4zAa IWbAfDcCqgoaNwI2S/1qnPtHi5dEhn/ElZTmUnDbhkXXWXcXOMibecztTa7AUmhkAqzL n+xb2KKjoFr/5S8n4GWJzM28bL1D204Si8q0D+qlrqVaEh7en70Sj2mke3sIoqKMcCdH vMjlVBimfTGnHW/jWGfodLo0PR7csihbAOOUA3mle/yeS/HcvguTQpasBpYEZNGWNYkT RFgktpp8ujDvyZsVs/0fEGAalwqZnpy9vI8N9OzPIe31Rf6oyPbKiu6j8idpCMBYjQUm OHJA== X-Gm-Message-State: ACrzQf3dd1157q1sYIT1fq5f6ECrmP/o0+2DpdT4ueV6Km1RhAk5grAk Cwo1902/Ly7L2Z62hDLbXj6jzg== X-Google-Smtp-Source: AMsMyM7rAP554ffKv14+G5Z04osY2Lbv/LSvwWpONmenm703lxvFiMvD7gT95QU2MxQKWO3kXuJzyQ== X-Received: by 2002:a05:6512:10ce:b0:49e:ad1f:3d7 with SMTP id k14-20020a05651210ce00b0049ead1f03d7mr2653889lfg.609.1663924763678; Fri, 23 Sep 2022 02:19:23 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id g20-20020a2ea4b4000000b0026bddcf75d1sm1294971ljm.44.2022.09.23.02.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 02:19:23 -0700 (PDT) Message-ID: <8a256c49-1a7a-42bb-2daf-cc0c66b9f7a6@linaro.org> Date: Fri, 23 Sep 2022 11:19:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree Content-Language: en-US To: Mauri Sandberg , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, arnd@arndb.de, olof@lixom.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux@armlinux.org.uk Cc: pali@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220427162123.110458-1-maukka@ext.kapsi.fi> <20220922202458.7592-1-maukka@ext.kapsi.fi> <20220922202458.7592-3-maukka@ext.kapsi.fi> From: Krzysztof Kozlowski In-Reply-To: <20220922202458.7592-3-maukka@ext.kapsi.fi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220923_021926_684386_AE165CBA X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/09/2022 22:24, Mauri Sandberg wrote: > Add a device tree for D-Link DNS-323. The device has three different > variants; A1, B1 and C1. Common parts are included in a .dtsi file > and each hardware variant has its own .dts file. Thank you for your patch. There is something to discuss/improve. > + > +/delete-node/ &sata; > + > +&gpio0 { > + pinctrl-0 = <&pmx_gpio_misc>; > + pinctrl-names = "default"; > + > + /* The DNS323 rev A1 power LED requires GPIO 4 to be low. */ > + pin_gpio0_4 { No underscores in node names. > + gpio-hog; > + gpios = <4 GPIO_ACTIVE_LOW>; > + output-high; > + line-name = "Power led enable"; > + }; > +}; > + > +&pmx_gpio_misc { > + marvell,pins = "mpp4"; > +}; > + > +&pmx_ge { > + marvell,pins = "mpp11", "mpp12", "mpp13", "mpp14", "mpp15", > + "mpp16", "mpp17", "mpp18", "mpp19"; > +}; > diff --git a/arch/arm/boot/dts/orion5x-dlink-dns323b1.dts b/arch/arm/boot/dts/orion5x-dlink-dns323b1.dts > new file mode 100644 > index 000000000000..e01ba809ffca > --- /dev/null > +++ b/arch/arm/boot/dts/orion5x-dlink-dns323b1.dts > @@ -0,0 +1,39 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2022 Mauri Sandberg > + * > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include > +#include "orion5x-mv88f5182.dtsi" > +#include "orion5x-dlink-dns323.dtsi" > + > +/ { > + model = "D-Link DNS-323 rev B1"; > + compatible = "dlink,dns323b1", "dlink,dns323", "marvell,orion5x-88f5182", > + "marvell,orion5x"; > +}; > + > +&gpio0 { > + pinctrl-0 = <&pmx_gpio_misc>; > + pinctrl-names = "default"; > + > + /* The rev B1 has a flag to indicate the system is up. > + * Without this flag set, power LED will flash and cannot be > + * controlled via gpio-leds. > + */ > + pin_gpio0_3 { No underscores in node names. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel