From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C841C77B7A for ; Tue, 30 May 2023 19:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CMZYpL4YVGOMqNw9LkFB/kbh4QMIyUmz3c9MrV7sZZo=; b=slcRu+ZxyMnZdJ 1Z9rnFlj3tDI8787G4SE/HgdnCTgQkCJlUJ61Z4V/J7vJvf+ms5IGmqVwKBDUludxh3XWuqQe59cp 0kYrEo/asdmPuhpnPxPUIJItQwHPv/Ztj2n3oefTo77N0WXFMsj7nZVeQsKuAtlFjcMgVSHMaV8X/ v9FVJ832fEX0KqpqeHT5rlgfzgZXJu3n/UptM6HnCQDUj5NSpGb0r29hS8n0cWxE/+wAszDR5nIfe zH9CbuFksUcajQoULnL6op+lJzhIqrErk410zqCqiClYBluYODy4VTqOb7ndQ3dogwUoRipFsnJjH M3/ijvC00gKYjj0KsKeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q45J8-00F0oV-2s; Tue, 30 May 2023 19:47:02 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q45J6-00F0nK-0n; Tue, 30 May 2023 19:47:01 +0000 Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 459F56606E64; Tue, 30 May 2023 20:46:52 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685476014; bh=uuTnSILXVf1Z1lF8zz/SUkYOonCje3HPQu+Vt2KjcSM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m+WUKYl5YEGoFVtSrWHrdUVw+b4VDr1eengMK7E4zEmSxWSrqDtrZfeuM5Qhdl1jL qNXdD3P7KiBha5m8XuRaCsowQgxtz8dpWOVcgsSqFK6c39CjvxEXN6nbZGOuDtf3w0 hLQrsqWy2cMhepVQ6VlXODTrLJCKAxXPv/NyIGDXHLCwNf3HXr8vxT8PyYrQ2l4peB Rt3wiDxICVu2ZiHl0aRG9zCL9TyKLJUDCWoWVKCXRXwiXODSp/ccpllC3YBh8AOnGd H4nKIGT3AguTwt5gOX5B4WpucTjHNnZE4UjQBXLibiufCTGw74rDgq9e7ATzwYg+cl JcD3cuzSBDV5A== Date: Tue, 30 May 2023 15:46:48 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Daniel Lezcano Cc: Chen-Yu Tsai , Alexandre Bailon , kernel@collabora.com, Balsam CHIHI , AngeloGioacchino Del Regno , Alexandre Mergnat , Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 0/3] thermal/drivers/mediatek/lvts_thermal: Fixes to the interrupt handling Message-ID: <8a38a0da-3a4f-4e39-9f9e-42682edfd9bf@notapiano> References: <20230428195347.3832687-1-nfraprado@collabora.com> <20230502103344.GA3388518@google.com> <87b0f5cd-67a8-fbd5-5ca7-a286b543d796@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87b0f5cd-67a8-fbd5-5ca7-a286b543d796@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_124700_468358_7125C99D X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 30, 2023 at 02:27:36PM +0200, Daniel Lezcano wrote: > = > Hi, > = > On 02/05/2023 12:33, Chen-Yu Tsai wrote: > > On Fri, Apr 28, 2023 at 03:53:44PM -0400, N=EDcolas F. R. A. Prado wrot= e: > > > = > > > Fixes in the interrupt handling of the LVTS thermal driver noticed wh= ile > > > testing it on the Spherion Chromebook (mt8192-asurada-spherion) with = the > > > MT8192 support series [1]. > > > = > > > These are standalone fixes and don't depend on anything else. > > > = > > > [1] https://lore.kernel.org/all/20230307163413.143334-1-bchihi@baylib= re.com/ > > > = > > > Thanks, > > > N=EDcolas > > > = > > > = > > > N=EDcolas F. R. A. Prado (3): > > > thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controlle= rs > > > thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate = mode > > > thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts > > = > > This series seems to have solved all interrupt storm issue I ran into, = so > > = > > Tested-by: Chen-Yu Tsai > = > I gave a try on a mt8195 board and I don't see any interrupt firing when > crossing the temperature thresholds. > = > Did I miss something ? No, indeed interrupts seem to be completely disabled on mt8195, even after setting the controllers to filtered mode (a requirement to get interrupts).= I haven't investigated that further yet. This series was validated on mt8192, which did have working interrupts, but they were being triggered too often. Also note that I've sent a v2 with even more fixes: https://lore.kernel.org/all/20230504004852.627049-1-nfraprado@collabora.com/ Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel