From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15866C433F5 for ; Mon, 21 Feb 2022 13:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xN4/XEURPiy0m6lwk/cRTUGpLTsVEYNjnMf5RcAKtco=; b=mEO7P/EfelbF6o 0PciCcoWU/tZbi6XYD3VB4xvxZ3YDuinbX0DnKXZ7nzqvk1ODQzgEs7j0GMd9mZWDrOydIaopz7nQ XRp35TZLbGbULjpRDkBcKbvv7/jBrISWkEEoJtiAGYiEiytuVE9JnTNnApQQuPZIdxl6Nt0QxD3zu 9YeXGD0G1cTfUH2WD4XQJsktmV6YbLc2IniJllgSzXbJJuwJ2SBDWYW2Kaee8h3+qRchGSfFlwBZc WcDYG2s+P+wqgbj4dwCDq//i6WIy1LcNKopJfu/OqJ0Rd6BWyjaWhpVZE+Z9xFuY88sjOeojyuR7q nuISYHobJEJZfAmPTZiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM91x-0060hm-AY; Mon, 21 Feb 2022 13:47:09 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM8Wh-005qC1-BF; Mon, 21 Feb 2022 13:14:53 +0000 X-UUID: b592b8f3e00d42889ca19ee518c6d0d4-20220221 X-UUID: b592b8f3e00d42889ca19ee518c6d0d4-20220221 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 768080413; Mon, 21 Feb 2022 06:14:47 -0700 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Feb 2022 05:05:46 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Feb 2022 21:05:39 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 21 Feb 2022 21:05:39 +0800 Message-ID: <8a3a6167450bdd51bdff2e9b12a15522a18dd38e.camel@mediatek.com> Subject: Re: [PATCH v2 09/23] arm64: dts: mt8192: Add infracfg_rst node From: allen-kh.cheng To: AngeloGioacchino Del Regno , Matthias Brugger , Rob Herring , --to=Krzysztof Kozlowski CC: , , , , , Chen-Yu Tsai , Ryder Lee Date: Mon, 21 Feb 2022 21:05:38 +0800 In-Reply-To: References: <20220218091633.9368-1-allen-kh.cheng@mediatek.com> <20220218091633.9368-10-allen-kh.cheng@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_051451_504973_AE8B002A X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-02-18 at 13:55 +0100, AngeloGioacchino Del Regno wrote: > Il 18/02/22 10:16, Allen-KH Cheng ha scritto: > > add infracfg_rst node for mt8192 SoC. > > > > Signed-off-by: Allen-KH Cheng > > For v3, please mention that you're adding simple-mfd to allow probing > the > ti,syscon-reset node. > > After the commit description fix: > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > Hi Angelo, Thanks for reminding, I will update commit message. Do I need to also change the commit title ? Best regards, Allen > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 18 ++++++++++++++++-- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > index f93fe3779161..a935a22babbb 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > > > / { > > compatible = "mediatek,mt8192"; > > @@ -267,10 +268,23 @@ > > #clock-cells = <1>; > > }; > > > > - infracfg: syscon@10001000 { > > - compatible = "mediatek,mt8192-infracfg", > > "syscon"; > > + infracfg: infracfg@10001000 { > > + compatible = "mediatek,mt8192-infracfg", > > "syscon", "simple-mfd"; > > reg = <0 0x10001000 0 0x1000>; > > #clock-cells = <1>; > > + > > + infracfg_rst: reset-controller { > > + compatible = "ti,syscon-reset"; > > + #reset-cells = <1>; > > + > > + ti,reset-bits = < > > + 0x120 0 0x124 0 0 0 (ASSERT_SET > > | DEASSERT_SET | STATUS_NONE) /* 0: lvts_ap */ > > + 0x730 12 0x734 12 0 0 (AS > > SERT_SET | DEASSERT_SET | STATUS_NONE) /* 1: lvts_mcu */ > > + 0x140 15 0x144 15 0 0 (AS > > SERT_SET | DEASSERT_SET | STATUS_NONE) /* 2: pcie phy */ > > + 0x730 1 0x734 1 0 0 (ASSERT_SET > > | DEASSERT_SET | STATUS_NONE) /* 3: pcie top */ > > + 0x150 5 0x154 5 0 0 (ASSERT_SET > > | DEASSERT_SET | STATUS_NONE) /* 4: svs */ > > + >; > > + }; > > }; > > > > pericfg: syscon@10003000 { > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel