From: <Claudiu.Beznea@microchip.com>
To: <ilpo.jarvinen@linux.intel.com>, <linux-serial@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
<richard.genoud@gmail.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 11/44] serial: atmel: Use uart_xmit_advance()
Date: Thu, 20 Oct 2022 09:01:29 +0000 [thread overview]
Message-ID: <8a47af92-98eb-b2cf-c022-1a1987ff8449@microchip.com> (raw)
In-Reply-To: <20221019091151.6692-12-ilpo.jarvinen@linux.intel.com>
On 19.10.2022 12:11, Ilpo Järvinen wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/tty/serial/atmel_serial.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index bd07f79a2df9..4485f2d26b77 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -875,10 +875,7 @@ static void atmel_complete_tx_dma(void *arg)
>
> if (chan)
> dmaengine_terminate_all(chan);
> - xmit->tail += atmel_port->tx_len;
> - xmit->tail &= UART_XMIT_SIZE - 1;
> -
> - port->icount.tx += atmel_port->tx_len;
> + uart_xmit_advance(port, atmel_port->tx_len);
>
> spin_lock_irq(&atmel_port->lock_tx);
> async_tx_ack(atmel_port->desc_tx);
> @@ -1471,11 +1468,7 @@ static void atmel_tx_pdc(struct uart_port *port)
> /* nothing left to transmit? */
> if (atmel_uart_readl(port, ATMEL_PDC_TCR))
> return;
> -
> - xmit->tail += pdc->ofs;
> - xmit->tail &= UART_XMIT_SIZE - 1;
> -
> - port->icount.tx += pdc->ofs;
> + uart_xmit_advance(port, pdc->ofs);
> pdc->ofs = 0;
>
> /* more to transmit - setup next transfer */
> --
> 2.30.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-20 9:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com>
2022-10-19 9:11 ` [PATCH 11/44] serial: atmel: Use uart_xmit_advance() Ilpo Järvinen
2022-10-20 9:01 ` Claudiu.Beznea [this message]
2022-10-20 13:06 ` Richard Genoud
2022-10-19 9:11 ` [PATCH 12/44] serial: clps711x: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 14/44] serial: digicolor: " Ilpo Järvinen
2022-10-19 11:30 ` Baruch Siach
2022-10-19 9:11 ` [PATCH 17/44] serial: imx: " Ilpo Järvinen
2022-10-19 13:14 ` Uwe Kleine-König
2022-10-19 9:11 ` [PATCH 22/44] serial: meson: " Ilpo Järvinen
2022-10-19 9:36 ` Neil Armstrong
2022-10-19 20:42 ` Martin Blumenstingl
2022-10-19 9:11 ` [PATCH 23/44] serial: milbeaut_usio: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 27/44] serial: rda: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 28/44] serial: samsung_tty: " Ilpo Järvinen
2022-10-21 11:48 ` Sam Protsenko
2022-10-19 9:11 ` [PATCH 34/44] serial: stm32: " Ilpo Järvinen
2022-10-19 9:11 ` [PATCH 43/44] serial: xuartps: " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a47af92-98eb-b2cf-c022-1a1987ff8449@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).