From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A83C433E0 for ; Wed, 27 Jan 2021 18:25:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05F0C64DA5 for ; Wed, 27 Jan 2021 18:25:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05F0C64DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J3NhIJ3YMhl2Z8/ijtiGhOtpvMi5fY1enhZC4eP+rr4=; b=VV9KXWdGg3r51OJ2MgymRkv5z Lz+Mbe16+2cbAia39qn5SyyxOyh7pvtWk8EM9hG4T8l0DEy3WVA45srkrQeZBn5bmKyhd3SB8Ih7Y 7D+FAjTY2uivXDd/uU2Kn3txG24jGdS7tAitZrrbiTMpA25gLfK9Q0NwCbFZxQyN8f1uhau/sIod9 ZXBVQLsbcVRJ+AJ0j9+//4gmYtpgMAnrWRjFCW3x35uRvEmnNIi2y2edHDBsyaurJ8uiiDMwMvy8P MXPWxpT978XDkg7n95I7ijIBe8c7vuSdhlE2ZtAECbsU4AIc7zAbWZ53v09kp9ZbfM0hXLWwEbbj0 iuxbQWcmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4pUR-0001cH-Q4; Wed, 27 Jan 2021 18:24:27 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4pUP-0001bT-0E for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 18:24:26 +0000 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 3152F20B7192; Wed, 27 Jan 2021 10:24:23 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3152F20B7192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1611771863; bh=yMsCPY9XGQhd0IkZadoqcZI8Fan9kErVPg16P1Bza9c=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=DLR0wWGtBDT3ah9ZQoQ7NylT0X7gOM7UFlzzCZuLcuhEGg2dZBS9OErvr4SUQP8Zy /vNAhU0Nn/Ivm4V7NSPMF8xIVHOUWLplqvbfFVzKaEX18VP/abE6QeL9tVwo5VcJNb Jsl+yLZkqshu27jamrru/rzalisWZnxQ6eoWzTrI= Subject: Re: [PATCH v15 10/10] arm64: Add IMA log information in kimage used for kexec To: Will Deacon References: <20210115173017.30617-1-nramas@linux.microsoft.com> <20210115173017.30617-11-nramas@linux.microsoft.com> <20210127165424.GB358@willie-the-truck> <20210127180230.GA593@willie-the-truck> From: Lakshmi Ramasubramanian Message-ID: <8a573f84-732a-3591-8751-f7b08edaa01d@linux.microsoft.com> Date: Wed, 27 Jan 2021 10:24:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210127180230.GA593@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_132425_198052_9B270E6D X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, frowand.list@gmail.com, sashal@kernel.org, mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, prsriva@linux.microsoft.com, hsinyi@chromium.org, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, james.morse@arm.com, gregkh@linuxfoundation.org, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/27/21 10:02 AM, Will Deacon wrote: > On Wed, Jan 27, 2021 at 09:56:53AM -0800, Lakshmi Ramasubramanian wrote: >> On 1/27/21 8:54 AM, Will Deacon wrote: >>> On Fri, Jan 15, 2021 at 09:30:17AM -0800, Lakshmi Ramasubramanian wrote: >>>> Address and size of the buffer containing the IMA measurement log need >>>> to be passed from the current kernel to the next kernel on kexec. >>>> >>>> Add address and size fields to "struct kimage_arch" for ARM64 platform >>>> to hold the address and size of the IMA measurement log buffer. >>>> >>>> Update CONFIG_KEXEC_FILE to select CONFIG_HAVE_IMA_KEXEC, if CONFIG_IMA >>>> is enabled, to indicate that the IMA measurement log information is >>>> present in the device tree for ARM64. >>>> >>>> Co-developed-by: Prakhar Srivastava >>>> Signed-off-by: Prakhar Srivastava >>>> Signed-off-by: Lakshmi Ramasubramanian >>>> Reviewed-by: Thiago Jung Bauermann >>>> --- >>>> arch/arm64/Kconfig | 1 + >>>> arch/arm64/include/asm/kexec.h | 5 +++++ >>>> 2 files changed, 6 insertions(+) >>>> >>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>>> index 1d466addb078..ea7f7fe3dccd 100644 >>>> --- a/arch/arm64/Kconfig >>>> +++ b/arch/arm64/Kconfig >>>> @@ -1094,6 +1094,7 @@ config KEXEC >>>> config KEXEC_FILE >>>> bool "kexec file based system call" >>>> select KEXEC_CORE >>>> + select HAVE_IMA_KEXEC if IMA >>>> help >>>> This is new version of kexec system call. This system call is >>>> file based and takes file descriptors as system call argument >>>> diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h >>>> index d24b527e8c00..2bd19ccb6c43 100644 >>>> --- a/arch/arm64/include/asm/kexec.h >>>> +++ b/arch/arm64/include/asm/kexec.h >>>> @@ -100,6 +100,11 @@ struct kimage_arch { >>>> void *elf_headers; >>>> unsigned long elf_headers_mem; >>>> unsigned long elf_headers_sz; >>>> + >>>> +#ifdef CONFIG_IMA_KEXEC >>>> + phys_addr_t ima_buffer_addr; >>>> + size_t ima_buffer_size; >>>> +#endif >>> >>> Why do these need to be in the arch structure instead of 'struct kimage'? >>> >> >> Currently, only powerpc and, with this patch set, arm64 have support for >> carrying forward IMA measurement list across kexec system call. The above >> fields are used for tracking IMA measurement list. >> >> Do you see a reason to move these fields to "struct kimage"? > > If they're gated on CONFIG_IMA_KEXEC, then it seems harmless for them to > be added to the shared structure. Or are you saying that there are > architectures which have CONFIG_IMA_KEXEC but do not want these fields? > As far as I know, there are no other architectures that define CONFIG_IMA_KEXEC, but do not use these fields. Mimi - please correct me if I am wrong. thanks, -lakshmi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel