From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1614DC433FE for ; Wed, 23 Nov 2022 07:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aL6CJyFziLA4F29Nid6wnZ0t7WL+Gw6eKiLGJ24DoOY=; b=WmBqI9w232p+h+ 5WQD8fv9H1AqlOeKq22hd1vZVQvKwOq+J6dreNknYMrNgXBc1x83EYbgmJHZywc1xV4nctdf6TV+8 bGpCV+9MPS+Y+0otM9yzn4Ju2MMSGij/wMijNHTINXdaGIFJsX6Lk5dGWnqz4XiWWam4vS/7hYbg3 grufYCOCFqZNQafx7tmAul2N/KuvSWpIZ3boQTb8ZIZyAmT1RngVYHbTEMXGGzIKyMjXBZ8s/J2sl 2khEM8Eeruh97tiWDDNqEVqwbbyF03EvixDaOEJedDKxdpJh3kvDX0uajGa4PpFvsVjtAjnfZuQTZ 2eMm+WNpq6OGic/Eps9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxkeX-00FO6O-G8; Wed, 23 Nov 2022 07:58:41 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxkeU-00FO4Q-4B for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2022 07:58:39 +0000 Received: by mail-lf1-x12d.google.com with SMTP id g7so27030394lfv.5 for ; Tue, 22 Nov 2022 23:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eIg6Rv/LOFpgj+DKWMManbiu0MfbC5FGq/xuxr/n0/w=; b=O/38mHTk0CPM9pVVyRJOWrliNAFqF+1lUR9wj+BJJ1xjTUPpFWP1swpYrwoKOYsG6+ Wfno/8Y3RM2L3GU+fe0tExQzuXxi8ipqkzqI0iQD9nWP6U1VGXFOcOJ/UOHKPiidllZy DcXABk/ZIwhEQa9nyEy6G8U9Nh9svKgwgzpUYO+jRw9R89uM8QgNKSQdVcUfRg8cKpDR gIcHpd0XsFyAegMNut9QdiLn63gxpiE35ob4bBrcJGsO2pVYcJmqgygVoH0KxDLZoHlA T0Yqr1ladsKpyLswJzbtX+2NSnYtVZqJTzbUf9dk7jtvKz4dfAdG6hSvlFZFIBgV1J+Y tZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eIg6Rv/LOFpgj+DKWMManbiu0MfbC5FGq/xuxr/n0/w=; b=2IIASEnn85jJBLzcB/enKxpobSD8TQxTQu+8EHoRns/ROCBn/n41+mactbKnU2Mn+X c3Wm+DkKcWCydZvrYe9KFU5AIQKlu/5/yA3R33kdETdcpdZv/e97t1+wA8drP+LOH+3n mfHal/6ULfmnLWSBzadlFz55rOUayoF4rd1fvxeF0KyqZtfpOEF6cV8Pb/Ytubv3bmm7 Uk4jJWBJILZBiikNaoyUtqONhbNJ5pw7jViHZ/c0DvnUhsgU/pU3Wv91liUmyRAJVZFp gnYIyAP3Knf+2PpMDhXK8FdKmDZPOrdRUvj3dybYuz8A1u+JFXoq1F8bGI0G2DZD/rc7 fn0Q== X-Gm-Message-State: ANoB5pligqhfICQH1WvK8AxCI3THfZDSmxPcNUtEy5BbCfF+jGfS5Los pQZMUg4hHAKcI3/F6TPnuxoADA== X-Google-Smtp-Source: AA0mqf6zL4R+GgorjVgH9PoP2t6OY5S6qEA+2L8rRG2kN5zlZUkPGnPJ6ancNeSRmy+Dl5f5mxbA9Q== X-Received: by 2002:a05:6512:3ba6:b0:4a2:2bd7:d4fd with SMTP id g38-20020a0565123ba600b004a22bd7d4fdmr3599654lfv.613.1669190315409; Tue, 22 Nov 2022 23:58:35 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id y18-20020a05651c107200b0027741daec09sm1997549ljm.107.2022.11.22.23.58.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 23:58:34 -0800 (PST) Message-ID: <8a67f8a5-0e79-45ed-3bad-0678d15910c5@linaro.org> Date: Wed, 23 Nov 2022 08:58:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/4] dt-bindings: mfd: nxp,bbnsm: Add binding for nxp bbnsm To: Jacky Bai , "lee@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "dmitry.torokhov@gmail.com" , "a.zummo@towertech.it" , "alexandre.belloni@bootlin.com" Cc: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-input@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "kernel@pengutronix.de" , dl-linux-imx , "festevam@gmail.com" References: <20221121065144.3667658-1-ping.bai@nxp.com> <20221121065144.3667658-2-ping.bai@nxp.com> <2aeb0590-4fd0-5bb4-5e68-0378953a94c3@linaro.org> <6bb1ee6d-ab8c-824c-4a7d-29769189e4b4@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_235838_200803_E07A99C6 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/11/2022 08:43, Jacky Bai wrote: >> Subject: Re: [PATCH 1/4] dt-bindings: mfd: nxp,bbnsm: Add binding for nxp >> bbnsm >> >> On 21/11/2022 11:26, Jacky Bai wrote: >>>> Subject: Re: [PATCH 1/4] dt-bindings: mfd: nxp,bbnsm: Add binding for >>>> nxp bbnsm >>>> >>>> On 21/11/2022 07:51, Jacky Bai wrote: >>>>> Add binding for NXP BBNSM(Battery-Backed Non-Secure Module). >>>>> >>>>> Signed-off-by: Jacky Bai >>>>> --- >>> >>> ... >>> >>>>> + >>>>> + properties: >>>>> + compatible: >>>>> + const: nxp,bbnsm-rtc >>>> >>>> >>>> Missing ref to rtc.yaml. >>> >>> Ok will include in v2. >>>> >>>>> + >>>>> + regmap: >>>> >>>> Use vendor prefix, descriptive name and description. Where is the >>>> type of 'regmap' defined? >>> >>> Type is missed. Will add a description and type define if necessary. >>> >>>> >>>>> + maxItems: 1 >>>> >>>> I don't think this is correct. Rob explained the simple-mfd means >>>> children >>> do >>>> not depend on anything from the parent, but taking a regmap from its >>> parent >>>> contradicts it. >>> >>> For this BBNSM module, basically, it provides two sperate & different >>> function: RTC and ON/OFF button control. But no separate register >>> offset range for each of these functions. For example, the interrupt >>> enable control, Interrupt status and basic function control are mixed >>> in the same registers' >>> different bit. >>> >>> Any good suggestion on how to handle such case? ^_^ >> >> The solution for more complex common parts, dedicated device driver (MFD >> driver) with its own binding. However I understand why it would be overshoot >> here. >> > > Is it ok to keep current implementation rather than reimplement a new dedicate MFD wrapper driver? Yes Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel