From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F2B1C54E64 for ; Sat, 23 Mar 2024 03:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d8jdkvNniJeaBu0J+DH3Wui3+8XDFVynkTK0osAC6yA=; b=Nqd5RFGCO9ibmJ bI1dTkHbenQrzy6oo4ZFrey+djU76goKURtyPDftTGkvL9ypwI7CbI+81QfgfXhwCLLD3U35VUePK 2/lO9blZM0w6OdOPPTq/AL55BCxZXyENWKOVWR4h3y7sbsI0WK4f37qFqDeIMbLXN7VHTn075nZNX H990vLLX9tB43Bo6I+TKFi6IcJk3BuEr4MC5MQczmGf2ERAZk5Iy006Bb90Nr4bgwOSF3Sleq88S+ 3oHbM8K5GpSz/xGQg7aOwDTGRbZoP1yTYEGKbxZyUX6/CNvUF9tSmml8M9NtXNzKpwylHPV4Y5oqF TT3uYurhCzgrDSTiEsxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnrc6-00000009IWf-1NA7; Sat, 23 Mar 2024 03:00:06 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnrc3-00000009IUs-1VNK; Sat, 23 Mar 2024 03:00:04 +0000 X-UUID: 6d7ac882e8c111ee9aa9374d6d45775a-20240322 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=3RbGqczdB5XQ6jfmBB7St2g7YSNFwgPJ+rTGkf8I4e8=; b=nczgUXYeSzmDtBveVwij3DRdJHJqsu6br7XTnqQVAE9nzS4+rIasepN7htGeBI++muYBmom+375xu9NqqMipxB4mF5cZ6i14h43ibFq7fjA4n3NLaRJnQtGpzRby2upsqxjr7BAAy6Z2FeXZRAXpvP2KbE1TT75rQ5YZXyf2IcU=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:93787eb4-4984-4483-87bd-00566f7b10b1,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6f543d0,CLOUDID:8192d481-4f93-4875-95e7-8c66ea833d57,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 6d7ac882e8c111ee9aa9374d6d45775a-20240322 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 150374602; Fri, 22 Mar 2024 19:59:55 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Sat, 23 Mar 2024 10:59:21 +0800 Received: from SG2PR03CU006.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Sat, 23 Mar 2024 10:59:21 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A4xU/EufbGBvyxsviQPglidrA4GnocXbbqzyAOFTzBe2RWso5bQ3p97uYhJ3VtAHapm86ZqwhkwyMl74dqmoa87piwMrllzW6k4DKX/B0fizFJxPsbWXq5GqAlzCDOjfGo930uaIu9CEUtAHVIEAgZ+eY6+BPmjrPLzHdc1IVaMf2VWKVGeczxWfOTAarkTFWUxQQhGginGp4KnFduvDNdJF6yiubYdaTWWVpF6Luy45CHHmCRrCsE//psaS1jQXGY/1V81ghSgpet+EPOddh2LzsK40iT0lAgxiM+s4JGnkt6i75vvYuIW9aimgCo86NhEpOd3HK0q6vOWV4IKNiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3RbGqczdB5XQ6jfmBB7St2g7YSNFwgPJ+rTGkf8I4e8=; b=fj7RzmKn7LLYAaXGOK8NmpbENXvT1UZjifAT84W+K4KQfhApzdsR8Ef7FCUlfxF5S8xY6wnx55PRn3hzqfE069SnWQli9eKDbBR9LDIUEY2OgmQOYclV0WhxxrRMvo8+7ADCUqtbKiHrbSbklPbYAq2R8KmNJciolNdXX26R2f3JdfBNn+jf0MWbylD8Hj0J77lJiZYwXLvz0VkXyr1JYgSFC0LEm2rDXLRo2coQXNksrDbx4C7cysXGAvdxH6ESa9m9t0JIWvSCK0XTFuZepSVozzk5X4SWCH/xy4tmMaf51efQo/FA+qGu4RmpVbdkwbZhWh5hyZSE6TspK3LDdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3RbGqczdB5XQ6jfmBB7St2g7YSNFwgPJ+rTGkf8I4e8=; b=uPLHLA2OFvI3QRR7bSDqPEl/jtNW3MHdy/57nhQi22fvy53Mai1lWAd15jXJ6nkO4GfMRlgiQVwF/BTZBD8qChqb7GCMPYVk72625kHQ40E84hu7YsJqyjOpnvBQ7BnVS4Rr3XtS3X3PMzqs6tB9yL7OCHU5LMGu4mp+S4/juRI= Received: from TYZPR03MB5566.apcprd03.prod.outlook.com (2603:1096:400:53::7) by TY0PR03MB8297.apcprd03.prod.outlook.com (2603:1096:405:11::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.35; Sat, 23 Mar 2024 02:59:18 +0000 Received: from TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::b39a:4ac4:5bf8:88d]) by TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::b39a:4ac4:5bf8:88d%5]) with mapi id 15.20.7409.023; Sat, 23 Mar 2024 02:59:18 +0000 From: =?utf-8?B?WmhpIE1hbyAo5q+b5pm6KQ==?= To: "sakari.ailus@linux.intel.com" CC: "heiko@sntech.de" , "gerald.loacker@wolfvision.net" , "robh+dt@kernel.org" , "yunkec@chromium.org" , "linux-kernel@vger.kernel.org" , "dan.scally@ideasonboard.com" , "linux-media@vger.kernel.org" , =?utf-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , "hdegoede@redhat.com" , "linus.walleij@linaro.org" , "andy.shevchenko@gmail.com" , =?utf-8?B?WWF5YSBDaGFuZyAo5by16ZuF5riFKQ==?= , "mchehab@kernel.org" , "jacopo.mondi@ideasonboard.com" , "jernej.skrabec@gmail.com" , "linux-mediatek@lists.infradead.org" , "bingbu.cao@intel.com" , Project_Global_Chrome_Upstream_Group , "conor+dt@kernel.org" , "10572168@qq.com" <10572168@qq.com>, "hverkuil-cisco@xs4all.nl" , "tomi.valkeinen@ideasonboard.com" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "laurent.pinchart@ideasonboard.com" , "devicetree@vger.kernel.org" , "angelogioacchino.delregno@collabora.com" , "macromorgan@hotmail.com" Subject: Re: [PATCH v1 2/2] media: i2c: Add GC05A2 image sensor driver Thread-Topic: [PATCH v1 2/2] media: i2c: Add GC05A2 image sensor driver Thread-Index: AQHad00+IqkBATFIkUCM1xUJwrGHMrFAQfSAgARroYA= Date: Sat, 23 Mar 2024 02:59:18 +0000 Message-ID: <8a6bbbdde57283b5bf8cab0ea7ecb0f201d437e7.camel@mediatek.com> References: <20240316025253.2300-1-zhi.mao@mediatek.com> <20240316025253.2300-3-zhi.mao@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB5566:EE_|TY0PR03MB8297:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fd9sqxeOwrkptuiFb6iUzuzVoQwLZvbqXTh8UpABznnbaV6qF/+9rPNDIoH9/9C1oRM+siG/E707GcZ7MeeUVFWJiPg+EAPlmvDXHxtCMGaKICPQbhkWtj2Ic5TcCM+LvmR53pKMA63yPDlHiDvu1HV3S8i27EXNuNdLA1mKGMJVdQdRhfU1IqE3pbbHTtuLmt8SUjjsToF96O3NWNiycWG10qkLkRE7+qcK8jr+Gj/p7lCkb7mhRdTbYi4PlUzu0tXT2sg3pMBgsLHAwZwHiEKdo9Tcc51MzSvovjOf2OPtHY1yxnRiv1pLV0rWAVRhMRD9f4qJQ+bWUt3Rkc56BeNwz9oUt6s/irescm2gATeZRZmEkdB8Y/of1NAGc+LI0dV3gmb1O79+6LcE/wPtA231APgk1O9T4tT5XHdSyrEfkQCd82Whd+9NwDT8JjtTySmeIpF4bruxvYkGs77yeJIfy/pQavL4u/pSRXBwBWdtiOz3a93uoqCm3VYXp3+SYTSEbC1NFi4JQE50FlaWWg1PSYamyZKdfKQchxJIYh263+hTASKHCi4HkW+te/7YTOlUdiq9rl1YV7i7ldJnhU2lF3FLFnwOldQmLnHUVZj9s5SgwmvOja3eiUQcI8iL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB5566.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(1800799015)(376005)(366007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eC9sYkNDV2VMWXM3OEtIMFNjN3I2dTR0UTZuZERveVpnM3o4ZGpBMjB5a2Q1?= =?utf-8?B?RFIxazdqRDZ4QTFmWjFOTFQ4azExUFlPN1Y5cituUkVlalUzV1l5bkVJWTZY?= =?utf-8?B?aTVrRjhYaGpPVXJPYnFzZS81aWRaUVZCMGtaaEt6VWp6cGdrUXVmQkFVUzlK?= =?utf-8?B?QXhSVitHN2FZOGE1UzNSRHhwNmxQc0hHNGVocGphM1l5WUJSUEZ6MjJYUnk5?= =?utf-8?B?TVJvVUxmKy83Z1BtVEVZTTdBakoxVlVHbG5lY3VDN0EybytiRzYxWE9CeTdW?= =?utf-8?B?QzFyeVNCbUN3b1M0NzBDR1JuM0NKeTVLbkpSYXJSanpvTi9TTE9ZaDhHZEhF?= =?utf-8?B?UGlMYlZCOGJEeFhNdGdYWFZhMnd1VHFwREkzWEFMV21GQTBQamhWYkR4V2tl?= =?utf-8?B?cDdMdEFya25KdHRFbEc0QmxoUmJrV1FJbWVJQ2c1UGNVNXBBOVNJeHFqaTVw?= =?utf-8?B?MERvVCtZcXdnTGJpamlhdGkwdzF3MU5sdWhXcSsvOTJGNnp6N0VDUHpTb0pK?= =?utf-8?B?Ni9CN1QrdWxrc2QvT0dhOWhLeFpiVmo2alRsWkJQK2ZGd0pHT1NTbGUydXFu?= =?utf-8?B?WUlSNEtVWnBCeU5yVjU1d0NNK050OUZjb2FEeDFxenFUY0gzU204cmJiUXVl?= =?utf-8?B?L0pzMldRQzJLRnd5S3lsNWRVNDJIZEJobDB0bFpieklwOG5VcDMrWERZUWpp?= =?utf-8?B?ZjIzL2xXYlA5aHpLcXRMUFRrS3pacXFzeEp4ZFlaOWcySStVbjB0MVgvWk12?= =?utf-8?B?RHZSamlNaFRlZXY2N1lQTHF6V3ZLdHFHdGJGWlUrcHZ0MmxjS205T0YzUCtU?= =?utf-8?B?V0JKbUM2MVNoYWFwN05hNFhYUmpaYTV6aDNxaS9NWG5NbmNRQm82L3o0WVJn?= =?utf-8?B?dUlHNlVRTDMxU2dhRTk3ME5UbDg2L0VrY0FtU3hMRkFMNk1TWUxTREU2bGg1?= =?utf-8?B?T2I1cWUzSHFwRkErcndad3NDR3o3NkJJbGNaYmlYNnExVWdSemUvK05WdlVV?= =?utf-8?B?RXE0eG1FMUJNbnBCV3Q3VW9XMTFENk81OCtkQXVnY3p1R1RzdGhNMG15OWRV?= =?utf-8?B?dk9hTThNc0V2TTk0dHRROWpFdk1xQytzWGl5eCtHcU9SUS9YcGRTKzM0S3dY?= =?utf-8?B?QnNYNGhMNlBJRnVCbFFXckdzMitOL0QzL0t2dm1DL0dtRlRPNW94eGhwMlZK?= =?utf-8?B?SlkwOTFsa1c4U2FCcWhkSU14QVNEeXJoOVRYaWp2Q1paQk5QV2tBL3JOSTNM?= =?utf-8?B?RDdwM0pCYmw4T3VKTnplYTh6azY4Sm9SVnlPeHV1clVQMjEzNlRkNnl1K2cv?= =?utf-8?B?a2MvbHBzTDBuNFpmRHJyTVA0YzY2dHJnQUF2NjBaZDVRN1JPV3dTdUdFQ2V5?= =?utf-8?B?c1BPQ1lsSXp0eVRUaEp6SDM4L3UxWk9qYWI2VVRxWHJGVHpFa3oyckRLd2xV?= =?utf-8?B?VC9hV3ZmMTFDbGc1UmthR0NqL3BobDM4RzJLRXdrdDJsVCtiaXBQZzFFTzVJ?= =?utf-8?B?U2RuNU44Yk8rZEU0VXFIMHRZTVlxbm1sdTQzc2p5WHloT1FnYUk2TkZ3VEJY?= =?utf-8?B?R0dIc1c3WHI0RmZ3YVFpYjFpSTZtQzBEaHdNOEdlMmNVcEo5VHNRQmdvYytV?= =?utf-8?B?aTBSWDR5Z2ZaUlMyV0NiTURSRGovTW8zZnY1aGJmTFIwZnRFY2liMlF0VzI3?= =?utf-8?B?QjFSTHdnZDdOVjlmQzQ3M0k3K0hieS9ydEMzQ3JHci9FbHIyYTNxTzc5a2JU?= =?utf-8?B?SlAyYnNGWFRsTU1BY1NhbEx5UjNMSklaVC85dlp2NjBWTjlPcGpOYUpCa1NP?= =?utf-8?B?SWd0bERZb1plUW90Mk42LzdXTG9mcEJ1M00zdjUxbGEwVCtGemVQdVk1NmZG?= =?utf-8?B?UHlTbjFrU1dBM2c3ZElnWm15LzA1Ky9mUUEyanFZWkpwZlQrUU50SStEc3NQ?= =?utf-8?B?YjY2MUFndmNFV2JTUDk0NlA3WDFoNEM0dFRTWUYvcjBNYXdleEorMlNzNG94?= =?utf-8?B?ZXUzRWlvMUptV29rUTRsUlZmOFRua2RwZFZsbTcvTkFOT0pwNDYyN0NvREdo?= =?utf-8?B?dHdqcEc0NTRpNDVBZk9wYnBqdEkwWjRyM2RveFVaa04xSkx4V2E2cm5UdTFQ?= =?utf-8?B?ZDFrNFdCckZ6QTdlWjVjR0syejNSZ3dIekp0M2g2c2FMMHpLeEtrMnZRN0RV?= =?utf-8?B?NFE9PQ==?= Content-ID: <97D4F5B358CBFE479AE355E6433E173C@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB5566.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4135597d-19a3-415c-ccd2-08dc4ae53b8e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2024 02:59:18.6646 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f7V7kTXP44AnjjMbv8DFLL76urlj5GprazZGrpER6a9bpTvTGtglyUjA4UI/gdeXlLoCGql/cYXm/ByOnxCG4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB8297 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_200003_419946_19F18582 X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, Thanks for your review. On Wed, 2024-03-20 at 07:29 +0000, Sakari Ailus wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Hi Zhi, > > Thanks for the set. > > On Sat, Mar 16, 2024 at 10:52:53AM +0800, Zhi Mao wrote: > > +static int gc05a2_set_ctrl(struct v4l2_ctrl *ctrl) > > +{ > > +struct gc05a2 *gc05a2 = > > +container_of(ctrl->handler, struct gc05a2, ctrls); > > +int ret = 0; > > +s64 exposure_max; > > +struct v4l2_subdev_state *state; > > +const struct v4l2_mbus_framefmt *format; > > + > > +state = v4l2_subdev_get_locked_active_state(&gc05a2->sd); > > +format = v4l2_subdev_state_get_format(state, 0); > > + > > +if (ctrl->id == V4L2_CID_VBLANK) { > > +/* Update max exposure while meeting expected vblanking */ > > +exposure_max = format->height + ctrl->val - GC05A2_EXP_MARGIN; > > +__v4l2_ctrl_modify_range(gc05a2->exposure, > > + gc05a2->exposure->minimum, > > + exposure_max, gc05a2->exposure->step, > > + exposure_max); > > +} > > + > > +/* > > + * Applying V4L2 control value only happens > > + * when power is on for streaming. > > + */ > > +if (!pm_runtime_get_if_in_use(gc05a2->dev)) > > This should be pm_runtime_get_if_active(). Please assume it takes a > single > argument (the device)---see commit > c0ef3df8dbaef51ee4cfd58a471adf2eaee6f6b3. > > The same comment applies to the GC08A3 if it uses autosuspend, please > post > a new patch for that. > fixed, patch as below: gc05a patch:v2 https://lore.kernel.org/linux-media/20240323014751.4989-1-zhi.mao@mediatek.com/ gc08a patch:v8 https://lore.kernel.org/linux-media/20240323023851.5503-1-zhi.mao@mediatek.com/ > -- > Kind regards, > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel