From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A12C4360F for ; Wed, 3 Apr 2019 01:11:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5324920830 for ; Wed, 3 Apr 2019 01:11:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rxmyzAtp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="TE4RKdrZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5324920830 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8nnPbr2DM3L3rkwNtTUg1xekkqYbNEBKSr6Llg9tZ/0=; b=rxmyzAtpmZwI3s icXi7MUFFnxjZZcShY586rMv/+59C5qyh7vt2xFsHlGQ+iqDcWdOqfykOrvf9HcqokFZ1OVavlhct mPphs1KaqJPnLeEVmH4PdEX0D6t0Ac0aNPD3xl4613d1awLF5LGMzxaYlForgDCTRSjqxePMarpyB g9YMIrhYhdjSogN2kCL+bsWrHJ4+C2Zv8cDzLgwo82Vaezz15gFPa/xVrO0Sx7Ilv3dcxjbRADThZ aMfkz6RCds0dp1Hwtlv8hpkK/mjylWSNf8NMoSs0sZBlqooUtJLFw89BohVzZJgoWAuZM/0jTm2aM ot1xKNOnuxyAyYxK1OWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBUQp-0006DT-17; Wed, 03 Apr 2019 01:11:11 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBUQk-0006Cx-Kk for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 01:11:08 +0000 Received: by mail-pg1-x543.google.com with SMTP id k19so744489pgh.0 for ; Tue, 02 Apr 2019 18:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QEwtYD4al19eJmWhOFuud/x7kSg7UeUaV2GJDzUdjNE=; b=TE4RKdrZtjgSbjw1n4Ul2WCKYOh5d7QTvvpOd/hu71drRWARX94oUj4mI7OBJKbH/u As4XyMltc8TQLwC81RawI1kKZ3zJyRS/UqxBNesY8wmW4EP2NIhfQEVVpRd4bzwcdt0P j7ooTLAOS3tPhkRh5PTShsQ4lNdEzkFtG6ABU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QEwtYD4al19eJmWhOFuud/x7kSg7UeUaV2GJDzUdjNE=; b=C1AOSg6+5Qk4OfqbeEfSxs0l9c7XzwwpvrouauR2ynwVVIIdm4DVmaVrQzOZHfGb2G mlX4H+IDFOZHUs4gLm+DpnbxfNU3U7unsn3XCwu1LnGbGC5zvUmJ96f62lPlEabZsJ3P WfT8R0W1elzVxj23vi1laBCv4cl4wLwxX9k+KMoxhozc+9EdSImzdigm4IFyAgXsxKOM Jz9yAKk53nrwKz11adO3pXDbspp30EpTKaCg7JLCpf5wyaIYZZ5I6SzGAYfo0PKtUhBD C1Q2jQ2hRpENECrG1FqLCezAZoaLkV8yKyzGYMCTuJu1pWzaizSf74y/mA4HhkaY8iG5 iOew== X-Gm-Message-State: APjAAAWqJ6v0vgBqZYCTvQ/jmv7+dLKHdN+WVzHbugxEi+CxMfxCn+st BDBmcQ/uRIE+b1ndpli0XivfEQ== X-Google-Smtp-Source: APXvYqwWrNkPQIGtGGR1oZaq9SQJ/P8eaERH2hWL45QQ9y9fVi+m0CUP1kjiO3V+fXyoR/3OwjKCsA== X-Received: by 2002:a63:2747:: with SMTP id n68mr69021688pgn.317.1554253863796; Tue, 02 Apr 2019 18:11:03 -0700 (PDT) Received: from [10.136.8.252] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id e1sm16507968pfn.187.2019.04.02.18.11.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 18:11:02 -0700 (PDT) Subject: Re: [PATCH v5 7/8] i2c: iproc: add NIC I2C support From: Ray Jui To: Wolfram Sang References: <20190214175725.60462-1-ray.jui@broadcom.com> <20190214175725.60462-8-ray.jui@broadcom.com> <20190402102733.GD2960@kunai> Message-ID: <8a731837-b21b-c2ae-fe0f-3c8943b587e3@broadcom.com> Date: Tue, 2 Apr 2019 18:10:52 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_181106_686164_AE127EF5 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rayagonda Kokatanur , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/2/2019 10:57 AM, Ray Jui wrote: > = > = > On 4/2/2019 3:27 AM, Wolfram Sang wrote: [...] >>> + iproc_i2c->type =3D >>> + (enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev); >> >> No need to cast a void*. >> In fact, we do need to type cast here since 'iproc_i2c->type' is NOT a pointer: drivers/i2c/busses/i2c-bcm-iproc.c:870:18: error: incompatible types when assigning to type =91enum bcm_iproc_i2c_type=92 from type =91const voi= d *=92 iproc_i2c->type =3D of_device_get_match_data(&pdev->dev); ^ > = > Yes will fix. > = > Thanks, > = > Ray > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel