From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E580C433E1 for ; Thu, 23 Jul 2020 07:53:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFEA6206C1 for ; Thu, 23 Jul 2020 07:53:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hwI6HX4a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="BjxurpjB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="VhNb8S9U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFEA6206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dajBWElZdMHyDRrmPQXWmSxfYUXUR/Uk3LtRrAra/dA=; b=hwI6HX4aLOL2+YAXBI4Qe3gfu DKu8c38dfuZuOorx4hC+CJAwtH05jhP7Jgd2q8Xtsv9qqCle3+iA7tqbvvJ7WM5lGsSCzcjsEM7eO 66VBgL8O3igwXHYspxUZOAgSebd5gcTlYmBRCLvNyxU2uJnwApj/13hGFVKcy/ETsR43IMe7kDa6z iAF1tmUIb1l2bIxCschuvJllkTJY2RQ3L3R9bQjTJzJgNbvr9fxFEY1jzvGLHOhBDadJuCf3nDr/8 Yf7gLF6zQ3AtwNdnTSwOzjjuu9NJzgzCETkOabqfcifXaRqRSNgnoI2vxS5M8VFUjnHg0FLOy9yOG bfsQbqaaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyW1L-0004VX-IE; Thu, 23 Jul 2020 07:52:03 +0000 Received: from esa2.microchip.iphmx.com ([68.232.149.84]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyW1D-0004QJ-50 for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 07:51:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595490715; x=1627026715; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=hiuPNBGi4RXNNjGG2ixGTRRVmKDTjodCCcyFSr034T8=; b=BjxurpjBql05nLFbE1mBlM2Vuo0LhGZmOO/0h7KSqydpgol6Yyzex0tX Z0mHN+Bkg/GbBXiCvooepXAde1oQTa2qx1y/rAeVq7mSUDsitLJXvEV++ lmuAdhGlmO6fAlRgMHGTUlH7Ar6xdKKHEE5lciFgIu3DzxTTDNbWTSLW7 QrKX+wYhvbkoQBFa8CBR6SGiPLsj4+fi7sC3w6saW9yYmGdHEEn8OEZGc 90oFHg1mM38f9Y8kzr/4JpMYhSvOTkkV3JnNPbLMVx/NQYV2LDKS8e3+q CniwEKoxYonKeSUzpfl/ZFZDIhlbQ+e1Pg4/O2Dhtk4Kx6hhqNQajx13G Q==; IronPort-SDR: 3sSb+N1kW/HIFdAFPuFvfDFPRzGtFO4vJauphphqqsOx12+UG8JZ7oreuLN0LyTwYoRRLLm5aI oeDidev9WrENzq+qvwMxDmLiS4yBA93vgSC/L8g/Oh10H0Iqj014o05GD2nurikxRUwiv9Tqst 7mjYsj9bdLcvy2Lbj2HbaTAz8EcNa3Mvsbdpa+OImJnrB2vvBYvJUuJq2lYWaQAbYTXjJ4jofH 3aUk8E4QCnr5KcDBwDktzpkwhRt+IJ7JcyUFQXhK6quEj9YMZntJn7AnspgY2wFOwGJwrumP/c Aek= X-IronPort-AV: E=Sophos;i="5.75,385,1589266800"; d="scan'208";a="82939593" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 23 Jul 2020 00:51:51 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Thu, 23 Jul 2020 00:51:51 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Thu, 23 Jul 2020 00:51:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQ5QBpYE7B0PZfnDPjPN9xC9oHP36oyQ5KIa7hJk4pR3ubb6JNKxHBrcjSJFqHEMeY/lMubKrqSqSGyKSI5vmDlW59sJrga/G5qGpz00jJh5GcTdLXMoBH1wFPjyJuz3El9lGVYl7lhIag8SaakmfHV7+SnfNZXykb7skVkBKhwTASO3Nes9GQO+V1KUJpxNp3p33K13pscrr9qdHIygdj+msKd0OJIKO9YNIQ6iso77odHYO1b90HxIScG3CupupsxHXPO3bJuaUgenYD8OMDiYGnk+TngJ/Ee4sKZ6gOZTbV7FLlENh+5S0K0nM8cRSSb8CdoXK33ezDyGnBwWoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hiuPNBGi4RXNNjGG2ixGTRRVmKDTjodCCcyFSr034T8=; b=UuaXMYIcZMjbuHhwCUvsZpXOrTB8fZo/Hmq8yaACGHkpeiJhbvPg90aA2dV7HYNyXnt6dnJazE3B9MsPwTcfP8D4p4gcOoDyVOt1Noh8II9gS5cCjdawEqMUL1FzfvJaCG2MpRDMj0UZ5wbWs/dIwZjMX7jCxoZucWBBQsndGs6PY4ZstnaY5Qx+I7GmGOifaixkxUXrPD90UJVJ9fCUoN0mt+igVGFRrQKd+YtFIKOLTPox3XrP4db+bf1bI66FLGnE9bVndiKmaWNSiNR6VXVmJDfZz/7RVga8P65PkSfXyvzDsmPDV8o3FM2w1X1pMFeNeR4A8q/fFiocHYkmpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hiuPNBGi4RXNNjGG2ixGTRRVmKDTjodCCcyFSr034T8=; b=VhNb8S9UjCOS3lZwW2yWrxs/gkivTkhgb4Ixarc8d7Fqc1Juxmq2+jHou8w8GFq8x/ghsbHFlZZZw52Elu4fTzLmj58aOVYPj/xdUlWN7yRKn04wX2wd89Raqwv7KyHtH4gYLhOl0D3za8dR4Irkcgdsq35SgKSI0RAjmXHeTMw= Received: from DM6PR11MB3420.namprd11.prod.outlook.com (2603:10b6:5:69::31) by DM5PR11MB1578.namprd11.prod.outlook.com (2603:10b6:4:e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Thu, 23 Jul 2020 07:51:48 +0000 Received: from DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::e8b2:1d82:49d9:f4b]) by DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::e8b2:1d82:49d9:f4b%6]) with mapi id 15.20.3216.024; Thu, 23 Jul 2020 07:51:48 +0000 From: To: , , , , Subject: Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Thread-Topic: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Thread-Index: AQHWYBNhIyVBpIRYr0OAbjzWw9KOlQ== Date: Thu, 23 Jul 2020 07:51:48 +0000 Message-ID: <8a78218a-9fbe-889d-8501-ad67ccb6e59b@microchip.com> References: <20200721171316.1427582-1-codrin.ciubotariu@microchip.com> <0ec99957-57e9-b384-425a-ccf0e877f1a1@microchip.com> <7cab13f6-ac54-8f5c-c1bf-35e6c3b5d9db@microchip.com> In-Reply-To: <7cab13f6-ac54-8f5c-c1bf-35e6c3b5d9db@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: microchip.com; dkim=none (message not signed) header.d=none;microchip.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [213.233.110.107] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8e28297b-f1ab-4235-3d05-08d82edd40f4 x-ms-traffictypediagnostic: DM5PR11MB1578: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dMN1S7M8sH8DjdAkUxSMcNY0+iQ6IC/hkxpgrV50yxt5zDjWQ/JK7BWobPSwpgtKe5udrbnH5cm8vrSmp4p8S2qnBNmS5CJrCsfuHH90bUBEWLbWHBW4UTXzirqqHjdcMJptRAKJ5Lo+9Pxw4kGKo3LYET4cejl/m2i6lm2XZ6o8TQSwFTBS8AV85KGZalMNnyB6zsMI+5RcIXOxINeVBDELGtx4dAi/6QEQzhG/eVvhsmswSW7504obegdnaDKEDsjkx+pojn+i9y9Gv/URyqMPkzcPyn8C1OyV8AG2mSs6hoziw5YLt0YI5Wu+VborWLNynvPtM3cFZm6Xy+AYveTYChqwJd7zzVQfj10L4H9jVjQoWX/fwPlr1YocntZv x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3420.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(346002)(366004)(136003)(39860400002)(396003)(2616005)(26005)(53546011)(478600001)(6486002)(31686004)(6506007)(110136005)(186003)(83380400001)(71200400001)(66476007)(66446008)(64756008)(66556008)(91956017)(76116006)(8936002)(107886003)(31696002)(4326008)(316002)(54906003)(8676002)(86362001)(7416002)(6512007)(66946007)(2906002)(36756003)(5660300002)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: KCz6ex+hXqI0FAH/3jmGpNh7UafUFWy35KWD0oZYvqb3EoEX5MWDiJH4lZc3p6F3MZPbVhqGDFN+JHy8pYVXIMUG535O++iKUAFdOM1LM3uIvzwsoFcVu0rsEV25K4WlN5z83/Q96B9ZCmxT1oNiowIL502ymMxuS7wYghcNH909aFoFsk2Gk48bUrsbkMPCq2UP52DWNUlWO51/6RMxjBhHIXkyMclfdemEYqP+7zTpntv35woH6gqNtqeXLtcnqA4DCwBG4ExokKWVAoqQjZVzrixvotuM6nztbaTNMQ6zeQP9R1CBXYeTAXJ82OiZlu1CuxxKYZiPLLNdxP+mw5foLrf/3gxAz8eJSckAKvpyg0YFN44/pdjcc2yMAf6CMx21M1nMPkg8mI5ZXLCusUB2OyH3C4pBYliEjySej89/1wXpXInFllJQ1PV9KZU9moERyP+i623dsZbv4Vqvf9bwjb2EzFKz9XKzXNXOOWJXo8meXx0u5V9VvqaJGQ5Q Content-ID: <283181F64A83D845874B94714A0D4929@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3420.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e28297b-f1ab-4235-3d05-08d82edd40f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 07:51:48.3694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zRw1JD05J480xnGSzDNcnRmUn1vYmCHxBDCjG2aMngLRTfGtltZDXpDLI3l2lk1ROVCLkwHjbrSDD8cPlvTBUj0vw4LYbaOR+0SwuOL3+JI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1578 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_035155_420736_F3B35CA9 X-CRM114-Status: GOOD ( 21.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com, f.fainelli@gmail.com, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, kuba@kernel.org, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22.07.2020 14:38, Codrin Ciubotariu - M19940 wrote: > On 22.07.2020 13:32, Claudiu Beznea - M18063 wrote: >> >> >> On 21.07.2020 20:13, Codrin Ciubotariu wrote: >>> Adding the PHY nodes directly under the Ethernet node became deprecated, >>> so the aim of this patch series is to make MACB use an MDIO node as >>> container for MDIO devices. >>> This patch series starts with a small patch to use the device-managed >>> devm_mdiobus_alloc(). In the next two patches we update the bindings and >>> adapt macb driver to parse the device-tree PHY nodes from under an MDIO >>> node. The last patches add the MDIO node in the device-trees of sama5d2, >>> sama5d3, samad4 and sam9x60 boards. >>> >> >> Tested this series on sama5d2_xplained in the following scenarios: >> >> 1/ PHY bindings from patch 4/7: >> mdio { >> #address-cells = <1>; >> #size-cells = <0>; >> ethernet-phy@1 { >> reg = <0x1>; >> interrupt-parent = <&pioA>; >> interrupts = ; >> }; >> >> 2/ PHY bindings before this series: >> ethernet-phy@1 { >> reg = <0x1>; >> interrupt-parent = <&pioA>; >> interrupts = ; >> }; >> >> 3/ No PHY bindings at all. >> >> All 3 cases went OK. >> >> You can add: >> Tested-by: Claudiu Beznea >> Acked-by: Claudiu Beznea > > Thank you very much Claudiu! > There is still one more case in my mind. macb could be a fixed-link with > an MDIO DSA switch. While the macb would have a fixed connection with a > port from the DSA switch, the switch could be configured using macb's > MDIO. The dt would be something like: > > macb { > fixed-link { > ... > }; > mdio { > switch@0 { > ... > }; > }; > }; Do you have a setup for testing this? At the moment I don't know a configuration like this that macb is working with. > > To support this, in patch 3/7 I should first check for the mdio node to > return of_mdiobus_register() and then check if it's a fixed-link to > return simple mdiobus_register(). I will address this in v3...> > Thanks and best regards, > Codrin > >> >> Thank you, >> Claudiu Beznea >> >>> Changes in v2: >>> - renamed patch 2/7 from "macb: bindings doc: use an MDIO node as a >>> container for PHY nodes" to "dt-bindings: net: macb: use an MDIO >>> node as a container for PHY nodes" >>> - added back a newline removed by mistake in patch 3/7 >>> >>> Codrin Ciubotariu (7): >>> net: macb: use device-managed devm_mdiobus_alloc() >>> dt-bindings: net: macb: use an MDIO node as a container for PHY nodes >>> net: macb: parse PHY nodes found under an MDIO node >>> ARM: dts: at91: sama5d2: add an mdio sub-node to macb >>> ARM: dts: at91: sama5d3: add an mdio sub-node to macb >>> ARM: dts: at91: sama5d4: add an mdio sub-node to macb >>> ARM: dts: at91: sam9x60: add an mdio sub-node to macb >>> >>> Documentation/devicetree/bindings/net/macb.txt | 15 ++++++++++++--- >>> arch/arm/boot/dts/at91-sam9x60ek.dts | 8 ++++++-- >>> arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 16 ++++++++++------ >>> arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 17 ++++++++++------- >>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 13 ++++++++----- >>> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 12 ++++++++---- >>> arch/arm/boot/dts/at91-sama5d3_xplained.dts | 16 ++++++++++++---- >>> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 12 ++++++++---- >>> drivers/net/ethernet/cadence/macb_main.c | 18 ++++++++++++------ >>> 9 files changed, 86 insertions(+), 41 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel