From: panand@redhat.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] kexec: arm64: create identity page table to be used in purgatory
Date: Wed, 15 Mar 2017 15:12:11 +0530 [thread overview]
Message-ID: <8aba46a4-411e-0a4c-0e85-ea955348f631@redhat.com> (raw)
In-Reply-To: <281f2f04-842d-73d3-cd52-8774ab549c23@redhat.com>
Hi James,
On Wednesday 18 January 2017 01:13 PM, Pratyush Anand wrote:
>
>>
>>> + * in kexec
>>> + */
>>> + if (next_tbl_cnt > 5)
>>> + die("%s: No more memory for page table\n", __func__);
>>
>> die()? With a bit of juggling can't we return an error so we never try
>> to enable
>> the MMU+dcache instead?
>>
>
> OK. can do that.
It does not seem easy to do that. We will have to revert job of
add_buffer_phys_virt() in case of failure, and it will need lot of new
code. So, IMHO it would be better to keep die() as of now.
What do you say?
~Pratyush
next prev parent reply other threads:[~2017-03-15 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 7:13 [PATCH V2 0/2] kexec-tools: arm64: Enable D-cache in purgatory Pratyush Anand
2016-12-19 7:13 ` [PATCH V2 1/2] kexec: arm64: create identity page table to be used " Pratyush Anand
2016-12-19 7:21 ` Maxim Uvarov
2016-12-19 7:23 ` Pratyush Anand
2017-01-17 17:25 ` James Morse
2017-01-18 7:43 ` Pratyush Anand
2017-03-15 9:42 ` Pratyush Anand [this message]
2016-12-19 7:13 ` [PATCH V2 2/2] arm64: enable d-cache support during purgatory sha verification Pratyush Anand
2017-01-06 3:31 ` [PATCH V2 0/2] kexec-tools: arm64: Enable D-cache in purgatory Pratyush Anand
2017-01-10 14:11 ` James Morse
2017-02-23 5:59 ` Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aba46a4-411e-0a4c-0e85-ea955348f631@redhat.com \
--to=panand@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).