From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 228B8C27C77 for ; Mon, 17 Jun 2024 09:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tHualuQcrcR9FOndaPpRpoW37XnDcV8gKD4pHsnrc4s=; b=eLIIZLapW12XuWdxK8CHTLpKaw ZF154emZtSnFqmh7V2YYk0qD1L8UHCi/duzzWdE+mpc0HxLPMfqMdsSlhzzu+2l/sZQKgS5PrkPR5 CKQi4y03D7TocwWEwlRBm1Hoa16Fq8GKdm08lcVYwPeKCmYGbWKigRXREb8O2p5yK2VmLlvBQmzWR VHB4w/0p5F6st8zGrUz9eldmKtdIjk6hqNooiZeXibrY6W3o82Gfx3GXySqvVLO3k4wlJNTySQfWy RDxvD3ZaB1gwS6nJq2bwFySFG2OF/cqUqwDEPxu2lb/PZQr/h+9vLp/vlqUPT+jo3+J72BU8VU1HY 7QNy5NQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ8MS-00000009xfP-1H9f; Mon, 17 Jun 2024 09:09:12 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ8MP-00000009xer-1XgR; Mon, 17 Jun 2024 09:09:10 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-52caebc6137so1855621e87.0; Mon, 17 Jun 2024 02:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718615345; x=1719220145; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tHualuQcrcR9FOndaPpRpoW37XnDcV8gKD4pHsnrc4s=; b=BPzoCdHzbI8r1mqgahsCBRIcWyv4C6+CxlLLDZm8P2Q1ON8KyS6ko1l2KkAaq/X+08 knkAM4QKuAYRT4imAKFZ/VZVm5KPOYuCW2PyFpSm+w7LqNw0hq9VaHCX+crybVdmJVGb H2C9jXXWaUILzx4O4eegn7yjv4JCRiqMtiTPJU6aiaIn78VasG+rXpdJczoH2iOzRhgo ITN19hmx9fmpPILxI0amz5ZfAWILmnxEB3+6npfpOr4z/VngayhnHa3cwSyI8YYx/k58 dYvR+0cIcxHi+dcGX1nlY9g5Aq7l1l3jeQsuFlBBpxykYBqItzVIxAXYYwi818ftlnbm a6Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718615345; x=1719220145; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tHualuQcrcR9FOndaPpRpoW37XnDcV8gKD4pHsnrc4s=; b=xP4jfSEL3FYmrsVxPbX5f15rp80cJZrJHlVcY/9LH7RvyrALzCfwAr+/sVA5boAmkN i6LAPLQODU8g6hKwooLHga7i24PYU98FNrwjsLhlg+xaMwwucWkmsYGs7PbS8Hn8X1I6 g2Kw13aFqJv0tZF/XRQlSXmn9aGQ+MDmxXo0qqHKxengM5l+1Tbhqggtc+W/+OCyDm64 uNe4dLLyp3AljhX07jQQF1quuhjA8ETCdVemskQa3OjFoLcCHivWhtrcbjN/hcPS9yQM levsVe/j8QTSSwNhY4fb3Qldo3ZKYdzfRiwWTdSuMLZTVP6RYPKqpTO0LwiIVxlTP8Az cQYg== X-Forwarded-Encrypted: i=1; AJvYcCWJoKnwqRTIqaeMX26fEPpU+WzA1eCEd9AWWEbfwgrLanRwiFyyYnAfhst70iJUcPjB2cD44VZnG6t3yPgBZGCWLU168TeiW9uMFVWOlJ8C8NepM95y+Y20OShb2txJSz2l1HnXmsCkd4e7zV6QjaLIsiMgNlsf2V4= X-Gm-Message-State: AOJu0YwbTa178HVePhEqY6zrDQoJr3zp05QNHh+oQcLDmIHVSPoEWnzG PKhLYcEOwreWOebCoG5dGiuGlCQaeYOfJ0WZFT0rUEySWUr9a2H2ks1n0PJH2mxofg== X-Google-Smtp-Source: AGHT+IFHVBJp/VFqtV++c4t0//VCdL0P9LDVu7JUn+qUbTIRnLIdZCE653CJVQBQ1vaa46S79Eeekw== X-Received: by 2002:ac2:555e:0:b0:52c:9a1f:52e7 with SMTP id 2adb3069b0e04-52ca6e988a6mr5758312e87.58.1718615344901; Mon, 17 Jun 2024 02:09:04 -0700 (PDT) Received: from ?IPV6:2001:8f8:183b:6864:7071:8881:6a51:3e82? ([2001:8f8:183b:6864:7071:8881:6a51:3e82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f6127d6dsm154008765e9.26.2024.06.17.02.09.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 02:09:04 -0700 (PDT) Message-ID: <8ae179e6-3aee-415b-9dc4-298e162fbcad@gmail.com> Date: Mon, 17 Jun 2024 13:09:00 +0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] arm64: dts: rockchip: Add cpufreq support to Khadas Edge2 Content-Language: en-GB To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Jacobe Zang Cc: nick@khadas.com, efectn@protonmail.com, jagan@edgeble.ai, dsimic@manjaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240617071112.3133101-1-jacobe.zang@wesion.com> <20240617071112.3133101-6-jacobe.zang@wesion.com> <5475817.tWeucmBOSa@diego> From: Alexey Charkov In-Reply-To: <5475817.tWeucmBOSa@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_020909_432736_BAA287FD X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/06/2024 11:33, Heiko Stübner wrote: > Hi Jacobe Zang, > > Am Montag, 17. Juni 2024, 09:11:12 CEST schrieb Jacobe Zang: >> This adjust CPU nodes on Khadas Edge2. >> >> Signed-off-by: Jacobe Zang >> --- >> .../arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts >> index 7d7cc3e76838c..5fb15d3dc23e9 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts >> @@ -160,34 +160,42 @@ vdd_3v3_sd: vdd-3v3-sd-regulator { >> >> &cpu_b0 { >> cpu-supply = <&vdd_cpu_big0_s0>; >> + mem-supply = <&vdd_cpu_big0_mem_s0>; > as far as I remember there has not been any binding merged that declares > this supply. Thankfully following the double phandle below, the Edge2 is > designed to use the same regulator for the mem-supply, so special handling > isn't even needed. Indeed, currently there isn't any user in the mainline tree (neither bindings nor drivers) for this separate regulator. Mainline cpufreq-dt only expects a single regulator, and as Heiko pointed out Edge2 uses the same physical regulator to power both the CPU core and its SRAM, so adding a separate mem-supply here isn't helpful. Best regards, Alexey