From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92056C61DA4 for ; Mon, 6 Feb 2023 13:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lP63FeBte3q2ZAkP+2JIvzr17uiJJeMdYnHdjNZ8cW0=; b=12vuAK6yG23obW RRCvMHEN/SaDRqGAMxmS6Cms2PBODWlJib7Xoo6p6/0140VUcUxR1QZfPnyXKtlRG/gjyQy+xRr2B klY0o+4T3jjluk+asvqoo+j1g0I3MsetmUqwjH1qMFH1e+tPmaQdwk6DVe2mqBgKpTjUz4Xb97tF6 dcnl8bVIGgQ5sGeGRYLWLX+QLGB4jKXTgKp6u12s5fshSCcy//KGkWUsSmZ8f1ASIlj1lOKfmKhYl u616/inag+9jN2aAGAuwUAScLcYtvCTII8BNaH3Ijl4FbUIMx9hF7UjkW9GDDtGV1GbiWorVtT1Xz kf5yDK4705c1aH3uwqmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP1ko-008eLP-3Z; Mon, 06 Feb 2023 13:41:54 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pP1kk-008eKr-TP for linux-arm-kernel@lists.infradead.org; Mon, 06 Feb 2023 13:41:52 +0000 Received: by mail-wr1-x435.google.com with SMTP id g6so2414991wrv.1 for ; Mon, 06 Feb 2023 05:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Tnrt4Zg0tlIQVYINNkRz4s/fKnod8Ek43EfIyPJnxkA=; b=TB1Jqw5IMc+jS8irbHdcb5rRFvAI6F2bJgnvrm1yvoFOx+3o5NdBbciSTN0kpj2gVg IkPg/U2yhtqHKY9+JfjGPzoa2X9qnthy5/Q+Rn3PEQV1oXWDfyMOGbk1NGS/6PSgcXSA gbc9+GyLhsshWzv54Kym/jwOKewprn5oZPkZ60s50npbAvQKLUt43xbG+XdP3/K3y8V5 vpyfNWJAofZHRo90/hTZDgWzIjuleep1CLC61gwGp5GIk4yqvuFnYM/rfeBw5E6eXcS2 H6ASBTPncIAlqvlYRBthtfbh3FM8NzU1LSBaoPVuWwdOEvbO2YxWEs5RfGxDgVTiOyr0 TECA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tnrt4Zg0tlIQVYINNkRz4s/fKnod8Ek43EfIyPJnxkA=; b=P627CojFOk6SA3KCqQ3LOqleXBVgOsD+cCHyCbQr0pHn8TcnwnaWvLYdgZSXl8PP3Z 6nqA9rPgRtAZ0xAfFRuBaaeuEBaGA0W+F+286AD7nsubRUKogz2rZwUXpHWhgbhxEg1y tgjBY5zIvssLn7k6IKOHMSaHy+ALr5E+K0V1gdcpIlU7klIWqfZY4m5E3NmmUbgapaGv 6aOEeZGTFdr20QEWizMentdleZDTG82BHp8dKRemG9CJyWlrKJZA3V+itFDkI3GYX+TE 2okreAlop0bIdI7aNxWbGf+Q3A0NJOzRMCQQiHfatFKyC6sVC7z23SZHDY+1DbETaXpU WagA== X-Gm-Message-State: AO0yUKUMyQNPNCDWR3dk4WJTGWqhLwPfNyC7/Jb8KA0ktWzNoDe30Far Cx5vPMwaunBbVsOT7QULYHxUeQ== X-Google-Smtp-Source: AK7set/UKoisZmflloJVFNAQtY6VIu8OdVuXW1g1Fba2lAi0thkN1OsYsBZMrsvGq/Ek0sWgJ7PzDw== X-Received: by 2002:a05:6000:15ce:b0:2bf:d17c:608a with SMTP id y14-20020a05600015ce00b002bfd17c608amr24584079wry.58.1675690907048; Mon, 06 Feb 2023 05:41:47 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d2-20020a056000186200b002bddd75a83fsm9472227wri.8.2023.02.06.05.41.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 05:41:46 -0800 (PST) Message-ID: <8b164c2f-b7b9-c5df-3b9c-ea39bd3eb424@linaro.org> Date: Mon, 6 Feb 2023 14:41:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings Content-Language: en-US To: Li Chen Cc: li chen , michael turquette , stephen boyd , rob herring , krzysztof kozlowski , "moderated list:arm/ambarella soc support" , "open list:common clk framework" , "open list:open firmware and flattened device tree bindings" , open list , arnd bergmann References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-8-lchen@ambarella.com> <0c19efb4-3bca-f500-ca24-14b9d24369ef@linaro.org> <87y1prgdyu.wl-me@linux.beauty> <87tu0ehl88.wl-me@linux.beauty> <87sffyhgvw.wl-me@linux.beauty> <185f3b3a330.11c135c37327076.6300919877819761183@linux.beauty> <33c2038b-5e06-4eb2-82b8-007bb735bfb1@linaro.org> <186267bd495.c0d336602542450.72693939722996463@linux.beauty> From: Krzysztof Kozlowski In-Reply-To: <186267bd495.c0d336602542450.72693939722996463@linux.beauty> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_054150_985764_F9CC344F X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/02/2023 12:28, Li Chen wrote: > Hi Krzysztof , > > ---- On Fri, 27 Jan 2023 23:08:09 +0800 Krzysztof Kozlowski wrote --- > > On 27/01/2023 15:48, Li Chen wrote: > > > > > > > > but what you are saying is that there is no separate clock controller > > > > device with its own IO address but these clocks are part of rct_syscon. > > > > Then model it that way in DTS. The rct_syscon is then your clock > > > > controller and all these fake gclk-core and gclk-ddr nodes should be gone. > > > > > > Ok, I will remove these fake nodes, and model the hardware as: > > > > > > rct_syscon node > > > | clock node(pll, div, mux, composite clocks live in the same driver) > > > | other periphal nodes > > > > You need clock node if it takes any resources. If it doesn't, you do not > > need it. > > If the only hardware resource the clock node can take is its parent clock(clocks = <&osc>;), > then can I have this clock node? I am not sure if I understand. osc does not look like parent device, so this part of comment confuses me. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel