From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: tim.gover@raspberrypi.org, oneukum@suse.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: xhci-pci: Raspberry Pi FW loader for VIA VL805
Date: Mon, 17 Feb 2020 20:39:06 +0100 [thread overview]
Message-ID: <8b50c93b2556413ce2736e18e939f1b376bf48c7.camel@suse.de> (raw)
In-Reply-To: <bf77d351-ca8c-d9fd-e5ea-71441ac00ab3@i2se.com>
[-- Attachment #1.1: Type: text/plain, Size: 1553 bytes --]
On Mon, 2020-02-17 at 18:47 +0100, Stefan Wahren wrote:
> > +
> > + dev_addr = pdev->bus->number << 20 | PCI_SLOT(pdev->devfn) << 15 |
> > + PCI_FUNC(pdev->devfn) << 12;
> > +
> > + ret = rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_XHCI_RESET,
> > + &dev_addr, sizeof(dev_addr));
> > + if (ret)
> > + return ret;
> not sure, but there could be a corner case which should be handled
> differently. In case the Raspberry Pi 4 has an EEPROM for the VL805
> firmware but the firmware is too old to handle
> RPI_FIRMWARE_NOTIFY_XHCI_RESET, we should return with 0. I don't know
> there is a change to detect this reliable. I just want to mention this.
Ouch, good point, that can be problematic. I'll test that scenario tomorrow.
> > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h
> > b/include/soc/bcm2835/raspberrypi-firmware.h
> > index 7800e12ee042..cc9cdbc66403 100644
> > --- a/include/soc/bcm2835/raspberrypi-firmware.h
> > +++ b/include/soc/bcm2835/raspberrypi-firmware.h
> > @@ -90,7 +90,7 @@ enum rpi_firmware_property_tag {
> > RPI_FIRMWARE_SET_PERIPH_REG = 0x00038045,
> > RPI_FIRMWARE_GET_POE_HAT_VAL = 0x00030049,
> > RPI_FIRMWARE_SET_POE_HAT_VAL = 0x00030050,
> > -
> > + RPI_FIRMWARE_NOTIFY_XHCI_RESET = 0x00030058,
>
> In past we updated the firmware mailbox property interface in a bunch as
> a separate patch. So we can avoid those gaps.
Ok, I'll change that.
Regards,
Nicolas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-17 19:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 10:07 [PATCH] usb: xhci-pci: Raspberry Pi FW loader for VIA VL805 Nicolas Saenz Julienne
2020-02-17 10:36 ` Greg Kroah-Hartman
2020-02-17 11:12 ` Nicolas Saenz Julienne
2020-02-17 17:47 ` Stefan Wahren
2020-02-17 19:39 ` Nicolas Saenz Julienne [this message]
2020-02-17 20:52 ` Florian Fainelli
2020-02-17 21:19 ` Nicolas Saenz Julienne
2020-02-17 21:40 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b50c93b2556413ce2736e18e939f1b376bf48c7.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=oneukum@suse.com \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=tim.gover@raspberrypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).