From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72210C34022 for ; Mon, 17 Feb 2020 19:39:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 477F820578 for ; Mon, 17 Feb 2020 19:39:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KoC7l64V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 477F820578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=arMjP9g/dYwtJkaT/d4iVr6rW+CeNiz4zLDQsRi/C2Y=; b=KoC7l64VKtK5TWE8p1MHXi92+ J9tpHxzE4cHfomvtSPRyuS03eb1FCtFAZ1fmqRbdC0S2KrduAo9klqV6AMmGiGwlxO4+7z6p27XUZ ZtZznskjv7SoUk2MX1la5pk8NunDFRE4LYWSVq74MheSeP2yt+yd7LaxCBIVYcOqUsIie1yI3pzsn jaK4wCzAtHWihHrsncn1Wy37HNze+P5TnopI2tw7xL7DVv5Uf3ZpA6LDm31e39njbLImlOCnJcDPV iv4WlquYvsdXqmTt7ax7cwPq6s8k5guJsQ7VcyEFOQZxbhxoa+Mf2L6LA++lv5jg8I6TpI4v4dffs jG2iQSMIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3mEg-0001T3-G7; Mon, 17 Feb 2020 19:39:18 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3mEe-0001Rv-Bz; Mon, 17 Feb 2020 19:39:17 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D108CAC53; Mon, 17 Feb 2020 19:39:08 +0000 (UTC) Message-ID: <8b50c93b2556413ce2736e18e939f1b376bf48c7.camel@suse.de> Subject: Re: [PATCH] usb: xhci-pci: Raspberry Pi FW loader for VIA VL805 From: Nicolas Saenz Julienne To: Stefan Wahren , Mathias Nyman , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Date: Mon, 17 Feb 2020 20:39:06 +0100 In-Reply-To: References: <20200217100701.19949-1-nsaenzjulienne@suse.de> User-Agent: Evolution 3.34.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_113916_557220_4066C979 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tim.gover@raspberrypi.org, oneukum@suse.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1426310270108997794==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1426310270108997794== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-ogkfL5d9U8ZLHgULSlCK" --=-ogkfL5d9U8ZLHgULSlCK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2020-02-17 at 18:47 +0100, Stefan Wahren wrote: > > + > > + dev_addr =3D pdev->bus->number << 20 | PCI_SLOT(pdev->devfn) << 15 | > > + PCI_FUNC(pdev->devfn) << 12; > > + > > + ret =3D rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_XHCI_RESET, > > + &dev_addr, sizeof(dev_addr)); > > + if (ret) > > + return ret; > not sure, but there could be a corner case which should be handled > differently. In case the Raspberry Pi 4 has an EEPROM for the VL805 > firmware but the firmware is too old to handle > RPI_FIRMWARE_NOTIFY_XHCI_RESET, we should return with 0. I don't know > there is a change to detect this reliable. I just want to mention this. Ouch, good point, that can be problematic. I'll test that scenario tomorrow= . > > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h > > b/include/soc/bcm2835/raspberrypi-firmware.h > > index 7800e12ee042..cc9cdbc66403 100644 > > --- a/include/soc/bcm2835/raspberrypi-firmware.h > > +++ b/include/soc/bcm2835/raspberrypi-firmware.h > > @@ -90,7 +90,7 @@ enum rpi_firmware_property_tag { > > RPI_FIRMWARE_SET_PERIPH_REG =3D 0x00038045, > > RPI_FIRMWARE_GET_POE_HAT_VAL =3D 0x00030049, > > RPI_FIRMWARE_SET_POE_HAT_VAL =3D 0x00030050, > > - > > + RPI_FIRMWARE_NOTIFY_XHCI_RESET =3D 0x00030058, >=20 > In past we updated the firmware mailbox property interface in a bunch as > a separate patch. So we can avoid those gaps. Ok, I'll change that. Regards, Nicolas --=-ogkfL5d9U8ZLHgULSlCK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl5K69oACgkQlfZmHno8 x/564ggAnRR3cI7WWFgxYpBmwwEU6WnQinv4UaaIe0w5g4vjvt8UjgnypPpwGlBI qqVXlFsvzR1pXNyTDZcjdzkqmYekgCaR4+0ONPYL+ofhQ3SeYg/FwsVgkWTcE0SQ FmiQRIDZk9qYF1UV5ABz0dPTvD3nBjNEN5+1s2Ti6hjSIb3OIVH/DgsxSUIQfvaK iL1+4ikVfvckbDrBG/PnCsCfxoiTfQWMC/QoUZROSsO4NVBFojLwyK0nDA+O9k8R 6N/1OMUoJOCzjW27KZ3vUuKf2Vc3pu4UgfPXEY4oeWpAF+5055DHaJBrYDQopEzE 0sJWKha2D5TpFR9/StcAUyp2secwOw== =+vmi -----END PGP SIGNATURE----- --=-ogkfL5d9U8ZLHgULSlCK-- --===============1426310270108997794== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1426310270108997794==--