linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: use __pa_symbol in the mv98dx3236 platform SMP code
Date: Fri, 7 Jul 2017 10:31:57 -0700	[thread overview]
Message-ID: <8b7c8f7d-f507-9abf-ff65-bc170f58d63d@gmail.com> (raw)
In-Reply-To: <87a84gd69w.fsf@free-electrons.com>

On 07/07/2017 01:02 AM, Gregory CLEMENT wrote:
> Hi Florian,
> 
> I forgot to CC you on this patch.
> 
> Gregory
> 
>  On ven., juil. 07 2017, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> 
>> As we already did for Armada XP switch from virt_to_phys() to
>> __pa_symbol().
>>
>> The reason for it was well explained by Mark Rutland so let's quote him:
>>
>> "virt_to_phys() is intended to operate on the linear/direct mapping of
>> RAM.
>>
>> __pa_symbol() is intended to operate on the kernel mapping, which may
>> not be in the linear/direct mapping on all architectures. e.g. arm64 and
>> x86_64 map the kernel image and RAM separately.
>>
>> On 32-bit ARM the kernel image mapping is tied to the linear/direct
>> mapping, so that works, but as it's semantically wrong (and broken for
>> generic code), the DEBUG_VIRTUAL checks complain."
>>
>> Fixes: db88977894ab ("arm: mvebu: support for SMP on 98DX3336 SoC")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian

  reply	other threads:[~2017-07-07 17:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07  7:59 [PATCH] ARM: mvebu: use __pa_symbol in the mv98dx3236 platform SMP code Gregory CLEMENT
2017-07-07  8:02 ` Gregory CLEMENT
2017-07-07 17:31   ` Florian Fainelli [this message]
2017-07-09 21:32 ` Chris Packham
2017-07-12 17:06 ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b7c8f7d-f507-9abf-ff65-bc170f58d63d@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).