From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11854CDB47E for ; Wed, 18 Oct 2023 13:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xJqUsc4jdSKk2/J2F4J6OPnwlHY1OZ3VCPoEzMjVMHY=; b=sxobZ1Na0j76CF rZ8t8t2laVNd+QNWK1WAXCym+ywFxaISU5eNOEfRzTe0L87LvQWLbonlsMI7eMWfoYgH+AC5BtxJ2 Cu/wQjIl9T2GBc+3HEYS9VsCNYyALu4GlTlU8T0ftQkFGDXTdlDpbIFBt/y2/5UBaMvlym87Bebc7 IgOvbxAx01pdeM6cmdf1Ijra+ThBWeDzQM7SUbHsaoUkae6x1RcwMaZWe9ltunw2Kavy58AUCsKMx /1Zk+f9fpFn+1rxAla4u6zyjF1igXJtZJLtoferLa2k0nsQILs6eDIVTAT/8JjCwLX66G6kVikKtd toe6NTAUllg9OeJtsDdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt6Fn-00Ejim-1O; Wed, 18 Oct 2023 13:06:27 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt6Fj-00Ejh0-2Y for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 13:06:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697634382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xDPf6ZClz1qisizpypkqehRk5MT7Q/Peay1tAP2fVMM=; b=F+SLyeE5aNBFLClh8JWCXJT4LEeB8jB+we1jiqG3JsvaAJxOPJ/50afzmIXsoOBDQAwI7E a7QjQKO+FqcrUeW6g47gmTlqtW7hVNYT51VwdfoKriwepuDLKsEwJoX0f7RbuX7oorz4wP TFIUaWG7a0iNuzYVRUHoddmEGuV0gl8= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-f9rmtedUPrWrB66Q0Itgfw-1; Wed, 18 Oct 2023 09:06:20 -0400 X-MC-Unique: f9rmtedUPrWrB66Q0Itgfw-1 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-6c7a9cd75caso9258903a34.3 for ; Wed, 18 Oct 2023 06:06:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697634380; x=1698239180; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xDPf6ZClz1qisizpypkqehRk5MT7Q/Peay1tAP2fVMM=; b=a2IEmCDv1OURQ7VcqZ6FskrOsAj6hVZVZtohf4SFrRz07dETE90DzlIv22Tgut5oHQ QrRZ85e9Mb0uq/H4yHFRLEC7L/HB91cCQfNI9rlt3P+U8NtUH+ToiOtd5VkPDN3YkgLt 13YzpXrueCxPOeC/R+Cc8ADCPeJ3fWwuGKkPNZ3bg1VEa9TowXk/ZtIr/H/fYe2xUldW WN+db/Lnrn+uFBEMaFxN0MY4PUgxymaKqPo7N7bgaWxW3ge3myC/jf7xopTmnOWIf7fQ 97n54KzlGRkFGOaFCfckOEUKbEDo8isR0aOYQgrK1jEjdNr+HRsY6CRlTHJvkrtW9285 ShQA== X-Gm-Message-State: AOJu0Yzmpi5ZUwTFa8YRdlUzqfMxnLq1Q75zkKyy9PhpNA7kXnXXfrXE eV3JdZpMrhqeoKfdPv28lIoCXqx0yp+APFJOG+KIDnlIF9siqDu3l9GVyTUbLT3rPNO6RASfw/2 gzYVn12EbkycOYlpxac+sLM10FXOPMnunm3k= X-Received: by 2002:a9d:7651:0:b0:6bc:8930:a1d4 with SMTP id o17-20020a9d7651000000b006bc8930a1d4mr4729123otl.15.1697634380057; Wed, 18 Oct 2023 06:06:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF28cwHOtFQEM5xgFaOvInzipiKqUbKufB+2pe6ZuBmbmYYz/MbPBWWD8uzmf2D4Eu9+1qKxA== X-Received: by 2002:a9d:7651:0:b0:6bc:8930:a1d4 with SMTP id o17-20020a9d7651000000b006bc8930a1d4mr4729102otl.15.1697634379644; Wed, 18 Oct 2023 06:06:19 -0700 (PDT) Received: from [192.168.43.95] ([37.170.189.211]) by smtp.gmail.com with ESMTPSA id a28-20020a05620a16dc00b007778503ebf4sm1375071qkn.16.2023.10.18.06.06.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 06:06:18 -0700 (PDT) Message-ID: <8baca35a-9154-97e6-d682-032fc69d2da6@redhat.com> Date: Wed, 18 Oct 2023 15:06:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 4/5] tools headers arm64: Update sysreg.h with kernel sources To: Mark Brown Cc: Oliver Upton , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Jing Zhang , Zenghui Yu , Suzuki K Poulose , James Morse , Marc Zyngier , Paolo Bonzini , Adrian Hunter , Ian Rogers , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Mark Rutland , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra References: <20231011195740.3349631-1-oliver.upton@linux.dev> <20231011195740.3349631-5-oliver.upton@linux.dev> <73b94274-4561-1edd-6b1e-8c6245133af2@redhat.com> <3c5332b0-9035-4cb8-96ce-7a9b8d513c3a@sirena.org.uk> From: Eric Auger In-Reply-To: <3c5332b0-9035-4cb8-96ce-7a9b8d513c3a@sirena.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_060623_903070_415DCF8F X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, Oliver, On 10/18/23 14:16, Mark Brown wrote: > On Wed, Oct 18, 2023 at 01:57:31PM +0200, Eric Auger wrote: >> On 10/11/23 21:57, Oliver Upton wrote: > >>> #define set_pstate_pan(x) asm volatile(SET_PSTATE_PAN(x)) >>> #define set_pstate_uao(x) asm volatile(SET_PSTATE_UAO(x)) >>> #define set_pstate_ssbs(x) asm volatile(SET_PSTATE_SSBS(x)) >>> +#define set_pstate_dit(x) asm volatile(SET_PSTATE_DIT(x)) > >> could you comment on the *DIT* addictions, what is it for? > > DIT is data independent timing, this tells the processor to ensure that > instructions take a constant time regardless of the data they are > handling. > > Note that this file is just a copy of arch/arm64/include/asm/gpr-num.h, > the main purpose here is to sync with the original. Ah thanks. that's helpful for me to understand where this gpr-num.h comes from. This could be documented in the commit msg though. Something like: adding tools/arch/arm64/include/asm/gpr-num.h matching linux arch/arm64/include/asm/gpr-num.h and syncing tools/arch/arm64/include/asm/sysreg.h with the fellow header in the linux tree. tbh I did not initially understand that all this diffstat was aimed to match the linux arch/arm64/include/asm/sysreg.h. Now diffing both I have some diffs. Doesn't it need a refresh? Thanks Eric > >>> +/* >>> + * Automatically generated definitions for system registers, the >>> + * manual encodings below are in the process of being converted to >>> + * come from here. The header relies on the definition of sys_reg() >>> + * earlier in this file. >>> + */ >>> +#include "asm/sysreg-defs.h" > >> strange to have this include in the middle of the file > > It relies on defines from earlier in the header. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel