From: Andrew Lunn <andrew@lunn.ch>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
Franz Schnyder <franz.schnyder@toradex.com>
Subject: Re: [PATCH v2 3/7] arm64: dts: freescale: Add Lino iMX93
Date: Wed, 16 Sep 2026 14:27:54 +0200 [thread overview]
Message-ID: <8bb9b763-4553-4263-b0ea-0129f5db0229@lunn.ch> (raw)
In-Reply-To: <20260916055706.GA20310@francesco-nb>
> I looked into the specific ethernet phy used here, TI DP83867, and
> I would say that the falling edge interrupt should be safe on this
> specific board/phy.
https://www.ti.com/lit/ds/symlink/dp83867ir.pdf
Page 7:
INTERRUPT: This pin can be programmed as an interrupt output instead
of a Power down input. In this mode, Interrupts is asserted low
using this pin.
Also:
When operating this pin as an interrupt, the pin is an open-drain
architecture.
This allows you to connect multiple PHYs to one SoC interrupt, shared
interrupts, which again needs level interrupts.
So the datasheet says it is active low.
> What do you think? *IF* my reasoning is correct I would suggest to keep
> the code as it is now.
If you decide to stay with edge, i suggest you put a comment in DT,
something like:
# The PHY data sheet says the interrupt is active low, but the
# interrupt controller does not support level interrupts. Use it as
# falling edge and hope for the best.
Andrew
next prev parent reply other threads:[~2026-09-16 12:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 9:19 [PATCH v2 0/7] arm64: dts: freescale: Add Toradex Lino and OSM iMX91/iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 1/7] dt-bindings: arm: fsl: Add Lino iMX91/iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 2/7] dt-bindings: arm: fsl: Add Toradex OSM iMX91/iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 3/7] arm64: dts: freescale: Add Lino iMX93 Francesco Dolcini
2026-09-11 14:30 ` Frank Li
2026-09-14 5:42 ` Francesco Dolcini
2026-09-14 14:28 ` Frank Li
2026-09-14 14:36 ` Francesco Dolcini
2026-09-17 14:08 ` Francesco Dolcini
2026-09-17 15:51 ` Frank Li
2026-09-17 17:00 ` Francesco Dolcini
2026-09-15 13:19 ` Andrew Lunn
2026-09-15 13:28 ` Francesco Dolcini
2026-09-15 16:49 ` Andrew Lunn
2026-09-15 17:57 ` Francesco Dolcini
2026-09-15 19:57 ` Andrew Lunn
2026-09-16 5:57 ` Francesco Dolcini
2026-09-16 12:27 ` Andrew Lunn [this message]
2026-09-16 12:43 ` Francesco Dolcini
2026-09-16 13:03 ` Andrew Lunn
2026-09-11 9:19 ` [PATCH v2 4/7] arm64: dts: freescale: imx93-lino: Add dahlia Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 5/7] arm64: dts: freescale: Add Lino iMX91 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 6/7] arm64: dts: freescale: Add Toradex OSM iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 7/7] arm64: dts: freescale: Add Toradex OSM iMX91 Francesco Dolcini
2026-09-23 20:16 ` [PATCH v2 0/7] arm64: dts: freescale: Add Toradex Lino and OSM iMX91/iMX93 Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bb9b763-4553-4263-b0ea-0129f5db0229@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=ernest.vanhoecke@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=franz.schnyder@toradex.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox