From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0402C54E67 for ; Tue, 26 Mar 2024 17:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z0XQzkNBlgt0rY6dEMsJmy8NVJ/Yut3mq8iv6PbQQKg=; b=yNsx3h18aMUxcm 5+0CpwL9v8wjrm2wQ425J5/om4utpWa6MXVPrGJk0NUXisUeCMh8IO6tfBodYaOD5bmb52FhwwNcF Po/LRE0DfTJKbHuX09RYCw6djrUCFYMiGy5AgzVZmBob57dxdJMEoPgIHs2ZpTe22gPQzkGqo3VtW uK9VSb/7Gzs/yOg7Drjb9zvyC5JZhvbL+HeLgYEFb51RJDZ0PpUgf06xu/VsFzu+Vi35EYufJnKLK v6mtvqc78FuLYLWJC1BCo+JT3ht4JoNnSftHoOhQl4ygxDoa7wbquVGasJYgZBl75QfCcUN0D2NzL GL5UQI91MtpO7D8ACTbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpAlq-00000005mS3-1fHM; Tue, 26 Mar 2024 17:39:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpAlk-00000005mQU-46l4 for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 17:39:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711474768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nv03yiZAiZgBWj6kUmes+WMp8CfflptuZICYst0uZlA=; b=Y2G5sO75Hg86aZekUvCjWI6Sybrr3cU5n8rmoW4Dg5bn4pcy84Ysmy9vhtuAaUAHC9DDDQ X2CMdGIdNHXLwZ23+Ft1noabUTfCdBkqEtkBjgMs2ZG+vJCEILeAFmlKjqF7PciTjPQa8W pZnncYxxvlVNK/f9rAiyIE9WDsArNn8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-6QoaGzrnNmyqlM2JvYobbA-1; Tue, 26 Mar 2024 13:39:26 -0400 X-MC-Unique: 6QoaGzrnNmyqlM2JvYobbA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33ec06aac83so3899672f8f.2 for ; Tue, 26 Mar 2024 10:39:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711474765; x=1712079565; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nv03yiZAiZgBWj6kUmes+WMp8CfflptuZICYst0uZlA=; b=ccodvh4KWlpOJnzkENI5OoNBY0w5zwh81qD74puV8/RRFFUeLkAx8rB1CvbmWEldBh H76LwhhLysF6LlHJGgyr/0WheFtLC14qH3LwBHbZ7MSHKRlgJ8E2eQWrlhnaF8o2a+qz Sqq9QAr/v+/omw1zsRWy6MLAuOwHLGwAAtEA9tEXzGkSfyvCywKfLOKUPwpfaZCJXM1i 5OeKLEdsk3AXiQSWap9bkZnFB7Oo+uV1n2MsTE7+Q7FlJVk5kinKpHDaPy385NzI5b0z sRIRZVXCA0NtEfLv2c6fm5dUF6i2jn+juDbbU/4bGJqqkAJiz2YkjwhSt6JsdFyyHXYp q3JQ== X-Gm-Message-State: AOJu0YwGmqEpN1egQhFju6h9dCkROSLbAUc6gHs3Wci0szFvY4tWANTP /qZBDn9C/++q18j5jhQHkWoyz5TEVPP+qP/CzProFK1euXqMWcCxrpZb6pu0164ZNMl2ZqYMUey 0GXmKZGUcY2zBeb9HAvQr23cF1Bb/EluG1VbNjsR8jKLLeQOoKIAdd4PgV4kX+xCSKUdtKD6q X-Received: by 2002:a5d:4805:0:b0:33e:d507:102c with SMTP id l5-20020a5d4805000000b0033ed507102cmr8230435wrq.11.1711474765395; Tue, 26 Mar 2024 10:39:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGStmoliOBFqeiRbrZbk5TvArv1+lSuTgwJ1I7RRDcv7W8w9W+B1NMLOzhmqi9G2xd7QQXHKw== X-Received: by 2002:a5d:4805:0:b0:33e:d507:102c with SMTP id l5-20020a5d4805000000b0033ed507102cmr8230414wrq.11.1711474764893; Tue, 26 Mar 2024 10:39:24 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6b40.dip0.t-ipconnect.de. [91.12.107.64]) by smtp.gmail.com with ESMTPSA id cr8-20020a05600004e800b0033e7715bafasm12736164wrb.59.2024.03.26.10.39.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 10:39:24 -0700 (PDT) Message-ID: <8bd9e136-8575-4c40-bae2-9b015d823916@redhat.com> Date: Tue, 26 Mar 2024 18:39:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 0/4] Reduce cost of ptep_get_lockless on arm64 To: Ryan Roberts , Mark Rutland , Catalin Marinas , Will Deacon , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Andrew Morton , Muchun Song Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240215121756.2734131-1-ryan.roberts@arm.com> <0ae22147-e1a1-4bcb-8a4c-f900f3f8c39e@redhat.com> <374d8500-4625-4bff-a934-77b5f34cf2ec@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_103931_283326_47E11B77 X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26.03.24 18:32, Ryan Roberts wrote: > On 26/03/2024 17:04, David Hildenbrand wrote: >>>>>> >>>>>> Likely, we just want to read "the real deal" on both sides of the pte_same() >>>>>> handling. >>>>> >>>>> Sorry I'm not sure I understand? You mean read the full pte including >>>>> access/dirty? That's the same as dropping the patch, right? Of course if we do >>>>> that, we still have to keep pte_get_lockless() around for this case. In an >>>>> ideal >>>>> world we would convert everything over to ptep_get_lockless_norecency() and >>>>> delete ptep_get_lockless() to remove the ugliness from arm64. >>>> >>>> Yes, agreed. Patch #3 does not look too crazy and it wouldn't really affect any >>>> architecture. >>>> >>>> I do wonder if pte_same_norecency() should be defined per architecture and the >>>> default would be pte_same(). So we could avoid the mkold etc on all other >>>> architectures. >>> >>> Wouldn't that break it's semantics? The "norecency" of >>> ptep_get_lockless_norecency() means "recency information in the returned pte may >>> be incorrect". But the "norecency" of pte_same_norecency() means "ignore the >>> access and dirty bits when you do the comparison". >> >> My idea was that ptep_get_lockless_norecency() would return the actual result on >> these architectures. So e.g., on x86, there would be no actual change in >> generated code. > > I think this is a bad plan... You'll end up with subtle differences between > architectures. > >> >> But yes, the documentation of these functions would have to be improved. >> >> Now I wonder if ptep_get_lockless_norecency() should actively clear >> dirty/accessed bits to more easily find any actual issues where the bits still >> matter ... > > I did a version that took that approach. Decided it was not as good as this way > though. Now for the life of me, I can't remember my reasoning. Maybe because there are some code paths that check accessed/dirty without "correctness" implications? For example, if the PTE is already dirty, no need to set it dirty etc? -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel