linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Xavier <xavier_qy@163.com>
Cc: 21cnbao@gmail.com, ryan.roberts@arm.com, dev.jain@arm.com,
	ioworker0@gmail.com, akpm@linux-foundation.org,
	catalin.marinas@arm.com, gshan@redhat.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, will@kernel.org,
	willy@infradead.org, ziy@nvidia.com
Subject: Re: [PATCH v4] arm64/mm: Optimize loop to reduce redundant operations of contpte_ptep_get
Date: Fri, 9 May 2025 11:25:18 +0200	[thread overview]
Message-ID: <8bdde7df-15d7-4f24-b358-e9ffab0de1d0@redhat.com> (raw)
In-Reply-To: <29f1ebb9.8e60.196b45626fb.Coremail.xavier_qy@163.com>

On 09.05.25 11:17, Xavier wrote:
> 
> 
> 
> At 2025-05-08 16:30:14, "David Hildenbrand" <david@redhat.com> wrote:
>> On 08.05.25 09:03, Xavier Xia wrote:
>>> This commit optimizes the contpte_ptep_get and contpte_ptep_get_lockless
>>> function by adding early termination logic. It checks if the dirty and
>>> young bits of orig_pte are already set and skips redundant bit-setting
>>> operations during the loop. This reduces unnecessary iterations and
>>> improves performance.
>>>
>>> In order to verify the optimization performance, a test function has been
>>> designed. The function's execution time and instruction statistics have
>>> been traced using perf, and the following are the operation results on a
>>> certain Qualcomm mobile phone chip:
>>
>> For the future, please don't post vN+1 as reply to vN.
> 
> I will pay attention to it when I submit it later. Thank you for the reminder.

The rationale is that many people will just treat it as some discussion 
noise as part of vN and not really have a closer look, waiting for vN+1.

-- 
Cheers,

David / dhildenb



  reply	other threads:[~2025-05-09 10:24 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07  9:22 [PATCH v1] mm/contpte: Optimize loop to reduce redundant operations Xavier
2025-04-07 11:29 ` Lance Yang
2025-04-07 12:56   ` Xavier
2025-04-07 13:31     ` Lance Yang
2025-04-07 16:19       ` Dev Jain
2025-04-08  8:58         ` [PATCH v2 0/1] " Xavier
2025-04-08  8:58           ` [PATCH v2 1/1] " Xavier
2025-04-09  4:09             ` Gavin Shan
2025-04-09 15:10               ` Xavier
2025-04-10  0:58                 ` Gavin Shan
2025-04-10  2:53                   ` Xavier
2025-04-10  3:06                     ` Gavin Shan
2025-04-08  9:17         ` [PATCH v1] " Lance Yang
2025-04-09 15:15           ` Xavier
2025-04-10 21:25 ` Barry Song
2025-04-11 12:03   ` David Laight
2025-04-12  7:18     ` Barry Song
2025-04-11 17:30   ` Dev Jain
2025-04-12  5:05     ` Lance Yang
2025-04-12  5:27       ` Xavier
2025-04-14  8:06       ` Ryan Roberts
2025-04-14  8:51         ` Dev Jain
2025-04-14 12:11           ` Ryan Roberts
2025-04-15  8:22             ` [mm/contpte v3 0/1] " Xavier
2025-04-15  8:22               ` [mm/contpte v3 1/1] " Xavier
2025-04-15  9:01                 ` [mm/contpte v3] " Markus Elfring
2025-04-16  8:57                 ` [mm/contpte v3 1/1] " David Laight
2025-04-16 16:15                   ` Xavier
2025-04-16 12:54                 ` Ryan Roberts
2025-04-16 16:09                   ` Xavier
2025-04-22  9:33                   ` Xavier
2025-04-30 23:17                     ` Barry Song
2025-05-01 12:39                       ` Xavier
2025-05-01 21:19                         ` Barry Song
2025-05-01 21:32                           ` Barry Song
2025-05-04  2:39                             ` Xavier
2025-05-08  1:29                               ` Barry Song
2025-05-08  7:03                             ` [PATCH v4] arm64/mm: Optimize loop to reduce redundant operations of contpte_ptep_get Xavier Xia
2025-05-08  8:30                               ` David Hildenbrand
2025-05-09  9:17                                 ` Xavier
2025-05-09  9:25                                   ` David Hildenbrand [this message]
2025-05-09  2:09                               ` Barry Song
2025-05-09  9:20                                 ` Xavier
2025-04-16  2:10               ` [mm/contpte v3 0/1] mm/contpte: Optimize loop to reduce redundant operations Andrew Morton
2025-04-16  3:25                 ` Xavier
2025-04-16 12:47               ` Catalin Marinas
2025-04-16 15:08                 ` Xavier
2025-04-16 12:48               ` Ryan Roberts
2025-04-16 15:22                 ` Xavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bdde7df-15d7-4f24-b358-e9ffab0de1d0@redhat.com \
    --to=david@redhat.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=dev.jain@arm.com \
    --cc=gshan@redhat.com \
    --cc=ioworker0@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=xavier_qy@163.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).