From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B301DC433F5 for ; Mon, 11 Apr 2022 14:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qhLIH07Dptrm5KmVvKy8swB4SeR900tWIJjPehNI8DE=; b=tAoHQKvKDQ4vTO yDHJtWzyZKw47oKQ2JML2Z0TLfdHn7Fb2TYnOJxczJRg8VxOoZpakk7k3XVaxX4bm7NYJQUzZqeia VXlFCJHz2wiDDYqo72VBzO9XRB9KLcRrWomLXAyjSwGTsBKnv1HIoD2EwoAOgs2O+G3U9qegHCO9+ SHSn9aEprC+0LQo2hlMDVh3/xVLlzTIqdgyTUVEL1D2LCniDoLMtVtSikzoLdwYXd7OAmT6NeG9G6 rYGuTiRDHq0IwCf2tcCDzjZ+IwJ1uaCMl3w8/hR/2triZfeebZDvBqe8qWlTIJ1HB27geeybEGJ/L 9lGXuXUDNaReYoknZ5/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nduuO-009Mst-TS; Mon, 11 Apr 2022 14:20:49 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nduuJ-009Mpw-L5 for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 14:20:46 +0000 Received: by mail-wm1-x32b.google.com with SMTP id ay36-20020a05600c1e2400b0038ebc885115so64199wmb.1 for ; Mon, 11 Apr 2022 07:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=S3YV2NIKgVjmZIL+6HS0Sw9C7j5q+F7McJiN2a27ARM=; b=20ghj2lAKcSKoDLZ3O4IapS5ROMbvgbH9y83HJAP2vg5rlqfo+7fgfQl/xaG2Z6xCB vDsq9pLsiPeg3lUfzhbbNcnFfgv5c1iNz4qThO6N6Pi0FD8qjlup/Cgs70dwHM2eEAgk hqZIXj6Ot5j8w/0MMsqzxVcJZ5Rz1Vqibe7mz0E/4AAPZPcoLKGcnVMUDQes+d2ZyBmf jLYpFGwCPesKMISlCF84rw09wqq358l854W0OgVXxcUwh6ukhBdGft368zSvbmwuuQ7r KTaSYOY221gtQYfm3VWVACE9sR6Cx8ZYXCu+g4fsxydNr5oWJzdod0Ey1rWPgfVMO7j3 HCkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=S3YV2NIKgVjmZIL+6HS0Sw9C7j5q+F7McJiN2a27ARM=; b=TaGWNlY+q4hNRrdPYysFJSXPkMtRe9CqxB7eb7lIka51BbDQfnY0TdzcRr3PVulqpC 8Hado4aEEdj1hLFlFkXjLz+ARVnqfqQC53HhrNDOgiG92f3taf/0k6hRdKLWbe6OHlcp WC3YZSiFc6fOXv/b+3yq+KAbV1q4WL54C269nOXrl4BxLObDY4lndLhwLLjQt7Hj2BeO zL8xq1j8TCYhyFr39tVb+iYDNnN39WK+RZnVFkiO8/QUJIT0XA2RwnWWHTUSEUJf0yS7 WWv7FcHDHq7C+fi2ERSwp5I6k07wT0OyDhkFVeaJ7P1fgPUWH89qqWU5q+5mj04rILG5 CNYA== X-Gm-Message-State: AOAM531AZ0eM1kc4DelpEk2TgqGZjgL3Pk2yHhaAvor7FwCXrnqdqxG/ A4ebV74mwjlAlFi/pJrfkM229w== X-Google-Smtp-Source: ABdhPJz4l3beiVULnQnS8K5T65hNj8lZdcPe3356nB8I4dOfBr0ZFNRG6vebaEI++CwpGxdZPwvo5Q== X-Received: by 2002:a05:600c:3546:b0:38c:a8ff:843b with SMTP id i6-20020a05600c354600b0038ca8ff843bmr29729336wmq.24.1649686839724; Mon, 11 Apr 2022 07:20:39 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:d1:e096:d183:1bc5? ([2001:861:44c0:66c0:d1:e096:d183:1bc5]) by smtp.gmail.com with ESMTPSA id k124-20020a1ca182000000b0038eb706c030sm4974012wme.39.2022.04.11.07.20.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 07:20:39 -0700 (PDT) Message-ID: <8bde8ee2-ee3f-bba6-66da-28adb3897178@baylibre.com> Date: Mon, 11 Apr 2022 16:20:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 Content-Language: en-US To: Guillaume Giraudon , kernel-dev@prism19.com Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220411140401.450-1-ggiraudon@prism19.com> From: Neil Armstrong Organization: Baylibre In-Reply-To: <20220411140401.450-1-ggiraudon@prism19.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_072043_970334_EFCEC251 X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 11/04/2022 16:04, Guillaume Giraudon wrote: > The labels for lines 61 through 84 on the periphs-banks were offset by 2. > Realigned them to match the Banana Pi M5 schematics. > > Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") > > Signed-off-by: Guillaume Giraudon > --- > arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > index 5751c48620ed..754c3d43ef0b 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > @@ -448,7 +448,7 @@ > "", > /* GPIOA */ > "", "", "", "", "", "", "", "", > - "", "", "", "", "", "", > + "", "", "", "", "", "", "", "", > "CON1-P27", /* GPIOA_14 */ > "CON1-P28", /* GPIOA_15 */ > /* GPIOX */ While reviewing more closely I figured that in fact the issue comes from the : /* BOOT */ "eMMC_D0", /* BOOT_0 */ "eMMC_D1", /* BOOT_1 */ "eMMC_D2", /* BOOT_2 */ "eMMC_D3", /* BOOT_3 */ "eMMC_D4", /* BOOT_4 */ "eMMC_D5", /* BOOT_5 */ "eMMC_D6", /* BOOT_6 */ "eMMC_D7", /* BOOT_7 */ "eMMC_CLK", /* BOOT_8 */ "", "eMMC_CMD", /* BOOT_10 */ "", "eMMC_RST#", /* BOOT_12 */ "eMMC_DS", /* BOOT_13 */ /* GPIOC */ it contains 14 entries, but there is 16 BOOT gpio lines. So instead, send a V2 with 2 entries added in BOOT and leave the GPIOA entries as-is. Thanks, Neil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel