From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A27C2C433F5 for ; Mon, 21 Feb 2022 13:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kB9nEjDmCsGAUV4HFnvuGegvGl+r37HRboVMqQOCjQ8=; b=CjDiA/HdgVrPfM RR5uAFgoSQBhaH3KuigBGx3skpxuxAKrtJJOICmVrRjxxGMJC7lGoC/ra88fy8uP3Cf1GR7rPbx50 i+Yx/UhjDvokWHfjuEwNgjGe/t+2nOnLqIjzsr9rbd8Tjg+iGRnpMypLrPDDZAyXTaz6QervrbjT/ OdV/9qJoIzru/AoKGqZYGCXnOtrtdhzNt/xlU342Pb25aEvKJy2VqLMmSPWtEtZuhLjj6hN7AiMBs Kdv+SjmZ1ZE5HbpGMHrzSWHxj497vjbaElWwNjUas8gxboHUNAdIQyjrc42bx9y+xo4XymcTQa3d9 LjBUw5FAyu6mceRa85og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM8vf-005yVT-Mk; Mon, 21 Feb 2022 13:40:40 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM8Sg-005ojd-F8; Mon, 21 Feb 2022 13:10:44 +0000 X-UUID: a2e47522b35c4dae95038e6d0a8cc731-20220221 X-UUID: a2e47522b35c4dae95038e6d0a8cc731-20220221 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 846233884; Mon, 21 Feb 2022 06:10:37 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Feb 2022 05:00:35 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Feb 2022 21:00:34 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 21 Feb 2022 21:00:33 +0800 Message-ID: <8bfd46477e482e0979f30f9a68005a464ce2739e.camel@mediatek.com> Subject: Re: [PATCH v2 06/23] arm64: dts: mt8192: Add usb-phy node From: allen-kh.cheng To: AngeloGioacchino Del Regno , Matthias Brugger , Rob Herring , --to=Krzysztof Kozlowski CC: , , , , , Chen-Yu Tsai , Ryder Lee , "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" Date: Mon, 21 Feb 2022 21:00:33 +0800 In-Reply-To: <7ce0bf47-b0c9-b6e6-92f3-b7a11b3adfd5@collabora.com> References: <20220218091633.9368-1-allen-kh.cheng@mediatek.com> <20220218091633.9368-7-allen-kh.cheng@mediatek.com> <7ce0bf47-b0c9-b6e6-92f3-b7a11b3adfd5@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_051042_614288_A3F700A2 X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-02-18 at 13:55 +0100, AngeloGioacchino Del Regno wrote: > Il 18/02/22 10:16, Allen-KH Cheng ha scritto: > > Add xhci node for mt8192 SoC. > > > > Signed-off-by: Allen-KH Cheng > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 25 > > ++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > index 61aadd7bd397..ce18d692175f 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -875,6 +875,31 @@ > > #clock-cells = <1>; > > }; > > > > + u3phy0: usb-phy@11e40000 { > > + compatible = "mediatek,mt8192-tphy", > > + "mediatek,generic-tphy-v2"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > This can be better: > #address-cells = <1>; > > #size-cells = <1>; > ranges = <0 0 0x11e40000 0x1000> > > Hi Angelo, Thanks for your surgestion, this's good for me, I will update in next version. Best regards, Allen > > + status = "okay"; > > + > > + u2port0: usb-phy@11e40000 { > > u2port0: usb-phy@0 { > > > + reg = <0 0x11e40000 0 0x700>; > > reg = <0x0 0x700>; > > > + clocks = <&clk26m>; > > + clock-names = "ref"; > > + #phy-cells = <1>; > > + status = "okay"; > > + }; > > + > > + u3port0: usb-phy@11e40700 { > > + reg = <0 0x11e40700 0 0x900>; > > u3port0: usb-phy@700 { > reg = <0x700 0x900>; > > > + clocks = <&clk26m>; > > + clock-names = "ref"; > > + #phy-cells = <1>; > > + status = "okay"; > > + }; > > + }; > > + > > i2c0: i2c@11f00000 { > > compatible = "mediatek,mt8192-i2c"; > > reg = <0 0x11f00000 0 0x1000>, > > Thanks, > Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel