From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F458D6552C for ; Wed, 17 Dec 2025 10:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:Cc :References:In-Reply-To:Subject:To:From:Date:Message-ID:Reply-To:MIME-Version :Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xyc3IDIZf0WjzB63IEEZKtBHdQbPoJ6n2GC6PHGoAUc=; b=2c5Fh8PXFII/XD0vhEfpqpAWAR PKTcGpFGjS6EtciFdBry/EqjdpK+nXQdr4SwU3Alj1D5y1s2evK3ohwTAx8+PIUjbzxb6m43JGAxq nUuLg1mQnmuJahjMb06ERsQ8BtJdlmY/38/yx8MkwqE7egOxolwtLrMq6xnTbxsxC3GbmEV2wQasc 2UeuxQe5KbI0gdZ9V3ZB6VBgJygjQS+oWFS9QA4Lf5O2BHv/jJ54Bv5y6ypptigONF3H7xY9IV8cH mryxqqxgBUVgdBONrlv0YLrwFDQrAf/BzFRWJ1zEypxPsivdFia/8hx89QGO+NWfngKP5vnnPFT5G elRRnS1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVoeB-00000006cEq-32xJ; Wed, 17 Dec 2025 10:20:43 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVodl-00000006bnD-2Ttx; Wed, 17 Dec 2025 10:20:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C59AE60555; Wed, 17 Dec 2025 10:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F227FC116B1; Wed, 17 Dec 2025 10:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765966816; bh=uJcpfVPMB5gnCFhr0GcBKgfEw4ZGLD1pSQ+VPptDnGA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=fWTsxN7hsVbEvFoHdM6FW8j9okypSLWVz4W+Thu9wMM85IQfe2/WjcxyGZdvVTO8E p/okodvwcbtKo+t9xQw4ARUx93vm5VZCuXD5CucY9HkDBc22WjJFHVTepCCs79M8MK lac76+FdHwSrHTregOjA7q4jZjIzZCJl7OcB+38XgVVjAHePMdeLej+Ppksd1NqQjq PiBLkLZ3qgP1x/4u0Loq8WswRoO+SIVHu+8XLWZ4ecn3Fw70JwMH8+q/rex5V5pKQK iIQZTA4QTqoqeBnO2pNWrd28eBBgfZLtjoZWfWnQ0WDquBqA3ald1dm9uphm3D0HlJ woHzxM1OGr8IQ== Message-ID: <8c0e9399c1f8bb388eb3f0ee2cf37089@kernel.org> Date: Wed, 17 Dec 2025 10:20:14 +0000 From: "Maxime Ripard" To: "Luca Ceresoli" Subject: Re: [PATCH v3 15/22] drm/bridge: imx8qxp-pxl2dpi: imx8qxp_pxl2dpi_find_next_bridge: return int, not ERR_PTR In-Reply-To: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-15-b5165fab8058@bootlin.com> References: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-15-b5165fab8058@bootlin.com> Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Alexey Brodkin" , "Andrzej Hajda" , "David Airlie" , "Fabio Estevam" , "Hui Pu" , "Jernej Skrabec" , "Jerome Brunet" , "Jonas Karlman" , "Jonathan Corbet" , "Kevin Hilman" , "Laurent Pinchart" , "Liu Ying" , "Maarten Lankhorst" , "Martin Blumenstingl" , "Maxime Ripard" , "Neil Armstrong" , "Pengutronix Kernel Team" , "Phong LE" , "Robert Foss" , "Sascha Hauer" , "Shawn Guo" , "Simona Vetter" , "Thomas Petazzoni" , "Thomas Zimmermann" Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 16 Dec 2025 18:58:48 +0100, Luca Ceresoli wrote: > In preparation for using bridge->next_bridge, we need to ensure that it > will never contain anything but NULL or a valid bridge pointer. Current > code stores an ERR_PTR when imx8qxp_pxl2dpi_find_next_bridge() errors > out. Instead of fixing that after the facts in the caller, change the > function to internally set the next_pointer and just return an int error > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime