From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BD0CC433FE for ; Fri, 18 Nov 2022 17:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nKKSqaT43mTwVFwg32FQu1BCWWroOHS03JJNhiQPgI8=; b=SKMsw7kHo1mcwP p4zzDCRdQ+MWFi1xEIOQBBaNyZCjvRPBYYvClhEAc0SPtfFGD8zggoTVyuY/u4Vpm1Gf3RC2GvKl9 C2SquRAsXqb6qrrQzBoiWrAYNiwjhywiFEvAPX1dLk/Q6iMhPVxoKLf6+Mpv/7aogF66yBJ0+9CA6 TOHkxSL2Tr6Oe+CAJkaHoKBmrfIrGN3McDRYGLh11ZmGGgkz/Y5bCyGfpSN9znhDLqNeD9CuUpOYt 0s7LHP7/uZAbwACMurHXnzeW9ZwUvln5dWIOpFxj4EQDL2z9fgVx5oRPkpuSBcpcyNoAocJgiOUyT i2ldvvpKPH7C8HSFaxpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow5bQ-0067Jd-0x; Fri, 18 Nov 2022 17:56:36 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow5bN-0067Hb-7F for linux-arm-kernel@lists.infradead.org; Fri, 18 Nov 2022 17:56:34 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AIHuSH9060725; Fri, 18 Nov 2022 11:56:28 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668794188; bh=fEXsV3TD0XyH+BXYuxbAlTRcrFjFQrVVL3bi6Q6mMIE=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=VuYuIJES0iiZCYxStWKQoqQNC90VKsazhvom5/eAB3uJzlxa+jopkbDH6bjgUZhAC +t8VILBvxXpk3e/Zca/YyQIcYzI4ths47fL+vP5mDh3QeuBLpkSLwJvjttvslG6lS1 IedEjNbQRgUSFw2mKE0LzAn7TEjHJbt6fY9gvuJU= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AIHuSt6125149 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Nov 2022 11:56:28 -0600 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 18 Nov 2022 11:56:28 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 11:56:28 -0600 Received: from [10.250.38.44] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AIHuR7w110433; Fri, 18 Nov 2022 11:56:27 -0600 Message-ID: <8c123fa2-caab-d2dd-5eb4-688f1c6abb33@ti.com> Date: Fri, 18 Nov 2022 11:56:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 4/4] arm64: dts: ti: Add support for J784S4 EVM board Content-Language: en-US To: Nishanth Menon CC: Apurva Nandan , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Linus Walleij , , , , , Hari Nagalla References: <20221116130428.161329-1-a-nandan@ti.com> <20221116130428.161329-5-a-nandan@ti.com> <20221118174754.y37pq77drvla2uxj@tinderbox> From: Andrew Davis In-Reply-To: <20221118174754.y37pq77drvla2uxj@tinderbox> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_095633_374206_82D9C500 X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/18/22 11:47 AM, Nishanth Menon wrote: > On 11:40-20221118, Andrew Davis wrote: >> On 11/16/22 7:04 AM, Apurva Nandan wrote: > > [...] > >>> +#include >>> +#include >>> +#include "k3-j784s4.dtsi" >>> + >>> +/ { >>> + compatible = "ti,j784s4-evm", "ti,j784s4"; >>> + model = "Texas Instruments J784S4 EVM"; >>> + >>> + chosen { >>> + stdout-path = "serial2:115200n8"; >>> + }; >>> + >>> + aliases { >>> + serial2 = &main_uart8; >> >> This feels hacky. Your chosen node picks serial2 as that is usually >> the one that is wired up on K3 boards. But on this board it is main_uart8. >> So why not have this be serial10, then choose >> >> stdout-path = "serial10:115200n8"; >> >> Also, I've made comments on previous version of this series, it is >> nice to include folks who have commented before in the CC for future >> versions, that way our filters don't hide these away and we can more >> easily check that our comments have been addressed. > > Please stick with the standard of serial2 as the linux console standard. > We ended up with that to ease up capabilities of various distros to > uniformly work across SoC and board variants. > The chosen "stdout-path" is for setting the kernel's default output terminal. Distros and other userspaces need to use their own policy mechanisms for picking what serial port to run getty on or whatever the issue may be. Some look at the kernel command line, and our bootloader provides that too, so still no reason to fake alias names here. Andrew > I do agree that phandle is the wrong approach here (baud etc information > missing). "serial2:115200n8" is probably the way to do this right. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel