From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5ADE4C369AB for ; Fri, 11 Apr 2025 08:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Jl+tlJmSDf0nnbSrgovsTaB8wRik7QXQeYCpheusSk=; b=EtiKFJC0c4NhpvjUWQfDWc0Vmn g4uFePJsZZ/rBVt25IWQFsx2Qw3kSWEXzB7leiOIDFmvZ8l5SFsQmAS5Ra4u+BbLmILv66xbZ21fb Ve/sGCGXzOAEHiQmy4IRUPGp1WaGYVHUBmCBbTlRbkKxicmy7P08p+Ik97O8KGOtRK97B/KGxtfGf d+RIEMNn4TINPoVf6kgI47Dw7ks1rLzvhXHIXPp/IaWJdib2NgttFsZJTj5BdmLnUFCvAiahTvaCr +NFWE141YQaTWMQjflT76Luecegg1zecLjdiQXfq/62ddbo224Twp7wMpEEdpkWzxJuorvYl1CmOB swAMyQuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3ADN-0000000D6f4-13ZF; Fri, 11 Apr 2025 08:58:21 +0000 Received: from cpanel.siel.si ([46.19.9.99]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u39Al-0000000Cwv9-28HU for linux-arm-kernel@lists.infradead.org; Fri, 11 Apr 2025 07:51:37 +0000 Received: from [89.212.21.243] (port=53044 helo=[192.168.69.116]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1u39Ai-003jxP-2O; Fri, 11 Apr 2025 09:51:32 +0200 Message-ID: <8c41e55a-1fcd-4bac-9e1b-3dfdcc7d3e9d@norik.com> Date: Fri, 11 Apr 2025 09:51:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] arm64: dts: freescale: imx93-phyboard-segin: Add RTC support To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, upstream@lists.phytec.de References: <20250410090251.1103979-1-primoz.fiser@norik.com> <20250410090251.1103979-10-primoz.fiser@norik.com> Content-Language: en-US From: Primoz Fiser Autocrypt: addr=primoz.fiser@norik.com; keydata= xjMEZrROOxYJKwYBBAHaRw8BAQdAADVOb5tiLVTUAC9nu/FUl4gj/+4fDLqbc3mk0Vz8riTN JVByaW1veiBGaXNlciA8cHJpbW96LmZpc2VyQG5vcmlrLmNvbT7CiQQTFggAMRYhBK2YFSAH ExsBZLCwJGoLbQEHbnBPBQJmtE47AhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQagttAQducE+T gAD+K4fKlIuvH75fAFwGYG/HT3F9mN64majvqJqvp3gTB9YBAL12gu+cm11m9JMyOyN0l6Os jStsQFghPkzBSDWSDN0NzjgEZrROPBIKKwYBBAGXVQEFAQEHQP2xtEOhbgA+rfzvvcFkV1zK 6ym3/c/OUQObCp50BocdAwEIB8J4BBgWCAAgFiEErZgVIAcTGwFksLAkagttAQducE8FAma0 TjwCGwwACgkQagttAQducE8ucAD9F1sXtQD4iA7Qu+SwNUAp/9x7Cqr37CSb2p6hbRmPJP8B AMYR91JYlFmOJ+ScPhQ8/MgFO+V6pa7K2ebk5xYqsCgA Organization: Norik systems d.o.o. In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: primoz.fiser@norik.com X-Authenticated-Sender: cpanel.siel.si: primoz.fiser@norik.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250411_005135_703962_610878CE X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, On 10. 04. 25 17:12, Frank Li wrote: > On Thu, Apr 10, 2025 at 11:02:47AM +0200, Primoz Fiser wrote: >> Add support for RTC clock connected via I2C on phyBOARD-Segin-i.MX93. >> Make I2C RTC the default clock by configuring the aliases. > > "Add support for RTC connected via I2C on phyBOARD-Segin-i.MX93. Set > default RTC by configuring the aliases." > > Frank >> >> Signed-off-by: Primoz Fiser >> --- >> .../dts/freescale/imx93-phyboard-segin.dts | 36 +++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts >> index 525f52789f8b..38b89398e646 100644 >> --- a/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts >> +++ b/arch/arm64/boot/dts/freescale/imx93-phyboard-segin.dts >> @@ -17,6 +17,11 @@ /{ >> compatible = "phytec,imx93-phyboard-segin", "phytec,imx93-phycore-som", >> "fsl,imx93"; >> >> + aliases { >> + rtc0 = &i2c_rtc; >> + rtc1 = &bbnsm_rtc; >> + }; >> + >> chosen { >> stdout-path = &lpuart1; >> }; >> @@ -33,6 +38,24 @@ reg_usdhc2_vmmc: regulator-usdhc2 { >> }; >> }; >> >> +/* I2C2 */ >> +&lpi2c2 { >> + clock-frequency = <400000>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_lpi2c2>; >> + status = "okay"; >> + >> + /* RTC */ >> + i2c_rtc: rtc@68 { >> + compatible = "microcrystal,rv4162"; >> + reg = <0x68>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_rtc>; >> + interrupt-parent = <&gpio4>; >> + interrupts = <26 IRQ_TYPE_LEVEL_LOW>; >> + }; >> +}; >> + >> /* Console */ >> &lpuart1 { >> pinctrl-names = "default"; >> @@ -56,6 +79,13 @@ &usdhc2 { >> }; >> >> &iomuxc { >> + pinctrl_lpi2c2: lpi2c2grp { >> + fsl,pins = < >> + MX93_PAD_I2C2_SCL__LPI2C2_SCL 0x40000b9e >> + MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e >> + >; >> + }; >> + >> pinctrl_uart1: uart1grp { >> fsl,pins = < >> MX93_PAD_UART1_RXD__LPUART1_RX 0x31e >> @@ -69,6 +99,12 @@ MX93_PAD_SD2_RESET_B__GPIO3_IO07 0x31e >> >; >> }; >> >> + pinctrl_rtc: rtcgrp { >> + fsl,pins = < >> + MX93_PAD_ENET2_RD2__GPIO4_IO26 0x31e >> + >; >> + }; >> + > > keep order by node name. > pinctrl_uart1 was out of order since beginning. I will create a separate patch to this series ordering nodes alphabetically as a last step. OK? > Frank >> pinctrl_usdhc2_cd: usdhc2cdgrp { >> fsl,pins = < >> MX93_PAD_SD2_CD_B__GPIO3_IO00 0x31e >> -- >> 2.34.1 >> -- Primoz Fiser phone: +386-41-390-545 email: primoz.fiser@norik.com -- Norik systems d.o.o. Your embedded software partner Slovenia, EU phone: +386-41-540-545 email: info@norik.com