From: Markus Elfring <Markus.Elfring@web.de>
To: Henry Martin <bsdhenrymartin@gmail.com>,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Arnd Bergmann" <arnd@arndb.de>,
"Gabriel Somlo" <gsomlo@gmail.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Joel Stanley" <joel@jms.id.au>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH v3] drivers/misc: Add NULL check in aspeed_lpc_enable_snoop
Date: Mon, 31 Mar 2025 18:15:46 +0200 [thread overview]
Message-ID: <8cd011a2-67af-47bd-a05a-905eb333180b@web.de> (raw)
In-Reply-To: <20250331154002.14128-1-bsdhenrymartin@gmail.com>
> devm_kasprintf() returns NULL if memory allocation fails. Currently,
…
call? failed?
> The corrected code adds error checking and optimizes resource release logic
…
See also once more:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n94
An other subsystem specification might be more desirable.
https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/soc/aspeed/aspeed-lpc-snoop.c?h=next-20250331
* May the array access be simplified another bit here?
* How do you think about to store a pointer to a corresponding data structure member
in an additional local variable?
Regards,
Markus
next prev parent reply other threads:[~2025-03-31 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 15:40 [PATCH v3] drivers/misc: Add NULL check in aspeed_lpc_enable_snoop Henry Martin
2025-03-31 16:15 ` Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-01 3:39 Henry Martin
2025-04-01 7:09 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cd011a2-67af-47bd-a05a-905eb333180b@web.de \
--to=markus.elfring@web.de \
--cc=andrew@codeconstruct.com.au \
--cc=arnd@arndb.de \
--cc=bsdhenrymartin@gmail.com \
--cc=gsomlo@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox