From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10014C433E0 for ; Thu, 11 Mar 2021 13:51:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 806DE64F8E for ; Thu, 11 Mar 2021 13:51:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 806DE64F8E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mPaiDzA43fByE+F05Hytj4nmxM0FBBbinJo0/lEv8cA=; b=Y+jz6FtFY96aiifCJdnxThb0s oP4m1qYIBW6IDFHvCqVNq23OMHIZN0jZXFuyQ8rk386usm/5wb89Rjemzpx57e4rUjxA7NXYgfrHi zX+o6A2xABDfAzfuWBOEplXFi0m1xDlXNA9FMOpZfvJbN7hRtTf0nGrBEkpQ1WQ1iS5XWpFxEE2Ma 2mBiafCQChmbHbLLG5B4qrxFwHNHqFTcCVP/HJvVA0gv/QXDdf6bMHHFmOWrumR/Hda48rsD/BLin 7kXeGNvLnlcXReqHGGpDrk9V51iEVu4qwx/dW5PdDmRQLYU32koGEPTgTV8jedq4+eSHR5JN/P1gY ULhBV9vJA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKLgs-009Frc-5g; Thu, 11 Mar 2021 13:49:26 +0000 Received: from gecko.sbs.de ([194.138.37.40]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKLgo-009Fpv-0x for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 13:49:24 +0000 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 12BDnIsa002139 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:49:18 +0100 Received: from [167.87.35.81] ([167.87.35.81]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 12BDiHqf005503; Thu, 11 Mar 2021 14:44:17 +0100 Subject: Re: [PATCH v4 3/3] arm64: dts: ti: Add support for Siemens IOT2050 boards To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Le Jin , Bao Cheng Su , Vignesh Raghavendra References: <9bff40f434e5298890e5d139cc36cc46a0ca2d76.1615369068.git.jan.kiszka@siemens.com> <20210311131754.i5ewls6hgeitcgre@astonish> From: Jan Kiszka Message-ID: <8d076ff1-cdac-941f-e796-a2e6dba792ab@siemens.com> Date: Thu, 11 Mar 2021 14:44:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311131754.i5ewls6hgeitcgre@astonish> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_134922_167816_452EB827 X-CRM114-Status: GOOD ( 27.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.03.21 14:17, Nishanth Menon wrote: > On 10:37-20210310, Jan Kiszka wrote: >> From: Jan Kiszka >> + spidev@0 { >> + compatible = "rohm,dh2228fv"; >> + spi-max-frequency = <20000000>; >> + reg = <0>; > > Jan, > > As part of my final sanity checks, I noticed that we missed this: is a checkpatch warning > > WARNING: DT compatible string "rohm,dh2228fv" appears un-documented -- check ./Documentation/devicetree/bindings/ > #629: FILE: arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi:581: > compatible = "rohm,dh2228fv"; > > I cannot pick up nodes that are'nt documented as yaml in > Documentation/devicetree > > I know this is irritating to find such nodes that already have previous > users and the person coming last gets to deal with "new rules".. but > sorry for catching this so late. > > Here are the options that come to mind: > > option 1) - drop the node and resubmit. > > option 2) - get the documentation into linux master tree and then submit > the patches. > As you said, I'm not setting a precedence here: arch/arm/boot/dts/imx28-cfa10049.dts: compatible = "rohm,dh2228fv"; arch/arm/boot/dts/rv1108-elgin-r1.dts: compatible = "rohm,dh2228fv"; arch/arm/boot/dts/socfpga_cyclone5_socdk.dts: compatible = "rohm,dh2228fv"; drivers/spi/spidev.c: { .compatible = "rohm,dh2228fv" }, Was just just never documented as binding? Or why is no one allowed to use this anymore? What is to be used instead for spidev? > > I think we should just drop the node and resubmit - since this is a more > intrusive change and I don't have your platform handy, I am going to > suggest you make a call :( This breaks userspace here, and we would need to carry that node on top. BTW, I already brought up the topic internally to get you some boards for testing. > > Additionally please install yamlint and dtbs_schema -> run dtbs_check. I > see more than a few warnings there which may need some closer look. > I've done that and addressed all that I could (former patch 4). We import those from k3, and I don't feel confident how to resolve them. See also v1 of this patch. Jan > > A full log against linux-next is here: https://pastebin.ubuntu.com/p/qR69h28c5f/ > > > PS: https://github.com/nmenon/kernel_patch_verify/blob/master/kpv > > I have been using my script to verify with kpv -C -V -n num_patches and > then digging through the logs. > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel