From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] serial: 8250: let serial8250_get_divisor() get uart_port * as param
Date: Wed, 04 Jul 2018 13:00:11 +0300 [thread overview]
Message-ID: <8d29c0ab0c3a6bc3e9bdf3d4bc54d47e7db8cc94.camel@linux.intel.com> (raw)
In-Reply-To: <20180704170040.39ac9cf3@xhacker.debian>
On Wed, 2018-07-04 at 17:00 +0800, Jisheng Zhang wrote:
> Align serial8250_get_divisor() with serial8250_set_divisor() to accept
> uart_port pointer as the first parameter. No functionality changes.
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> drivers/tty/serial/8250/8250_port.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c
> b/drivers/tty/serial/8250/8250_port.c
> index cf541aab2bd0..709fe6b4265c 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -2498,11 +2498,11 @@ static unsigned int npcm_get_divisor(struct
> uart_8250_port *up,
> return DIV_ROUND_CLOSEST(port->uartclk, 16 * baud + 2) - 2;
> }
>
> -static unsigned int serial8250_get_divisor(struct uart_8250_port *up,
> +static unsigned int serial8250_get_divisor(struct uart_port *port,
> unsigned int baud,
> unsigned int *frac)
> {
> - struct uart_port *port = &up->port;
> + struct uart_8250_port *up = up_to_u8250p(port);
> unsigned int quot;
>
> /*
> @@ -2636,7 +2636,7 @@ serial8250_do_set_termios(struct uart_port
> *port, struct ktermios *termios,
> cval = serial8250_compute_lcr(up, termios->c_cflag);
>
> baud = serial8250_get_baud_rate(port, termios, old);
> - quot = serial8250_get_divisor(up, baud, &frac);
> + quot = serial8250_get_divisor(port, baud, &frac);
>
> /*
> * Ok, we're now changing the port state. Do it with
> @@ -3197,7 +3197,7 @@ static void serial8250_console_restore(struct
> uart_8250_port *up)
> termios.c_cflag = port->state->port.tty-
> >termios.c_cflag;
>
> baud = serial8250_get_baud_rate(port, &termios, NULL);
> - quot = serial8250_get_divisor(up, baud, &frac);
> + quot = serial8250_get_divisor(port, baud, &frac);
>
> serial8250_set_divisor(port, baud, quot, frac);
> serial_port_out(port, UART_LCR, up->lcr);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-07-04 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 8:59 [PATCH v2 0/3] serial: 8250_dw: add fractional divisor support Jisheng Zhang
2018-07-04 9:00 ` [PATCH v2 1/3] serial: 8250: let serial8250_get_divisor() get uart_port * as param Jisheng Zhang
2018-07-04 10:00 ` Andy Shevchenko [this message]
2018-07-04 9:02 ` [PATCH v2 2/3] serial: 8250: introduce get_divisor() and set_divisor() hook Jisheng Zhang
2018-07-04 10:00 ` Andy Shevchenko
2018-07-04 9:03 ` [PATCH v2 3/3] serial: 8250_dw: add fractional divisor support Jisheng Zhang
2018-07-04 16:08 ` Andy Shevchenko
2018-07-05 6:39 ` Jisheng Zhang
2018-07-05 6:54 ` Jisheng Zhang
2018-07-06 17:39 ` Andy Shevchenko
2018-07-06 17:37 ` Andy Shevchenko
2018-07-09 6:04 ` Jisheng Zhang
2018-07-09 6:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d29c0ab0c3a6bc3e9bdf3d4bc54d47e7db8cc94.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).