From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33B78C433EF for ; Thu, 26 May 2022 06:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X82/OGBOI7OCyMCFNjCYAZUbtixDOCsrolppX8sIz0M=; b=ZrTJRNU/EC+NV1 ghQz2QVzVgYc+I5sHoljtGS7BbDWSCMfRn5izKvrIlGATZjw/nhjDRsNFWFSPd0sKMZVfgktZ+4Vy rIH6W7oDOGSCO93IJ1Lj3xPn336nG2hSYU+0PwX6S6J5YqQF/0yGCiL6H/izqT4T81lbY1ZQYPwvr jPgg+IXrQzbdqwEn+1TBD4WtX/10yhixfMt3ks/weopLn9dVHTqazaWYeQG3s78374EmmeLGsX46J ajFkE/KrTfWjTERePj8eiLy6MwlL9WZVUoHXkN2PG5pIni4ITCaiqjBcdzpiZkPXDNTh0ImnEtlCX SosZchQ36w6t2ukUu9Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu7Nj-00Df5Z-12; Thu, 26 May 2022 06:54:03 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu7Nf-00Df38-Op for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 06:54:01 +0000 Received: by mail-ej1-x636.google.com with SMTP id gi33so1295615ejc.3 for ; Wed, 25 May 2022 23:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+OlWFNuXubaG+wIbcU6S2PD/trjlRQ/H0QdDAVlC7L8=; b=HTSbKdqa3Nz+rgnORHSDlCCrWGmPxq/uTvVIJ1mdxP93fxi23p4/iaudQGQ0yvJ9qD sVCbrRfo4bBZ9mQRMOESsrCFhgNGIGplr+gRzybCAWSTUbTrkEc8qWTZ4+OL34B9gBo5 dOF8MFYMdEGZrlkLcq9wisY90Wjy5NOu5xRch0PKTnXgXXXoQiEdUGSOr8epjCyfTbVS Dr28G81aHk81OulVCikCIbagbO+Y4eDk0jAdcfnyEEMK2ynz5Uduj5WXS6eh/HElm7AY yhKdPVZCKYG7q/YHZlKZoSErjnkxy2vKC9OXBJfkrBc3mnIe3F9Jp3DD8FlhwnTPS8Hy kCZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+OlWFNuXubaG+wIbcU6S2PD/trjlRQ/H0QdDAVlC7L8=; b=ZE4Tnc9svdt+HHE4Y8LDVsTpK1hZnAfVCOHRN6Q7G/GHvL34riRwD0KKKSe9B+ABxq Gpg3PaIoXGGeoCTtFW5tIx8A5TRO9bPqL2od1hKWf0xyqWDod5em1jHrQr2Atg7qhZz5 k45JRKOeftqfHFBOvKPkfxX/2g1lkvjPvn4DhyHgjEAdrrHEJFfgG0moHZU+OsHIKORM 5pR0Y248Fsb0bIQMwyjRDmf6GUARqEULfhWxjs0rp2k1RnmMGrR6B66YEPUZZ4Ifv6PL 9sUyLZZbVR4k1mqvdE9y5WyFnpUtzEKdM7M5j9tWZC16ERTWbhBDiFBb2npXG6Q/B0Pf uDow== X-Gm-Message-State: AOAM530uCFJY3GEZvaODlZr6fxHfDPRYwfdi0K5IoNmAZUQqq1YeFb5H /4Ypc2rCU/3pD7c0CugVkaa70w== X-Google-Smtp-Source: ABdhPJxK0GdBqnqhHeFKnB17hFODfbqtX8jNbVhbmw+n/G8WMqDopEGaBisjwS7Dq3PBf+ZqYanNVA== X-Received: by 2002:a17:906:9b90:b0:6ff:a02:1f9 with SMTP id dd16-20020a1709069b9000b006ff0a0201f9mr9350097ejc.672.1653548036203; Wed, 25 May 2022 23:53:56 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id x65-20020a50bac7000000b0042617ba63absm389060ede.53.2022.05.25.23.53.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 23:53:55 -0700 (PDT) Message-ID: <8d2c9375-63d7-6d36-8a0b-6c5d117cc213@linaro.org> Date: Thu, 26 May 2022 08:53:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Content-Language: en-US To: Brad Larson Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-12-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_235359_857197_2E8813A6 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/05/2022 02:19, Brad Larson wrote: > Hi Krzysztof, > > On Thu, Apr 7, 2022 at 12:06 PM Krzysztof Kozlowski > wrote: >> >> On 07/04/2022 01:36, Brad Larson wrote: >>> Add Pensando common and Elba SoC specific device nodes >>> >>> +&spi0 { >>> + num-cs = <4>; >>> + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, >>> + <&porta 7 GPIO_ACTIVE_LOW>; >>> + status = "okay"; >>> + spi0_cs0@0 { >> >> Generic node name needed matching the class of a devicxe. > > The device on this spi bus is a FPGA with 4 functions and looking at > other projects I've changed it to a resource-controller node name. On > cs0 there is a sub-device reset-controller added in the upcoming > patchset to enable hardware reset of the eMMC device. > >>> + compatible = "semtech,sx1301"; /* Enable spidev */ >> >> This comment is a bit odd... did you just use random compatible from >> spidev instead of defining proper compatible? > > Yes, because adding a compatible was nacked. We have a driver added > (two actually, mfd and reset driver) for the next patch update. Yeah, but using some other one is also not correct. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel