From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Nikita Shubin <nikita.shubin@maquefel.me>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/10] ASoC: cirrus: edb93xx: Drop legacy include
Date: Wed, 29 Nov 2023 23:35:24 +0100 [thread overview]
Message-ID: <8d6a9317cd45f2841020e091000344f5683c11a4.camel@gmail.com> (raw)
In-Reply-To: <20231129-descriptors-sound-cirrus-v1-7-31aa74425ff8@linaro.org>
Hi Linus,
On Wed, 2023-11-29 at 22:28 +0100, Linus Walleij wrote:
> This driver includes the legacy GPIO API <linux/gpio.h> but
> does not use any symbols from it.
>
> Drop the include.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
This file is going away as well at some point,
Link: https://patchwork.kernel.org/project/alsa-devel/patch/20231122-ep93xx-v5-38-d59a76d5df29@maquefel.me/
> ---
> sound/soc/cirrus/edb93xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/cirrus/edb93xx.c b/sound/soc/cirrus/edb93xx.c
> index 6b6817256331..8bb67d7d2b4b 100644
> --- a/sound/soc/cirrus/edb93xx.c
> +++ b/sound/soc/cirrus/edb93xx.c
> @@ -11,7 +11,6 @@
> */
>
> #include <linux/platform_device.h>
> -#include <linux/gpio.h>
> #include <linux/module.h>
> #include <linux/soc/cirrus/ep93xx.h>
> #include <sound/core.h>
--
Alexander Sverdlin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-29 22:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 21:28 [PATCH 00/10] ASoC: Convert Cirrus codecs to GPIO descriptors Linus Walleij
2023-11-29 21:28 ` [PATCH 01/10] ASoC: cs35l32: Drop legacy include Linus Walleij
2023-11-29 21:28 ` [PATCH 02/10] ASoC: cs35l33: Fix GPIO name and drop " Linus Walleij
2023-11-29 21:31 ` Mark Brown
2023-11-29 21:28 ` [PATCH 03/10] ASoC: cs35l34: " Linus Walleij
2023-11-29 21:28 ` [PATCH 04/10] ASoC: cs35l35: Drop legacy includes Linus Walleij
2023-11-29 21:28 ` [PATCH 05/10] ASoC: cs35l36: " Linus Walleij
2023-11-29 21:28 ` [PATCH 06/10] ASoC: cs4271: Convert to GPIO descriptors Linus Walleij
2023-11-29 22:32 ` Alexander Sverdlin
2023-11-29 21:28 ` [PATCH 07/10] ASoC: cirrus: edb93xx: Drop legacy include Linus Walleij
2023-11-29 22:35 ` Alexander Sverdlin [this message]
2023-11-29 21:28 ` [PATCH 08/10] ASoC: cs42l42: " Linus Walleij
2023-11-29 21:28 ` [PATCH 09/10] ASoC: cs43130: Drop legacy includes Linus Walleij
2023-11-29 21:28 ` [PATCH 10/10] ASoC: cs4349: Drop legacy include Linus Walleij
2023-11-30 9:58 ` [PATCH 00/10] ASoC: Convert Cirrus codecs to GPIO descriptors Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d6a9317cd45f2841020e091000344f5683c11a4.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=hsweeten@visionengravers.com \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).