From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF4CC433DB for ; Mon, 22 Feb 2021 12:46:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30E8B64DF0 for ; Mon, 22 Feb 2021 12:46:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30E8B64DF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rByJtYxjb0Gvo0FXwet9A2wDRy/le8fM1w7z85DDU7k=; b=IIz+d+MkjKlKc4UYA4U7D5CFF /TLcLmIB3y4QAA4sL1+H0OZc7ZXfS49x9LVwMNENqRWBT2bMjYDVIzvKUxQvvk7KIrKcR0llGZpKm 7h4frFNEF2Qu1TgA8JXeDukssG3rPOCL+ppaQGZPxTlZ3Oj/YAaM9NxriP8QEuTMT/5ZFEAiU/g8b dUjEC3yTIVVA4ZlGOT0JfxnDCBz/ZE1hiGWYBrExWZXf/L5FNBJLjuUIIFfCAJLsYy0VOSGdKwriY hX+ZCwY8Mlvkfstd0voC3BbEpp6uiAMnsKAOjPE2G3Gy9yrP6vqij5IZfNwSEW/SXGQ0ZN+rlb4X9 jwEQOKb4w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEAaY-0006t5-7K; Mon, 22 Feb 2021 12:45:22 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEAaV-0006sg-M0 for linux-arm-kernel@lists.infradead.org; Mon, 22 Feb 2021 12:45:20 +0000 Received: from [192.168.0.114] (unknown [49.207.208.227]) by linux.microsoft.com (Postfix) with ESMTPSA id D5C6B20B6C40; Mon, 22 Feb 2021 04:45:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D5C6B20B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1613997914; bh=0cItSrOHNyqAnHmYlMTDJGOB4+40TVteNywMP5altWI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=S3opWeTuHjAN4qY/hX6uq5/M2WjhFUhmr0tuz2c0Py7eyP7QBLEFjbQHSe5KTYoEG qg2ou051HmRjivkRNBMs5ii9KUYdRE4ur3owyF1Hqr9aqEwUuOQ/yDQZS2cx0CvTy6 SJTC53nhIk598tm7DvObgpudGc3MEObOHOwwZNzA= Subject: Re: [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot To: Dhananjay Phadke , allen.lkml@gmail.com, jens.wiklander@linaro.org, zajec5@gmail.com References: <20210217092714.121297-2-allen.lkml@gmail.com> <20210217092714.121297-2-allen.lkml@gmail.com> From: Allen Pais Message-ID: <8d87655f-27c6-6a66-6eb0-9244279fbf2c@linux.microsoft.com> Date: Mon, 22 Feb 2021 18:15:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210217092714.121297-2-allen.lkml@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210222_074519_905650_9A94049D X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: op-tee@lists.trustedfirmware.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote: >> - /* >> - * Ask OP-TEE to free all cached shared memory objects to decrease >> - * reference counters and also avoid wild pointers in secure world >> - * into the old shared memory range. >> - */ >> - optee_disable_shm_cache(optee); >> + if (shutdown) { >> + optee_disable_shm_cache(optee); >> + } else { >> + /* >> + * Ask OP-TEE to free all cached shared memory >> + * objects to decrease reference counters and >> + * also avoid wild pointers in secure world >> + * into the old shared memory range. >> + */ >> + optee_disable_shm_cache(optee); > > Calling optee_disable_shm_cache() in both if and else. It could be > put in front of if(). > Ideally, I could just use optee_remove for shutdown() too. But it would not look good. Hence this approach. - Allen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel