From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B21EDC982ED for ; Mon, 21 Sep 2026 22:03:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kIsY3P9pXrWyESUdvHXPJV8L9IlYB5o6HTWVCOxBPec=; b=20cRpSQ1KJhDchEdsaLN7nNzcs +iQpkzeY6zPR1pfkEhwGAIE3A081edilM36ls5/dUWT3g7Xj3rHLiT00l2P9l+12RK3S/HPXxC2OF oBrM3BpMaXXIzhZHdw6WbAoJ4U2CrTClElzGmrzx8W2Pfy0HoOJNS1qJMV4G/+h6p5u1RPtxH8d7x JpxoGNV43DQGb9LJ+rhEyxMS1YzXkdbxbJWhM/GM+FG+wt4XJnqv2U3CIApOFUD6JXqk0SPZIBXlG FRz64giG5eox6dwxo9rVCEDF+6cWKdtHT41CshIwHeBV54bsXjW+aOYjYQr4seQYqJb++u4nZrAbL pMr/F2vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8m6f-00000003WuE-2RRs; Mon, 21 Sep 2026 22:03:25 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8m6e-00000003WtP-0Dlv; Mon, 21 Sep 2026 22:03:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=kIsY3P9pXrWyESUdvHXPJV8L9IlYB5o6HTWVCOxBPec=; b=gcHYhl+QqoVLin8sJJgAWhyvL9 FP90WgjCLRUs3j2rK8kpnWRi1FG895Ox/TFrYF11jRYFArWZVw//ogRyXWZ0tWPxkEKpBDIcdNbiY DiBNy3Nv3oGb5bv86IffIoH6Esw9i4hFky6Vydhv3e4+ESVeWM7KTe1d/r7nuA75GiTLNOHyTBQhx yKTV91Gv2o4WY+l6/SVH+oGEyzTJ9PwuAF45ypyqyGleVlE5ZDkF6WRCgsFqZMNxnY3ZiLA/Xit0V IufeeiMrIcLgIbEbVyadm570lo5mYZyuNfcDaenHQ1CGolPayVXRB+6mFvTDBuHytOkXdcDfS4oje 6jOmjp+w==; Received: from mail-centralusazon11010028.outbound.protection.outlook.com ([52.101.61.28] helo=DM1PR04CU001.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x8m6A-0000000Cro5-09xE; Mon, 21 Sep 2026 22:03:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uzWOj4nioa02IUeIoBcsiVbNJ3VwFoevuGXs7ufrNlSZIkeDSy7XOn6p7BmWlbEW1JBxmLvM8Drd+EQVQxM3yNQBvLPg7uv+MkfvIkpBWo6mskuPL/rSQCk3XUWURprd3SRwB1coyRl++nmKO3UCEf5y2ctpnv8wR4xE+1BP5MSB6ZEKDGIPZTqEGd3NQCLhyvAYmY8hwc8Yty4EGzdnH24FhqdVn7Ou2yg9fS48J5WGBqApIHWc+dYmE+LPVEGKYfaDyQT43eyHQqjQXm8BNAKATcwhbfNGK/vLZz//W7ttNI1j4IIEHD+GD6z1lAdgC99u0E/JPz210Ysr4q3IrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kIsY3P9pXrWyESUdvHXPJV8L9IlYB5o6HTWVCOxBPec=; b=IHUmtfBonDlls2eQHUEn+E26xxqjmmef+VEPx9UyY7IGlrerUK7onp7xgK6oROU8SK+j2xboC29NUAHdMCwFYldIJkC82xdG5hF5HU0w46iJUjxTnw+IKmMB26nHpfTBCQ8yQXtrBV+8RHfUX/WpGYvmDd4y+bcIvtLt7CbgrOp+y0t/DynO5OVrNG7FihKUe1xcRWcUXq1j1Hxcl6AAuUAA3FEGTmzXzYz63T9hhu1xRON3j/SL1LaQMp7rCFybErYuVlsegMAP+RdhgqAii1j0MbYRlUtKIASwSb1UG3tCgNO8xxCf5TZkpDeYx0gnMAF+7tBk/9rHTztslOHkDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=collabora.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kIsY3P9pXrWyESUdvHXPJV8L9IlYB5o6HTWVCOxBPec=; b=lZUJ0zdaHicwdHU3dqv3ma9Sxgbb8NihpG9eXspyUbPg1P5Mn5kRgfiVAPazNTY4Xe2D9wAh4+sHBDwjceHxc9U+09dKi7b7D8QHMtzIHxAzTK1WrBW76JK3Ovuu6dAIRC8b+fMiKS8qWncyWGfB0LP84jL4/yOCV01dg5RbNY0= Received: from MW4PR04CA0107.namprd04.prod.outlook.com (2603:10b6:303:83::22) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.16; Mon, 21 Sep 2026 22:02:13 +0000 Received: from SJ1PEPF000023D5.namprd21.prod.outlook.com (2603:10b6:303:83:cafe::1c) by MW4PR04CA0107.outlook.office365.com (2603:10b6:303:83::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.16 via Frontend Transport; Mon, 21 Sep 2026 22:02:13 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SJ1PEPF000023D5.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.0 via Frontend Transport; Mon, 21 Sep 2026 22:02:12 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Mon, 21 Sep 2026 17:01:51 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Mon, 21 Sep 2026 17:01:50 -0500 Received: from [10.254.92.51] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.49 via Frontend Transport; Mon, 21 Sep 2026 17:01:48 -0500 Message-ID: <8dbfd32d-547c-4b38-b3b3-460c4b666a72@amd.com> Date: Mon, 21 Sep 2026 18:01:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 03/25] drm/atomic-helper: Set mode_changed on vrr_enabled change To: Nicolas Frattaroli , "Borah, Chaitanya Kumar" , Daniel Stone , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Helge Deller , Andrzej Hajda , Neil Armstrong , "Robert Foss" , Laurent Pinchart , Jonas Karlman , "Jernej Skrabec" , Luca Ceresoli , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan CC: , , , , , , Derek Foreman , References: <20260921-vrr-limiter-uapi-v1-0-2fcd7d011646@collabora.com> <20260921-vrr-limiter-uapi-v1-3-2fcd7d011646@collabora.com> Content-Language: en-US From: Leo Li In-Reply-To: <20260921-vrr-limiter-uapi-v1-3-2fcd7d011646@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D5:EE_|MN2PR12MB4208:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e7a7293-aed9-43ea-5711-08df182bfdca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|42112799006|376014|82310400026|23010399003|36860700016|921020|10067099003|56012099006|11063799006|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: nv1FHu48KGmcV7evD5BGx88lYN73sAsLwLRXWyqcsaAwdHyykA37roWT8R0oHy/UnYp+kHHrRMKXJ4Dej/661D+yoe6umVts7KnJETnbzmbyP5PnxWCgJztAsEavBmZagNeRKU7dsFDMcUx49EiEhQ6GgvrvvyCnuUeULDzre/1bWr9v3sK3n6XIAQvakx6AfROt7IwiCrXtf0auQq6HicqCEIwhTcfsTcVunBV3Xz3ffkwsaQP2jnaRp12ptlf5U9ZBDd33V9BhtgppQnccOzoGti3LsSvhB7sBduLaTOpmMC1YG9uTbdAEMlXOZOtvIexzuOlp1vSRj5Yvuda2rJjj6HWrYycN0uKXREvTV5k7j19tQNd3+AGhCZ+kd5O9vV5vVmAoHM85q81LefPFEVYZoqVY7ire+Of+OnJzI8WsOJVYHwU58ZQCC9vPQygi9Zu1LE5NtAOcBa/jgU6PzWxpLJb5dOc9fYdiOjS+AG7/Ms1DfnNF43E698j90eo4qbdxfJzvZmJSBlCxHJuqWf5F52n4ywmekuL5P+niruJhF08r89RYbzKxMIRG5LgkqBx9q+QdfiXN/etdYp5zpd979y+Gd84jXsKIMyM+sa35tQGoj6Pbn1glnbI8pnLw13K5Td0rRXbSLKR2tVYYGLUlh5xvUfhPrDbPHzO88oyWvFxvYRMzFoaK15D3PKyRjO7L5iVQluLJYEF26KNI2jBmLyuI5eJY2OO9p58DuFSLHfpkLhWYueL0mA/HyzC3 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(42112799006)(376014)(82310400026)(23010399003)(36860700016)(921020)(10067099003)(56012099006)(11063799006)(4143699003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OGZIcnmE6jmUPw4Htb01gzEQi6qShUCr4lbW64bMq2Nxd787Y2jEX3eGLIaj1nceqlL1AM41hFN4+ezBMWeadb0zooPxXhUxcp6O/HLPXAVC2WJCjcrfBOfE7uyhC70+pXtvOlYlPhlB3YPIlnEaQhFIkOLn/9t3Tl9PDF+htLbMG1NkOIRLlx5nx4QACEsTEk1dMoivcfHtzYlQ2oDMKJI666J84YSnXAO9l0vnUz1ASTvVyxKc7Ib9fxRzVpwHJQkIkcUkWIqzz1OEiRzIH4OyCF4WRDlLyFLjFPNEoS9K4Ow0zDMaCmUaABqLab0xW3z9gpEaPm+9/2YGX7NI967OYizv/6+LCmhJmkk+MgobJwi29QoDtW3wHNvB1BCR6Ochu5turjc/7oaBAu2+oUvbzOm02YYzyd4yLwecrAsdTVjIZF2jmW0kdsJPG684 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2026 22:02:12.9463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e7a7293-aed9-43ea-5711-08df182bfdca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D5.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260921_230315_329461_03E60C58 X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicolas, Thanks for sending this out. I'm looking into an amdgpu implementation and had some comments along the way. Will reply inline on respective patches. On 2026-09-21 11:51, Nicolas Frattaroli wrote: > A change in whether VRR is enabled or not on a CRTC will be of interest > to any VRR implementation, as they may need to recalculate certain > internal state in response. So far, this was handled ad-hoc in the > drivers that implement VRR. > > Handle this in the common DRM atomic core by setting the mode_changed > flag when this occurs. The rationale for using mode_changed is that VRR > is deeply intertwined with the current mode with regards to its timing. > Consequently, any component that cares about a mode change is likely > also going to care about VRR being enabled/disabled. > > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/drm_atomic_helper.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index 9d006f98413a..0664d5779282 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -694,6 +694,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, > new_crtc_state->active_changed = true; > } > > + if (old_crtc_state->vrr_enabled != new_crtc_state->vrr_enabled) { > + drm_dbg_atomic(dev, "[CRTC:%d:%s] VRR changed\n", > + crtc->base.id, crtc->name); > + new_crtc_state->mode_changed = true; > + } > + I don't think this is the case for all vendors, at least not for amdgpu. The parts in HW that adjust vtotal can be programmed without requiring bandwidth recalculations or reprogramming of pipes. - Leo > if (new_crtc_state->enable != has_connectors) { > drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch (%d/%d)\n", > crtc->base.id, crtc->name, >