From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98019C54E71 for ; Fri, 22 Mar 2024 08:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZszvhkGwODpSJ67TfWwmUTwyl9Xqea2ZIlYCKM0ZMcY=; b=pjwXlRUahYaF1A cnpvJh+GoRdP+QfqJHrHd3QfYH92QcuqJXksX9Cy87HA9c76UmQyW49owmsMsRR6qzE0BfkdnGg/o YpQs6G/IJ2UdLIA+cGV7lRnuP3vNl0jzMlCns1uqryqrJfA/Sthq2xw5QWVzEoF6zBcYUqo0t3/jw 0z6Qzu6ipAzxrKL7ox0/6kluV7mQDHI/uhv+9gemWlMtG0/ba5D7/sVT24UdR1MyEllwuO27MLd8M J2t077XSeK4iN288vn6TUVoGYLMpK6ctshzq8glGrpIe5RRGW0d/b1XqJGfHfHviDy/myCpZiEGJN t3nrXN5YPH9tL1xblVDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnaix-00000006SGD-21Gc; Fri, 22 Mar 2024 08:58:03 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnaiu-00000006SEr-1ZvO; Fri, 22 Mar 2024 08:58:01 +0000 X-UUID: 4540ca66e82a11ee9aa9374d6d45775a-20240322 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=y93COKfMsv04qr+QQZMP+3e90TGCw0CQgDGRJywz/q4=; b=Th072qmUnZtm91vJLFc/VRnNghUtlDpvIcmf+ySItzVL7DzBMIBZsY/S4EMrsXG7j1sBOuFeE4tNNuFrtmcA7ZTKpq/baasYIL4iX9P+MZlyzEAav5Inf3C33QhGS9+JNGH51/uB1Oo2D35ntBAIz/WHo7zWMKjQ6k5fE7foD8s=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:2d0ec0fb-626b-416c-86aa-72153d0eb915,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6f543d0,CLOUDID:f416b690-e2c0-40b0-a8fe-7c7e47299109,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: 4540ca66e82a11ee9aa9374d6d45775a-20240322 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 824437682; Fri, 22 Mar 2024 01:57:54 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 22 Mar 2024 16:57:16 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 22 Mar 2024 16:57:16 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f44j1q7JTjaq9Hh6FVGvF0dguO0jASsdlBnszU2Smy8eOutETtlfguAh7wYeQbABp2GH4hMDFC69qYz9QFPtz2+hcMOcBLiCdvyqMGu6u6Bem6rNJ9gs+VVONQiNfp3Trg5UXEmmP8U3P8Cqv9+RRBanxlkFuyr7y38w3ckE6sAyW/qK1Yq8+V1heJHti8vQr7yqeELtnzjlFEfM7if/rmIKFolBMvDMzk+GFD2uw2veirTSfub7pzFLVQxpMHioqC7c1rcRAmv4WGfkh6F0jC0xPoNg3gnrfR7R4VWBx+IJvte2uchqjcrg5Zz3g2xVyZmibJevT4Bcr6tcwJ5XSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y93COKfMsv04qr+QQZMP+3e90TGCw0CQgDGRJywz/q4=; b=Kc4koqe4TNw1/sDbKbYj9VIqILZr4MTH5rgsKbkn3dmswdgp87JMQ4zbQYduq09e+2tnwHcFuY4Z6pfYRrfzeaUiwkowGgsv92Bqt6KgSmEeJdBizy9S1jkdZZyQYbeMN3MB9drAXJDjv3ymKCO32Kk74eNqqH6FqMbPe+/+TdD9sGcA1NeGlW0pLCdv/fvYLhYQy0qu+fUCeDsHBixBzbnCqP/52fejkWjnDdL5OtZmubBNZ2YE3g66+mfXCT96Gmkl2vGU/gP/PzkzPdDSVkdcUYGp+RCkW+bSfYPf2Dx+HNiuo6BSU+LxC+QXAGPs9dXX6MWWhmUWyqdadODVBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y93COKfMsv04qr+QQZMP+3e90TGCw0CQgDGRJywz/q4=; b=QUhB8t8QPhFFFB1GRko/731+mzWNTdTNeOJ0SV5WbeA2noV+NmG+lmnu3jYCziFtemiusDl2cL5/7x0DfZ6A+925SP8WwT2VjiI97VtkJKF4z+wQBmzRISczNSoNclBYDXCuyxuuh5ClWiEXjRepvzs5HXWk/7hCaMqydDZ6n4M= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by TYZPR03MB9096.apcprd03.prod.outlook.com (2603:1096:405:db::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 08:57:14 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::f3b6:91a7:e0fb:cb27]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::f3b6:91a7:e0fb:cb27%7]) with mapi id 15.20.7386.031; Fri, 22 Mar 2024 08:57:14 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: "angelogioacchino.delregno@collabora.com" , "chunkuang.hu@kernel.org" CC: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "wenst@chromium.org" , "kernel@collabora.com" , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "daniel@ffwll.ch" , "p.zabel@pengutronix.de" , "dri-devel@lists.freedesktop.org" , =?utf-8?B?TmF0aGFuIEx1ICjlkYLmnbHpnJYp?= , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" Subject: Re: [PATCH 3/3] drm/mediatek: drm_ddp_comp: Add mtk_ddp_is_simple_comp() internal helper Thread-Topic: [PATCH 3/3] drm/mediatek: drm_ddp_comp: Add mtk_ddp_is_simple_comp() internal helper Thread-Index: AQHaVQ2pRdVwz+/UpEitDOuNRhxQxrFDw8GA Date: Fri, 22 Mar 2024 08:57:14 +0000 Message-ID: <8de69b0bb56a36374a9dac87da9bbd6ea3143a7e.camel@mediatek.com> References: <20240201125304.218467-1-angelogioacchino.delregno@collabora.com> <20240201125304.218467-4-angelogioacchino.delregno@collabora.com> In-Reply-To: <20240201125304.218467-4-angelogioacchino.delregno@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|TYZPR03MB9096:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oYd5RPhhWoyqVRsB8iWUpy8245tC55V3TPwGDpUH8apgAG1/mqwNAAn5M66DpM4MoSRuXJKJ/SNDKgt5OFPr3NOVwlZy+UM+zCqe/zihHQPztfQ7VnJREQTWj9RZadpPzpzj01DzLRi/uQ5ANMaJ+ER0x9/tX/tjflqw0IFPSJ+eOsS4XFuVlDcIlW06mRwGyVcqbYWIuNflUClHGZLm0Pj0t8IkP6bPm7vjTekX2ogZpkXYwEA2EmwPAqzPvf6e61syD2XDA5m8E6RlTXhvYe0S1Y9UEB3ZOR/rYinjOsFlo1YcoflVwLJp4pKtdDtWRDTksjbrsidgTZoEFsdjEaLueSFw+2rHikOUu8EGum4MdBFeLBNH9tla19GwTMHz58p9XlzUG5WvmnNGFKllJcqoDwcKwCfrdXVH2xi5MUSZ4vWsgHjaUPE5QOv2NytoI5Xqkdp6JspBzV0MSsOs2yPSy11+47/TMhaTkZJzz5XXFfCFRoRuTFosk4wnktqdKsnEKfwTriEAiSSl1V7+pPrs/VU9eXgbDeyWyZvpkZJ0GQNPSCBiC+f2BXblg/kMEHKlwYSlN8UZw+kWDzYYizdV+3sRte2P93kww9iScA+GOc8jYTfKofac7pboLC0awnCwUakK/w2xq7meuo9AIMs+IOpk4aO4Lnh/doepMPg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005)(7416005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cjF1aDN4c1dqRHM0SmozbE1xMDZnMUE4SEdqY2RvU25RUjFjNC9Bb1FwWVhL?= =?utf-8?B?SDlaWWJVOTBpZVB6WXFpbTlQcmJPV2I1czQ3aG00U0ZzZzFKUUd6SGhEL3VV?= =?utf-8?B?TU5MTkpTZDNDc0ZUYnYrWi9WeFRhM0xUUVEvb2lGTkZZbWwwMGdpVFVHNGZ5?= =?utf-8?B?NUNzZjIyVjZSUXl0QzV5MXRkcmZLQzZVKzg4ZW1LV3pHZ1o3a2VSWnpQQlhr?= =?utf-8?B?V3hCdHZtKzJrZHQyMUgyRHdlT3NhT3JPNzVjVUpjOVdUelhpTEo5MmV5anJ6?= =?utf-8?B?VzJXNm02eS9Yc0Z2QjNiczNTYWhBbzJPZUF6b05mTmVGS1JzVCthZzlScHVj?= =?utf-8?B?U2U5RW5QQW5jVm1xVzdhWmtPTWt1ZkgyTndLeTk4NlhJd1N6dnVMZWlBTzIx?= =?utf-8?B?TU5LOVFDL2wrbGV4NmZEQVQ1QmtXcGdvMEpqVGZkdDhmdnhKdys4Y0NXMHc1?= =?utf-8?B?cE12Z0dnSGlQMzJYY0dWOGJlWmpoT0htS0gwNEF5SkFUV3NUQzBXcHJUOW9H?= =?utf-8?B?MC9UWHg4MmxVaFBEN3ZXbEYrVHhhazhJMUt3SGMwM05mVTJVOGRNdk1JbFpR?= =?utf-8?B?c0kzREJneE4vaHdnYVl5OVdhUXYzaGdENnRaL1NDQXg1U0IzbHFFMC9lMFpn?= =?utf-8?B?MEltZWRpUjdnUldyOERrbGNVN1laUjBweUh4MTllK3JiQ3lybzdRU1owbDVh?= =?utf-8?B?RGtrcFNDbDlBYklLdHgwbFoyLzlFU0FlQVVQVFBReFNwcmxyNzc0ZU5CdG9x?= =?utf-8?B?L1p5SnFiOUM5N20xRmN2d0M1bXByN25UdDByNFAwMjV2enlDaUR5VzZYS1hp?= =?utf-8?B?ZENvdUUrM204a3pYQi8xTjZtelAzNmpIc01xdkNtNmxjZ3VhRWR2SjdRQ013?= =?utf-8?B?VXMydXRDRXU1K3NLWlZhd2dMSWFnQWhVOVZCcm5kUzNXYkJ0TjlkYUhXTG1r?= =?utf-8?B?L1dya0pSbGt4RG8vank1VUI3ME9pakx0ZkptT1ljczVwTzVTZGdPVWhyYzgv?= =?utf-8?B?cjRDTTRxRGI4QWw0ZGs2S3NxMEFTVG9HRjliUkxNdWVaRG9SYXBFYVdqRjFM?= =?utf-8?B?alZ5OFF5QjNTNmptWHdiTW9KUFJDNXJzR1JPaHZrOUcxNFdXTStWMWR1Wldn?= =?utf-8?B?Y1J5cEhBMm42bjByWWluRHJsaGdEWjFEZFJ6N294cTY3aVdadFBYd1hnVGFv?= =?utf-8?B?SExBeStmKzIxSHF6WFNWM3lYSDFFWFQ3czJHcjJ5dDBHNnF5VDZBaURpMGpz?= =?utf-8?B?alZJWGNubTlnd2lFd1lkQjNWcUVxVXA3RUVNeW1SdkJ3YWF6RGloN04xNmVa?= =?utf-8?B?T3ZkYlUrRXV2bGI0Z0pIaTZlMkJKaHB3OVlJb293cmhDdURiRWZrN1p0UGdH?= =?utf-8?B?Z3pnK1dpYnlnVjVNNnpMWHN2YUhEWFpsS0VDOGdwNHhxckRzdnJHeXd5WjE3?= =?utf-8?B?OUZxN3pqUmZqVjJ3SmVLODMzNysyVUVQVVUwSTBjL1FseEQ3STNYM3ViK0Fk?= =?utf-8?B?WDhZK1ZYM0ZXZ1dNU3B2NG83SzluaGFpSHJvdHBKNGlScDFRSkZDN205bWpj?= =?utf-8?B?cG5uUmM2NFpHQ0RqNDZoT210YitFR0JIUlVYdzZNVUtkSFBRcXlyVU5qRmQ5?= =?utf-8?B?VWhVUXZNanZhQVNFYjJqbVZNc21XZVU3UlRGWDk4VHNKRGcralVaeDEvTnAv?= =?utf-8?B?RVR4Wkh0dU50bGd2dGVwcE9jQlJFR0dwQmQvaWkycitPNjdZbVZueGUwVTdM?= =?utf-8?B?RGVFeUE0WE9nYmNGT0lQT1c0ZEdxRjBMcHNuWWNvOFcxaFJTbndLZHhxNnQ1?= =?utf-8?B?MFZLRnU0M0xiQlBwdFdUMkVLbzl5WlN1bzN1cVlSZGZUVGd5bWJ3d3d5TkJS?= =?utf-8?B?SjZjeU8zRUNiQmh6ckhLbXJ5ZGc2alE2UmQ1SHFtSWhKOVFiQWQ1cFYyR3RY?= =?utf-8?B?akZYVjlGeDVYbmhmSlF2OUkwVXZVaE9qZjdIZVIwYXFzb2Nha3NlWDBiTCtB?= =?utf-8?B?b3Bsb1ZWMmJCN25pNHBlTEVmcVlvQmh0bU1TTTg0b3l2WUNYVDlWckJtWmov?= =?utf-8?B?U3hQYVhFc1ZoeDFIdXVaU082NHNrcUJySWFmVnM0K2h6Mk03RG50MElRTVc4?= =?utf-8?Q?wJLBD7vYYlRNX/jr5SA9Kut9Y?= Content-ID: <182986F103D6E247A7682C1DBE202EBA@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 069c673e-c4d1-4dcf-99da-08dc4a4e118e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 08:57:14.1924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TEZdK8ZHcVv4/hELppoeZCGMLw3KoQPoJWCxrtB/VgahRG7Oc/rbZ1mnr6J19Gu6SJ+2xJ01lV68QhLSyvyD8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB9096 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--10.889400-8.000000 X-TMASE-MatchedRID: scwq2vQP8OHoSitJVour/UD6z8N1m1ALjLOy13Cgb4+iUP5F9sCEMHWC d6QvVzbec7qzI+uYRDhc7/JU/kbLPiUtdpGicV4RA9lly13c/gEK3n1SHen81QqiCYa6w8tvgSk lFxt6Wp1TbZQcBI0zQonn/zXNcpP/sn/vLFz1kV/NkY5AMBHm58nlJe2gk8vIBlt4RZwvTdWvek lZ9sa6cQWTjR3U9Qe5H87q17mgoOqvvxILmKK/HNIFVVzYGjNKWQy9YC5qGvz6APa9i04WGCq2r l3dzGQ1FdpkPxxOT27DcOlGCl8B4CoTtL1M6a222OqjJjDGQc/RU+S57ZpPJw== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.889400-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 6F94DB207CC8949D1286B52A9DB71AD8109D018BDDD78B20406D23A8521B85D22000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_015800_437984_6EE639D2 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Angelo: On Thu, 2024-02-01 at 13:53 +0100, AngeloGioacchino Del Regno wrote: > Move the simple component check to a new mtk_ddp_is_simple_comp() > internal helper to reduce code duplication. Reviewed-by: CK Hu > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 57 +++++++++++------ > ---- > 1 file changed, 31 insertions(+), 26 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 539b526a6b0a..4ca2a02ada3c 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -575,6 +575,29 @@ unsigned int > mtk_drm_find_possible_crtc_by_comp(struct drm_device *drm, > return ret; > } > > +static bool mtk_ddp_is_simple_comp(enum mtk_ddp_comp_type type) > +{ > + switch (type) { > + case MTK_DISP_AAL: > + case MTK_DISP_BLS: > + case MTK_DISP_CCORR: > + case MTK_DISP_COLOR: > + case MTK_DISP_GAMMA: > + case MTK_DISP_MERGE: > + case MTK_DISP_OVL: > + case MTK_DISP_OVL_2L: > + case MTK_DISP_OVL_ADAPTOR: > + case MTK_DISP_PWM: > + case MTK_DISP_RDMA: > + case MTK_DP_INTF: > + case MTK_DPI: > + case MTK_DSI: > + return false; > + default: > + return true; > + } > +} > + > int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp > *comp, > unsigned int comp_id) > { > @@ -605,19 +628,13 @@ int mtk_ddp_comp_init(struct device_node *node, > struct mtk_ddp_comp *comp, > } > comp->dev = &comp_pdev->dev; > > - if (type == MTK_DISP_AAL || > - type == MTK_DISP_BLS || > - type == MTK_DISP_CCORR || > - type == MTK_DISP_COLOR || > - type == MTK_DISP_GAMMA || > - type == MTK_DISP_MERGE || > - type == MTK_DISP_OVL || > - type == MTK_DISP_OVL_2L || > - type == MTK_DISP_PWM || > - type == MTK_DISP_RDMA || > - type == MTK_DPI || > - type == MTK_DP_INTF || > - type == MTK_DSI) > + /* > + * Resources for simple components are retrieved here as those > are > + * managed in here without the need of more complex drivers; > for > + * the latter, their respective probe function will do the job, > so > + * we must avoid getting their resources here. > + */ > + if (!mtk_ddp_is_simple_comp(type)) > return 0; > > priv = devm_kzalloc(comp->dev, sizeof(*priv), GFP_KERNEL); > @@ -651,19 +668,7 @@ void mtk_ddp_comp_destroy(struct mtk_ddp_comp > *comp) > return; > > /* Complex components are destroyed with their own remove > callback */ > - if (type == MTK_DISP_AAL || > - type == MTK_DISP_BLS || > - type == MTK_DISP_CCORR || > - type == MTK_DISP_COLOR || > - type == MTK_DISP_GAMMA || > - type == MTK_DISP_MERGE || > - type == MTK_DISP_OVL || > - type == MTK_DISP_OVL_2L || > - type == MTK_DISP_PWM || > - type == MTK_DISP_RDMA || > - type == MTK_DPI || > - type == MTK_DP_INTF || > - type == MTK_DSI) > + if (!mtk_ddp_is_simple_comp(mtk_ddp_matches[comp->id].type)) > return; > > priv = dev_get_drvdata(comp->dev); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel