From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CA04E784B7 for ; Mon, 2 Oct 2023 14:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2R7VflzF7etEA9cMprzl9QWuChYZ5jyO00L7n8wtCDY=; b=mQ/4dKQ+93rDhl F/nUl91e66H+tx71OWunG5ghI+C94CtIJEQbfVUwjmeSQCG3nwUa2M72bwXezTtzV2NotC+7XUOQQ Kvn6G1oE/irLJ5umcIjs6QkwDjxe28z+2v+Xx4jJwdCPLGQeXwHVj2v31x3j/hDf7bVTfWO3yFuvl lsEFlcm4n3C4EAez8geMckUllEffMBDrdIge/WiguGhAleOFLupGGNwNRq1oXkpfJA2mbsBrYC6QD MVQRZggiEoxl59KdyaK4Icl5VnRDGfZyDP1RMABhBFdrdZF9EZCRMuIdVL9DnDAtgkVFyC5mxeyVa bs9Mzl6VFrinmry1uZyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnK6m-00Ctzj-08; Mon, 02 Oct 2023 14:41:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnK6i-00CtzM-2L for linux-arm-kernel@lists.infradead.org; Mon, 02 Oct 2023 14:41:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD35CC15; Mon, 2 Oct 2023 07:41:48 -0700 (PDT) Received: from [10.57.1.112] (unknown [10.57.1.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0CD773F762; Mon, 2 Oct 2023 07:41:07 -0700 (PDT) Message-ID: <8de7702c-797f-9aa8-0ca3-bd8d6b7f39db@arm.com> Date: Mon, 2 Oct 2023 15:41:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/7] coresight: tmc-etr: Add support to use reserved trace memory Content-Language: en-US From: James Clark To: Linu Cherian Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, sgoutham@marvell.com, gcherian@marvell.com, Anil Kumar Reddy , mike.leach@linaro.org References: <20230929133754.857678-1-lcherian@marvell.com> <20230929133754.857678-3-lcherian@marvell.com> <7e5e1007-1f6c-f212-8f3d-a5f640614055@arm.com> In-Reply-To: <7e5e1007-1f6c-f212-8f3d-a5f640614055@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231002_074112_808845_D79155F1 X-CRM114-Status: GOOD ( 23.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/10/2023 15:28, James Clark wrote: > > > On 29/09/2023 14:37, Linu Cherian wrote: >> Add support to use reserved memory for coresight ETR trace buffer. >> >> Introduce a new ETR buffer mode called ETR_MODE_RESRV, which >> becomes available when ETR device tree node is supplied with a valid >> reserved memory region. >> >> ETR_MODE_RESRV can be selected only by explicit user request. >> >> $ echo resrv >/sys/bus/coresight/devices/tmc_etr/buf_mode_preferred >> >> Signed-off-by: Anil Kumar Reddy >> Signed-off-by: Linu Cherian >> --- >> .../hwtracing/coresight/coresight-tmc-core.c | 51 +++++++++++ >> .../hwtracing/coresight/coresight-tmc-etr.c | 87 ++++++++++++++++++- >> drivers/hwtracing/coresight/coresight-tmc.h | 24 +++++ >> 3 files changed, 161 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c >> index 7ec5365e2b64..1e94215ac148 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-core.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c > > [...] > >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c >> index 834674feb6b4..fca82eaf073f 100644 > > Hi Linu, > > I think this version of coresight-tmc-etr.c isn't in the tree and it > makes it hard to apply the set. Do you have local changes? Or if it > requires other patches it might be best to host the full set on your own > repo and link to it: > > $ git show 834674feb6b4 > fatal: ambiguous argument '834674feb6b4': unknown revision or path not > in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > > Thanks > James Sorry just saw the note at the top of the cover letter about the other patches. > _______________________________________________ > CoreSight mailing list -- coresight@lists.linaro.org > To unsubscribe send an email to coresight-leave@lists.linaro.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel