From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8569C433EF for ; Sat, 23 Apr 2022 12:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KXBDWak5IdJO4BGS/BF3ECFvGwy7SXdKOM59ARrXq4Y=; b=LmShK7qBYKxWEQ c/AIXPV+LDbIO1k6cm2yYswdhwKtUXE68qLABtP9D8/u5LiqGZF/L+FCm15FOlAFU9x4JFdRG4ssq AA3ppWFJQ2j7x5dA9feiWdwfoWN9ur+kJRELzDpM9GUdmVDaT2kclKiZDa8oIODMNZ2jynkydffpH +4WvVoG9ppNN9ihEvTVM2vyOB6q2cIoQ8jvZgRy0ywmTS/VbJrRwAt7gZ6eYNVCjo1S+XdYEQ8uZ3 MWZT2jvub2wDPJXtVpy/2r+M2PXGkZQhQYHThK1Gv+pDehbP7HbQG2Z2OVEPiCYE+NCQOKj5l4Xyl xFdskS9uwIYsGDQ1xIAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niFIb-004NRJ-3d; Sat, 23 Apr 2022 12:55:41 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niFIY-004NK8-6n for linux-arm-kernel@lists.infradead.org; Sat, 23 Apr 2022 12:55:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650718538; x=1682254538; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=OBOX3LfVl7XRiJUyCXwa9+7Ll3XU3H92WTMvH//IWQI=; b=SrrNvcCkxKRRo5Ai987p92keOyoU2mZILnLCA686Rxx1DH232QqkruUG 8M2c3kEPEIaQ6z1l6Ksb2ZRy+MMK0/6w+++Vwf53ZAqqIs1iL58bfyDXN u2WPXlAc/jPtNfy8BWPBDkN1jITIk3zLRFFoeEkiwrLK7WOLOmh7pZUSc ZYCKivjXEKP1bxpUcO7gz7lLU3GImUWjM2gwdTY4LJL7soMcqsKSatV2q meYTzM3FEG+i3RP1EqfUNrbgchbOjNnedbpPFfoh94jQSNi0b53QmFmMU axwQ44H0w5c+V/hGWh1+bmHnYry3yyL+y23RX+SglzsJbnqLEoBep/7gy A==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="244818047" X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="244818047" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 05:53:35 -0700 X-IronPort-AV: E=Sophos;i="5.90,284,1643702400"; d="scan'208";a="556858428" Received: from vietqle-mobl1.amr.corp.intel.com (HELO [10.212.229.58]) ([10.212.229.58]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2022 05:53:33 -0700 Message-ID: <8e09af67-a416-4ead-b406-6c8b998de344@linux.intel.com> Date: Sat, 23 Apr 2022 05:53:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v5 2/5] perf: Add SNOOP_PEER flag to perf mem data struct Content-Language: en-US To: Leo Yan , Ali Saidi Cc: kan.liang@linux.intel.com, Nick.Forrington@arm.com, acme@kernel.org, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, benh@kernel.crashing.org, german.gomez@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org References: <20220422212249.22463-1-alisaidi@amazon.com> <20220423063805.GA559531@leoy-ThinkPad-X240s> From: Andi Kleen In-Reply-To: <20220423063805.GA559531@leoy-ThinkPad-X240s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220423_055538_285559_8FA82839 X-CRM114-Status: UNSURE ( 7.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Except SNOOPX_FWD means a no modified cache snooping, it also means it's > a cache conherency from *remote* socket. This is quite different from we > define SNOOPX_PEER, which only snoop from peer CPU or clusters. > > If no objection, I prefer we could keep the new snoop type SNOOPX_PEER, > this would be easier for us to distinguish the semantics and support the > statistics for SNOOPX_FWD and SNOOPX_PEER separately. > > I overlooked the flag SNOOPX_FWD, thanks a lot for Kan's reminding. Yes seems better to keep using a separate flag if they don't exactly match. It's not that we're short on flags anyways. -Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel